clearn up

Author: mkuettner97

src/Battery/PowerManager.c

@@ -8,32 +8,11 @@
 #include <zephyr/logging/log.h>
 LOG_MODULE_REGISTER(battery_pub, CONFIG_MODULE_BUTTON_HANDLER_LOG_LEVEL);
 
-//K_MSGQ_DEFINE(battery_queue, sizeof(struct battery_data), 1, 4);
-
 struct load_switch_data {
     struct gpio_dt_spec ctrl_pin;
     bool default_on;
 };
 
-/*
-void battery_chan_update() {
-    int ret;
-
-	while (1) {
-		k_msgq_get(&battery_queue, &pm_msg, K_FOREVER);
-
-		ret = zbus_chan_pub(&battery_chan, &pm_msg, K_FOREVER); //K_NO_WAIT
-		if (ret) {
-			LOG_ERR("Failed to publish battery msg, ret: %d", ret);
-		}
-	}
-}
-
-K_THREAD_DEFINE(battery_publish, 1024, battery_chan_update, NULL, NULL, //CONFIG_BUTTON_PUBLISH_STACK_SIZE
-		NULL, K_PRIO_PREEMPT(CONFIG_BUTTON_PUBLISH_THREAD_PRIO), 0, 0); //CONFIG_BUTTON_PUBLISH_THREAD_PRIO
-*/
-
-
 static int b_init(const struct device *dev)
 {
     ARG_UNUSED(dev);

src/SD_Card/SDLogger/SDLogger.cpp

@@ -62,7 +62,8 @@ void sd_listener_callback(const struct zbus_channel *chan)
         power_manager.set_error_led();
         LOG_ERR("SD card removed mid recording. Stop recording.");
 
-        sdlogger.end();
+        // sdlogger.end();
+        sdlogger.is_open = false;
     }
 }
 

src/SensorManager/SensorManager.cpp

@@ -50,6 +50,8 @@ static struct k_work config_work;
 
 struct k_work_q sensor_work_q;
 
+K_THREAD_STACK_DEFINE(sensor_publish_thread_stack, CONFIG_SENSOR_PUB_STACK_SIZE);
+
 int active_sensors = 0;
 
 static void config_work_handler(struct k_work *work);
@@ -69,8 +71,6 @@ void sensor_chan_update(void *p1, void *p2, void *p3) {
 	}
 }
 
-K_THREAD_STACK_DEFINE(sensor_publish_thread_stack, CONFIG_SENSOR_PUB_STACK_SIZE);
-
 void init_sensor_manager() {
 	_state = INIT;
 

src/bluetooth/gatt_services/battery_service.cpp

@@ -17,8 +17,6 @@ LOG_MODULE_REGISTER(battery_service, CONFIG_MODULE_BUTTON_HANDLER_LOG_LEVEL);
 static struct battery_data msg;
 static bool notify_enabled;
 
-//DEFINE_GATT_SERVICE(battery, bt_send_battery_level, &msg); //(power_manager);
-
 static struct k_thread thread_data;
 static k_tid_t thread_id;
 

src/bluetooth/gatt_services/led_service.cpp

@@ -10,9 +10,6 @@ static ssize_t write_led(struct bt_conn *conn,
 			 const void *buf,
 			 uint16_t len, uint16_t offset, uint8_t flags)
 {
-	//printk("Attribute write, handle: %u, conn: %p", attr->handle,
-		//(void *)conn);
-
 	if (len != 3U) {
 		LOG_INF("Write led: Incorrect data length");
 		return BT_GATT_ERR(BT_ATT_ERR_INVALID_ATTRIBUTE_LEN);
@@ -23,9 +20,6 @@ static ssize_t write_led(struct bt_conn *conn,
 		return BT_GATT_ERR(BT_ATT_ERR_INVALID_OFFSET);
 	}
 
-    //earable_led.set_color((uint8_t*)buf);
-	//led_controller.setColor((uint8_t*)buf);
-
 	state_indicator.set_custom_color((uint8_t *) buf);
 
 	return len;

src/buttons/button_manager.c

@@ -28,5 +28,5 @@ void button_pub_task() {
 	}
 }
 
-K_THREAD_DEFINE(button_publish, 1024, button_pub_task, NULL, NULL, //CONFIG_BUTTON_PUBLISH_STACK_SIZE
+K_THREAD_DEFINE(button_publish, CONFIG_BUTTON_PUBLISH_STACK_SIZE, button_pub_task, NULL, NULL,
 		NULL, K_PRIO_PREEMPT(CONFIG_BUTTON_PUBLISH_THREAD_PRIO), 0, 0);