Merge pull request #2630 from OpenFAST/dev

deslaughter · web-flow · commit fc1110183bcc · 2025-02-10T22:47:39.000-05:00
Release 4.0.2
diff --git a/docs/OtherSupporting/OpenFAST_coords.pdf b/docs/OtherSupporting/OpenFAST_coords.pdf
diff --git a/docs/changelogs/ReleaseProcess.md b/docs/changelogs/ReleaseProcess.md
@@ -5,6 +5,7 @@
 1. Create release changelog.md
 2. Post PR with contents of the changelog/release notes
 3. Get reviews and address all issues
+4. Add changelog for the release -- include all PR's that will be included
 
 ### PR branch updates
 1. checkout branch to merge in and verify builds on VS if any changes for VS or new files added
@@ -40,14 +41,15 @@ After posting and tagging release
    * `rm -rf vs-build`
    * `git checkout vs-build`
 3. Set a couple of VS files to not track changes on files that VS wants to update Windows related stuff in
-      ```
+   ```
    git update-index --assume-unchanged vs-build/MAPlib/MAP_dll.vcxproj vs-uild/Registry/FAST_Registry.vcxproj
    ```
 
 4. Compile executables for Windows builds
    * Run one of the executables and check the version info. Muck about with VS if there is an issue.
    * Also run `dumpbin.exe /dependents <exe>.exe` to check static linking
    * NOTE: build the simulink last -- it messes up some things otherwise
+    - [ ] AeroDisk_Driver_x64.exe
     - [ ] AeroDyn_Driver_x64.exe
     - [ ] AeroDyn_Driver_x64_OpenMP.exe
     - [ ] AeroDyn_Inflow_C_Binding_x64.dll
@@ -69,9 +71,11 @@ After posting and tagging release
     - [ ] MoorDyn_C_Binding_x64.dll
     - [ ] OpenFAST-Simulink_x64.dll -- change `additional dependencies` in the `OpenFAST-Simulink` project in `FAST` to point to correct install of MATLAB
     - [ ] openfast_x64.exe
+    - [ ] SeaStateDriver_x64.exe
+    - [ ] SimpleElastoDyn_x64.exe
     - [ ] SubDyn_x64.exe
     - [ ] Turbsim_x64.exe
-
+    - [ ] UnsteadyAero_x64.exe
 5. Upload all filesUnset the no tracking of files
    ```
    git ls-files -v | grep "^[a-z]"
diff --git a/docs/changelogs/v4.0.2.md b/docs/changelogs/v4.0.2.md
@@ -0,0 +1,63 @@
+**Feature or improvement description**
+Pull request to merge `rc-4.0.2` into `main` and create a tagged release for v4.0.2
+
+See the milestone and project pages for additional information
+
+    https://github.com/OpenFAST/openfast/milestone/18
+
+Test results, if applicable
+See GitHub Actions
+
+### Release checklist:
+- [ ] Update the documentation version in docs/conf.py
+- [ ] Update the versions in docs/source/user/api\_change.rst
+- [ ] Verify readthedocs builds correctly
+- [ ] Create a tag in OpenFAST
+- [ ] Create a merge commit in r-test and add a corresponding annotated tag
+- [ ] Compile executables for Windows builds
+    - [ ] `AeroDyn_Driver_x64.exe`
+    - [ ] `AeroDyn_Driver_x64_OpenMP.exe`
+    - [ ] `AeroDyn_Inflow_C_Binding_x64.dll`
+    - [ ] `AeroDyn_Inflow_C_Binding_x64_OpenMP.dll`
+    - [ ] `BeamDyn_Driver_x64.exe`
+    - [ ] `DISCON.dll (x64)`
+    - [ ] `DISCON_ITIBarge.dll (x64)`
+    - [ ] `DISCON_OC3Hywind.dll (x64)`
+    - [ ] `DISCON_SC.dll (x64)`
+    - [ ] `FAST.Farm_x64.exe`
+    - [ ] `FAST.Farm_x64_OMP.exe`
+    - [ ] `FAST_SFunc.mexw64`
+    - [ ] `HydroDynDriver_x64.exe`
+    - [ ] `HydroDyn_C_Binding_x64.dll`
+    - [ ] `IfW_C_Binding_x64.dll`
+    - [ ] `InflowWind_Driver_x64.exe`
+    - [ ] `InflowWind_Driver_x64_OpenMP.exe`
+    - [ ] `MoorDyn_Driver_x64.exe`
+    - [ ] `MoorDyn_C_Binding_x64.dll`
+    - [ ] `OpenFAST-Simulink_x64.dll`
+    - [ ] `openfast_x64.exe`
+    - [ ] `SubDyn_x64.exe`
+    - [ ] `Turbsim_x64.exe`
+
+# Changelog
+
+## Overview
+
+This release includes a bug fix to the `ExternalInflow` module which is used by AMR-Wind to provide wind velocities to AeroDyn and receive aerodynamic forces. It also contains additional documentation on OpenFAST coordinate systems and more information on the release process.
+
+## General
+
+#2626 Docs: add presentation overview of OF Coordinate systems (2024) (@andrew-platt)
+
+#2627 Update ReleaseProcess.md notes (@andrew-platt)
+
+## Module changes
+
+### ExternalInflow
+
+#2628 Fix bug in ExternalInflow Orientation indexing (@deslaughter)
+
+## Input file changes
+
+No input file changes are required from 4.0.1.
+
diff --git a/docs/conf.py b/docs/conf.py
@@ -138,7 +138,7 @@ def runDoxygen(sourcfile, doxyfileIn, doxyfileOut):
 # The short X.Y version.
 version = u'4.0'
 # The full version, including alpha/beta/rc tags.
-release = u'v4.0.1'
+release = u'v4.0.2'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.
diff --git a/docs/source/user/api_change.rst b/docs/source/user/api_change.rst
@@ -10,6 +10,11 @@ The line number corresponds to the resulting line number after all changes are i
 Thus, be sure to implement each in order so that subsequent line numbers are correct.
 
 
+OpenFAST v4.0.1 to OpenFAST v4.0.2
+----------------------------------
+
+No input file changes were made.
+
 
 OpenFAST v4.0.0 to OpenFAST v4.0.1
 ----------------------------------
diff --git a/docs/source/user/elastodyn/coordsys.rst b/docs/source/user/elastodyn/coordsys.rst
@@ -6,6 +6,9 @@ Coordinate systems
 
 For the coordinates system not detailed in subsections below, please refer to the following references:
 
+- :download:`OpenFAST_coords.pdf <../../../OtherSupporting/OpenFAST_coords.pdf>`:
+  Presentation from 2024 overviewing some coordinate systems in OpenFAST.
+
 - `FAST 7 Manual <https://www.nrel.gov/docs/fy06osti/38230.pdf>`_
 
 - `Technical report <https://www.nrel.gov/docs/fy04osti/34755.pdf>`_ on FAST_AD and modeling of the UAE wind turbine (in section 3)
diff --git a/modules/externalinflow/src/ExternalInflow.f90 b/modules/externalinflow/src/ExternalInflow.f90
@@ -423,7 +423,7 @@ SUBROUTINE SetExtInfwPositions(p_FAST, u_AD, ExtInfw, ErrStat, ErrMsg)
          ExtInfw%u%xdotForce(Node) = real(ExtInfw%m%ActForceMotionsPoints(k)%TranslationVel(1,J),c_float)
          ExtInfw%u%ydotForce(Node) = real(ExtInfw%m%ActForceMotionsPoints(k)%TranslationVel(2,J),c_float)
          ExtInfw%u%zdotForce(Node) = real(ExtInfw%m%ActForceMotionsPoints(k)%TranslationVel(3,J),c_float)
-         ExtInfw%u%pOrientation((Node-1)*9_1:Node*9) = real(pack(ExtInfw%m%ActForceMotionsPoints(k)%Orientation(:,:,J),.true.),c_float)
+         ExtInfw%u%pOrientation((Node-1)*9+1:Node*9) = real(pack(ExtInfw%m%ActForceMotionsPoints(k)%Orientation(:,:,J),.true.),c_float)
       END DO
 
    END DO
diff --git a/openfast_io/pyproject.toml b/openfast_io/pyproject.toml
@@ -5,7 +5,7 @@ build-backend = "hatchling.build"
 [project]
 name = "openfast_io"
 # dynamic = ["version"]
-version = "4.0.1"
+version = "4.0.2"
 description = "Readers and writers for OpenFAST files."
 license = {file = "../LICENSE"}
 authors = [
diff --git a/reg_tests/CTestList.cmake b/reg_tests/CTestList.cmake
@@ -359,6 +359,7 @@ of_aeromap_regression("5MW_Land_AeroMap"               "aeromap;elastodyn;aerody
 if(BUILD_OPENFAST_CPP_DRIVER)
   of_cpp_interface_regression("5MW_Land_DLL_WTurb_cpp" "openfast;fastlib;cpp")
   of_cpp_interface_regression("5MW_Restart_cpp"        "openfast;fastlib;cpp;restart")
+  of_cpp_interface_regression("5MW_Land_DLL_WTurb_ExtInfw_cpp" "openfast;fastlib;extinfw;cpp")
 endif()
 
 # OpenFAST Driver test for OpenFAST C++ Library
