Migration to junit5 (#1776)

* Bump ibm image (old one is reported as ransomware by company firewall)

* Migration of sql module to junit5

* Migration of spatial module to junit5

* Migration of apt test module to junit5 (tested locally, bc by default are skipped) + fixed NoteTest.java tests

* Migration of codegen module to junit5

* Migration of codegen module to junit5

* Migration of collection module to junit5

* Migration of jpa codegen module to junit5

* Migration of r2dbc module to junit5

* Migration of jpa module to junit5

* Migration of maven module to junit5

* Migration of sql codegen module to junit5

* Migration of spatial module to junit5

* Migration of scala module to junit5

* Migration of kotlin and ksp module to junit5

* Migration of example modules to junit5

* Migration to junit 5 modules

* Migration to junit 5 modules - fixed tests that never been runned (even wrong config) + fixed bug with dialect functions registration and fix MetaDataExporter bug

* Migration to junit 5 modules - fixed tests that never been runned (even wrong config) + fixed bug with dialect functions registration and fix MetaDataExporter bug - velo requested changes

Author: kamilkrzywanski

pom.xml

@@ -300,11 +300,6 @@
       <artifactId>junit-jupiter-api</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.junit.vintage</groupId>
-      <artifactId>junit-vintage-engine</artifactId>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.easymock</groupId>
       <artifactId>easymock</artifactId>
@@ -989,6 +984,17 @@
       <properties>
         <excludedGroups>com.querydsl.core.testutil.Database,
                         com.querydsl.core.testutil.MongoDB,
+                        com.querydsl.core.testutil.CUBRID,
+                        com.querydsl.core.testutil.DB2,
+                        com.querydsl.core.testutil.Derby,
+                        com.querydsl.core.testutil.Firebird,
+                        com.querydsl.core.testutil.H2,
+                        com.querydsl.core.testutil.HSQLDB,
+                        com.querydsl.core.testutil.MySQL,
+                        com.querydsl.core.testutil.Oracle,
+                        com.querydsl.core.testutil.PostgreSQL,
+                        com.querydsl.core.testutil.SQLite,
+                        com.querydsl.core.testutil.SQLServer,
                         com.querydsl.core.testutil.SlowTest,
                         com.querydsl.core.testutil.Performance,
                         com.querydsl.core.testutil.ReportingOnly</excludedGroups>
@@ -1009,6 +1015,13 @@
         <!-- default groups to exclude from surefire plugin -->
         <excludedGroups>com.querydsl.core.testutil.ExternalDatabase,
                         com.querydsl.core.testutil.MongoDB,
+                        com.querydsl.core.testutil.CUBRID,
+                        com.querydsl.core.testutil.DB2,
+                        com.querydsl.core.testutil.Firebird,
+                        com.querydsl.core.testutil.MySQL,
+                        com.querydsl.core.testutil.Oracle,
+                        com.querydsl.core.testutil.PostgreSQL,
+                        com.querydsl.core.testutil.SQLServer,
                         com.querydsl.core.testutil.SlowTest,
                         com.querydsl.core.testutil.Performance,
                         com.querydsl.core.testutil.ReportingOnly</excludedGroups>

querydsl-examples/querydsl-example-jpa-guice/src/test/java/com/querydsl/example/jpa/guice/GuiceTestExtension.java

@@ -0,0 +1,16 @@
+package com.querydsl.example.jpa.guice;
+
+import com.google.inject.Guice;
+import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.jupiter.api.extension.TestInstanceFactory;
+import org.junit.jupiter.api.extension.TestInstanceFactoryContext;
+
+/** JUnit 5 replacement for the former {@code GuiceTestRunner}: builds test instances via Guice. */
+public class GuiceTestExtension implements TestInstanceFactory {
+
+  @Override
+  public Object createTestInstance(
+      TestInstanceFactoryContext factoryContext, ExtensionContext extensionContext) {
+    return Guice.createInjector(new ServiceModule()).getInstance(factoryContext.getTestClass());
+  }
+}

querydsl-examples/querydsl-example-jpa-guice/src/test/java/com/querydsl/example/jpa/guice/GuiceTestRunner.java

@@ -1,7 +1,7 @@
 package com.querydsl.example.jpa.repository;
 
 import com.google.inject.persist.Transactional;
-import com.querydsl.example.jpa.guice.GuiceTestRunner;
+import com.querydsl.example.jpa.guice.GuiceTestExtension;
 import jakarta.inject.Inject;
 import jakarta.inject.Provider;
 import jakarta.persistence.EntityManager;
@@ -11,14 +11,14 @@
 import java.util.List;
 import org.hibernate.Session;
 import org.hibernate.jdbc.Work;
-import org.junit.Before;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.ExtendWith;
 
-@RunWith(GuiceTestRunner.class)
+@ExtendWith(GuiceTestExtension.class)
 public abstract class AbstractPersistenceTest {
   @Inject private Provider<EntityManager> em;
 
-  @Before
+  @BeforeEach
   @Transactional
   public void before() {
     var entityManager = em.get();

querydsl-examples/querydsl-example-jpa-guice/src/test/java/com/querydsl/example/jpa/repository/AbstractPersistenceTest.java

@@ -10,7 +10,7 @@
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 public class TweetRepositoryTest extends AbstractPersistenceTest {
   @Inject private TweetRepository repository;

querydsl-examples/querydsl-example-jpa-guice/src/test/java/com/querydsl/example/jpa/repository/TweetRepositoryTest.java

@@ -4,7 +4,7 @@
 
 import com.querydsl.example.jpa.model.User;
 import jakarta.inject.Inject;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 public class UserRepositoryTest extends AbstractPersistenceTest {
   @Inject private UserRepository repository;

querydsl-examples/querydsl-example-jpa-guice/src/test/java/com/querydsl/example/jpa/repository/UserRepositoryTest.java

@@ -20,7 +20,7 @@ import com.querydsl.examples.kotlin.entity.ExampleEntity
 import com.querydsl.examples.kotlin.entity.QExampleEntity
 import com.querydsl.examples.kotlin.entity.QExampleEntity.Companion.exampleEntity
 import com.querydsl.jpa.impl.JPAQuery
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class ExampleEntityTest {
 

querydsl-examples/querydsl-example-kotlin-codegen/src/test/kotlin/com/querydsl/examples/kotlin/ExampleEntityTest.kt

@@ -20,7 +20,7 @@ import com.querydsl.examples.kotlin.entity.ExampleEntity
 import com.querydsl.examples.kotlin.entity.QExampleEntity
 import com.querydsl.examples.kotlin.entity.QExampleEntity.exampleEntity
 import com.querydsl.jpa.impl.JPAQuery
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class ExampleEntityTest {
 

querydsl-examples/querydsl-example-kotlin-jpa/src/test/kotlin/com/querydsl/examples/kotlin/ExampleEntityTest.kt

@@ -17,7 +17,7 @@
 package com.querydsl.examples.kotlin
 
 import com.querydsl.examples.kotlin.entity.QExampleEntity
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class ExampleEntityTest {
 

querydsl-examples/querydsl-example-kotlin-mongodb/src/test/kotlin/com/querydsl/examples/kotlin/ExampleEntityTest.kt

@@ -2,25 +2,25 @@
 
 import com.querydsl.example.config.TestConfiguration;
 import com.querydsl.example.config.TestDataService;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
 
-@RunWith(SpringJUnit4ClassRunner.class)
+@ExtendWith(SpringExtension.class)
 @ContextConfiguration(classes = {TestConfiguration.class})
 public abstract class AbstractDaoTest {
 
   @Autowired TestDataService testDataService;
 
-  @Before
+  @BeforeEach
   public void setUp() {
     testDataService.addTestData();
   }
 
-  @After
+  @AfterEach
   public void tearDown() throws Exception {
     testDataService.removeTestData();
   }