misleading host prefix and better tests

Author: taylordowns2000

packages/opencrvs/src/Utils.js

@@ -57,11 +57,7 @@ export const prepareNextState = (state, response, callback = s => s) => {
   return callback(nextState);
 };
 
-const HOST_PREFIX = {
-  gateway: 'gateway',
-  register: 'register',
-  countryconfig: 'countryconfig',
-};
+const VALID_HOSTS = new Set(['gateway', 'register', 'countryconfig']);
 
 export async function request(configuration, method, path, opts) {
   const { domain, access_token } = configuration;
@@ -70,12 +66,11 @@ export async function request(configuration, method, path, opts) {
 
   assertRelativeUrl(path);
 
-  const prefix = HOST_PREFIX[host];
-  if (!prefix) {
+  if (!VALID_HOSTS.has(host)) {
     throw new Error(
-      `Unknown OpenCRVS host '${host}'. Expected one of: ${Object.keys(
-        HOST_PREFIX
-      ).join(', ')}`
+      `Unknown OpenCRVS host '${host}'. Expected one of: ${[
+        ...VALID_HOSTS,
+      ].join(', ')}`
     );
   }
 
@@ -87,7 +82,7 @@ export async function request(configuration, method, path, opts) {
     },
     query: params,
     parseAs,
-    baseUrl: `https://${prefix}.${domain}`,
+    baseUrl: `https://${host}.${domain}`,
   };
 
   return commonRequest(method, path, options).then(logResponse);

packages/opencrvs/test/Adaptor.test.js

@@ -510,6 +510,29 @@ describe('submitBirthNotification', () => {
       trackingId: 'TRK99',
     });
   });
+
+  it('throws if createEvent response is missing an id', async () => {
+    registerServer
+      .intercept({ path: '/api/events/events', method: 'POST' })
+      .reply(200, {});
+
+    let error;
+    try {
+      await execute(
+        submitBirthNotification(
+          { 'child.name': { firstname: 'Test', surname: 'Baby' } },
+          { createdAtLocation: 'loc-1' }
+        )
+      )(state);
+    } catch (e) {
+      error = e;
+    }
+
+    expect(error).to.exist;
+    expect(error.message).to.match(
+      /createEvent response did not include an id/
+    );
+  });
 });
 
 describe('getLocations', () => {