fix: normalise opacity visibility check across all toolbar audits

Author: dermatz

src/view/frontend/web/js/toolbar/audits/buttons-without-type.js

@@ -30,7 +30,7 @@ export default {
             if (type !== null && type.trim() !== '') return false;
             if (!btn.offsetParent && getComputedStyle(btn).position !== 'fixed') return false;
             const style = getComputedStyle(btn);
-            if (style.visibility === 'hidden' || style.display === 'none' || style.opacity === '0') return false;
+            if (style.visibility === 'hidden' || style.display === 'none' || parseFloat(style.opacity) === 0) return false;
             return true;
         });
 

src/view/frontend/web/js/toolbar/audits/empty-interactive.js

@@ -28,7 +28,7 @@ export default {
             // Visibility check
             if (!el.offsetParent && getComputedStyle(el).position !== 'fixed') return false;
             const style = getComputedStyle(el);
-            if (style.visibility === 'hidden' || style.display === 'none' || style.opacity === '0') return false;
+            if (style.visibility === 'hidden' || style.display === 'none' || parseFloat(style.opacity) === 0) return false;
 
             // Accessible name sources
             if (el.getAttribute('aria-label')?.trim()) return false;

src/view/frontend/web/js/toolbar/audits/images-without-dimensions.js

@@ -26,7 +26,7 @@ export default {
         const images = Array.from(document.querySelectorAll('img')).filter(img => {
             if (!img.offsetParent && getComputedStyle(img).position !== 'fixed') return false;
             const style = getComputedStyle(img);
-            if (style.visibility === 'hidden' || style.display === 'none' || style.opacity === '0') return false;
+            if (style.visibility === 'hidden' || style.display === 'none' || parseFloat(style.opacity) === 0) return false;
             return !img.hasAttribute('width') || !img.hasAttribute('height');
         });
 

src/view/frontend/web/js/toolbar/audits/multiple-h1.js

@@ -27,7 +27,7 @@ export default {
         const h1s = Array.from(document.querySelectorAll('h1')).filter(el => {
             if (!el.offsetParent && getComputedStyle(el).position !== 'fixed') return false;
             const style = getComputedStyle(el);
-            if (style.visibility === 'hidden' || style.display === 'none' || style.opacity === '0') return false;
+            if (style.visibility === 'hidden' || style.display === 'none' || parseFloat(style.opacity) === 0) return false;
             return true;
         });
 

src/view/frontend/web/js/toolbar/audits/small-touch-targets.js

@@ -45,7 +45,7 @@ export default {
             if (el.matches('[disabled], [aria-disabled="true"]')) return false;
             if (!el.offsetParent && getComputedStyle(el).position !== 'fixed') return false;
             const style = getComputedStyle(el);
-            if (style.visibility === 'hidden' || style.display === 'none' || style.opacity === '0') return false;
+            if (style.visibility === 'hidden' || style.display === 'none' || parseFloat(style.opacity) === 0) return false;
 
             const rect = el.getBoundingClientRect();
             return rect.width < MIN_SIZE || rect.height < MIN_SIZE;

src/view/frontend/web/js/toolbar/audits/unsafe-blank-target.js

@@ -33,7 +33,7 @@ export default {
         ).filter(el => {
             if (!el.offsetParent && getComputedStyle(el).position !== 'fixed') return false;
             const style = getComputedStyle(el);
-            if (style.visibility === 'hidden' || style.display === 'none' || style.opacity === '0') return false;
+            if (style.visibility === 'hidden' || style.display === 'none' || parseFloat(style.opacity) === 0) return false;
 
             const rel = (el.getAttribute('rel') || '').toLowerCase().split(/\s+/);
             return !rel.includes('noopener') && !rel.includes('noreferrer');