feat: Enhance composer dependency checks with improved path resolution and error handling 🛠️

Author: dermatz

src/Service/ThemeChecker/MagentoStandard/Checker.php

@@ -40,65 +40,135 @@ public function checkComposerDependencies(string $themePath): array
             return ['error' => 'Composer not found on the system.'];
         }
 
+        // Find the correct composer path to use
+        $composerConfig = $this->findComposerPath($themePath);
+        if (isset($composerConfig['warning'])) {
+            return $composerConfig;
+        }
+
+        $composerPath = $composerConfig['path'];
+        $usingProjectRoot = $composerConfig['using_project_root'];
+
+        // Get dependencies using JSON format first
+        $result = $this->getComposerDependenciesJson($composerPath);
+
+        // If JSON format failed, try table format
+        if (empty($result)) {
+            $result = $this->getComposerDependenciesTable($composerPath);
+        }
+
+        // If we have results, add metadata
+        if (!empty($result) && !isset($result['error'])) {
+            $result = $this->addComposerMetadata($result, $usingProjectRoot, $composerPath);
+            return $result;
+        }
+
+        return $result ?: ['error' => 'Error parsing composer outdated output.'];
+    }
+
+    /**
+     * Find the appropriate path for composer operations
+     *
+     * @param string $themePath The theme path to check
+     * @return array Configuration with path and flag
+     */
+    protected function findComposerPath(string $themePath): array
+    {
         // Check if the theme has a vendor directory
         $hasVendorDir = $this->fileSystem->isDir($themePath . '/vendor');
 
-        // If there is no vendor directory in the theme, try to use the project root vendor
-        if (!$hasVendorDir) {
-            $projectRoot = $this->findProjectRoot();
-            if (empty($projectRoot) || !$this->fileSystem->isDir($projectRoot . '/vendor')) {
-                return ['warning' => 'No vendor directory found in theme or project root.'];
-            }
-            $usingProjectRoot = true;
-            $composerPath = $projectRoot;
-        } else {
-            $usingProjectRoot = false;
-            $composerPath = $themePath;
+        if ($hasVendorDir) {
+            return [
+                'path' => $themePath,
+                'using_project_root' => false
+            ];
         }
 
-        // Run composer outdated
+        // If no vendor directory in theme, try project root
+        $projectRoot = $this->findProjectRoot();
+        if (!empty($projectRoot) && $this->fileSystem->isDir($projectRoot . '/vendor')) {
+            return [
+                'path' => $projectRoot,
+                'using_project_root' => true
+            ];
+        }
+
+        // No valid vendor directory found
+        return ['warning' => 'No vendor directory found in theme or project root.'];
+    }
+
+    /**
+     * Get composer dependencies using JSON format
+     *
+     * @param string $composerPath Path to run composer in
+     * @return array Results or empty array if failed
+     */
+    protected function getComposerDependenciesJson(string $composerPath): array
+    {
         $cwd = $this->fileSystem->getCurrentDir();
         $this->fileSystem->changeDir($composerPath);
+
         $output = [];
         $exitCode = 0;
         $this->safeExec('composer outdated --direct --format=json 2>/dev/null', $output, $exitCode);
+
         $this->fileSystem->changeDir($cwd);
 
-        // Parse JSON output if available
-        if (!empty($output)) {
-            $jsonOutput = implode('', $output);
-            $outdated = json_decode($jsonOutput, true);
+        if (empty($output)) {
+            return [];
+        }
 
-            if (json_last_error() === JSON_ERROR_NONE && isset($outdated['installed'])) {
-                $result = $outdated['installed'];
-                if ($usingProjectRoot) {
-                    $result['_meta'] = [
-                        'using_project_root' => true,
-                        'project_root' => $composerPath
-                    ];
-                }
-                return $result;
-            }
+        $jsonOutput = implode('', $output);
+        $outdated = json_decode($jsonOutput, true);
+
+        if (json_last_error() === JSON_ERROR_NONE && isset($outdated['installed'])) {
+            return $outdated['installed'];
         }
 
-        // If JSON parsing failed or no structured output, try the table format
-        $output = [];
+        return [];
+    }
+
+    /**
+     * Get composer dependencies using table format
+     *
+     * @param string $composerPath Path to run composer in
+     * @return array Results or empty array if failed
+     */
+    protected function getComposerDependenciesTable(string $composerPath): array
+    {
+        $cwd = $this->fileSystem->getCurrentDir();
         $this->fileSystem->changeDir($composerPath);
+
+        $output = [];
         $this->safeExec('composer outdated --direct 2>/dev/null', $output);
+
         $this->fileSystem->changeDir($cwd);
 
         if (!empty($output)) {
-            $result = $this->parseComposerOutdatedOutput($output);
-            if ($usingProjectRoot) {
-                $result['_meta'] = [
-                    'using_project_root' => true,
-                    'project_root' => $composerPath
-                ];
-            }
-            return $result;
+            return $this->parseComposerOutdatedOutput($output);
         }
 
-        return ['error' => 'Error parsing composer outdated output.'];
+        return [];
+    }
+
+    /**
+     * Add metadata to composer results
+     *
+     * @param array $result The dependency results
+     * @param bool $usingProjectRoot Whether using project root
+     * @param string $composerPath The path used
+     * @return array Results with metadata
+     */
+    protected function addComposerMetadata(array $result, bool $usingProjectRoot, string $composerPath): array
+    {
+        if ($usingProjectRoot) {
+            $result['_meta'] = [
+                'using_project_root' => true,
+                'project_root' => $composerPath
+            ];
+        }
+
+        return $result;
     }    /**
      * {@inheritdoc}
      */