Commit 61a9f04
Fix merge_networks tests' scope auth; revert docs.yml gufe bump
CI ran the env solve and tests cleanly with the gufe/openfe/feflow
trio bump (b63474e), revealing two real bugs:
1. The four merge_networks client tests merged into destination
scopes the test identity does not have access to (e.g.
`test_org-test_campaign-merged_project`). The test identity only
has the three scopes in `multiple_scopes` (scope_test plus two
others); creating a "new project" under the same org/campaign was
not, in fact, authorized. Switch the destination scope to one the
identity has:
- test_merge_networks: scope_test (collision-free because the
merged network's name differs from pre-loaded networks)
- test_merge_networks_respects_state: scope_test (each parametrize
case uses a unique network name)
- test_merge_networks_preserves_tasks_and_results: multiple_scopes[1]
(different from where the source Tasks were set up, so the
per-`_project` Task/PDRR counts stay clean)
2. The docs.yml gufe bump from 1.3.0 to 1.10.0 breaks the RTD build,
because sphinx 9's autodoc dynamic-importer trips on
`gufe/settings/models.py`:
ph: PositiveFloat | None = Field(None, ...)
~~~~~~~~~~~~~~^~~~~~
TypeError: unsupported operand type(s) for |: 'PositiveFloat' and 'NoneType'
gufe 1.3.0 still allows pydantic v1 (where PositiveFloat is a
class with `__or__`); gufe >=1.8.0 forces pydantic v2 (where
PositiveFloat is `Annotated[float, ...]`, no `__or__`). docs.yml
only needs gufe for intersphinx and type-hint resolution; neither
benefits from the bump. Revert docs.yml to its pre-PR state.
Also polish the client merge_networks docstring with a `set_tasks_status`
hint alongside `action_tasks` for the errored-Task remediation path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent b63474e commit 61a9f04
3 files changed
Lines changed: 23 additions & 29 deletions
File tree
- alchemiscale
- interface
- tests/integration/interface/client
- devtools/conda-envs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
214 | 211 | | |
215 | 212 | | |
216 | 213 | | |
| |||
224 | 221 | | |
225 | 222 | | |
226 | 223 | | |
227 | | - | |
228 | | - | |
| 224 | + | |
| 225 | + | |
229 | 226 | | |
230 | 227 | | |
231 | | - | |
| 228 | + | |
232 | 229 | | |
233 | 230 | | |
234 | 231 | | |
| |||
Lines changed: 14 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
222 | 220 | | |
223 | 221 | | |
224 | 222 | | |
| |||
261 | 259 | | |
262 | 260 | | |
263 | 261 | | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
269 | 266 | | |
270 | 267 | | |
271 | 268 | | |
| |||
324 | 321 | | |
325 | 322 | | |
326 | 323 | | |
| 324 | + | |
327 | 325 | | |
328 | 326 | | |
329 | 327 | | |
| |||
363 | 361 | | |
364 | 362 | | |
365 | 363 | | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
372 | 369 | | |
373 | 370 | | |
374 | 371 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
0 commit comments