Skip to content

Commit d1f616d

Browse files
authored
fix: normalize Additional Host Path Mounts textarea to a comma list (#740)
* fix: normalize Additional Host Path Mounts textarea to a comma list The field's help text says "one per line", but the multiline value was rendered into a single-quoted YAML scalar, which YAML-folds the newline into a space. runtime-api then split only on commas/newlines, so the space-joined value became one malformed token and was skipped — no mounts. Normalize newlines to a comma list at render time (the proven splitList/trim/join idiom used for the model textareas), so the env var is always a clean single-line comma list. Works with the currently deployed runtime-api too, no image rebuild required. * chore: touch image-loader to trigger required chart CI The branch-protection ruleset requires the 9 path-filtered publish-charts(...) checks, which never run on replicated/-only PRs, leaving them permanently BLOCKED. Touch a standalone chart to fire the chart workflow so those checks report. (Also a true doc note.)
1 parent aa5a2e8 commit d1f616d

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

charts/image-loader/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# Agent-server image the loader pre-pulls onto nodes; keep tag in sync with the sandbox runtime.
12
image:
23
repository: ghcr.io/openhands/agent-server
34
tag: 1.28.0-python

replicated/openhands.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,8 @@ spec:
314314
CPU_LIMIT: 'repl{{ ConfigOption "sandbox_cpu_limit" }}'
315315
LOG_LEVEL: 'repl{{ ConfigOption "log_level" }}'
316316
ADDITIONAL_CONFIGMAPS: "openhands-ca-bundle:/etc/openhands/ca-bundle"
317-
ADDITIONAL_HOST_PATHS: 'repl{{ ConfigOption "sandbox_additional_host_paths" }}'
317+
# Textarea is "one per line"; normalize to a comma list so a multiline value isn't YAML-folded into a space-joined token.
318+
ADDITIONAL_HOST_PATHS: 'repl{{ $hp := list }}repl{{ range $raw := splitList "\n" (ConfigOption "sandbox_additional_host_paths" | replace "\r" "\n") }}repl{{ $e := trim $raw }}repl{{ if $e }}repl{{ $hp = append $hp $e }}repl{{ end }}repl{{ end }}repl{{ $hp | join "," }}'
318319
SANDBOX_KVM_ENABLED: 'repl{{ ConfigOptionEquals "sandbox_kvm_enabled" "1" }}'
319320
KVM_DEVICE_RESOURCE: "smarter-devices/kvm"
320321
kvm:

0 commit comments

Comments
 (0)