Address review 5: mint a fresh id on create (global id uniqueness)

The active pointer is keyed on AgentProfile.id, so ids must be globally unique,
not just stable per file. save now mints a server id on create (ignoring any
client-supplied id) and preserves it only on overwrite. Prevents a client from
creating two names with the same id, which made the pointer ambiguous (deleting
one could clear the active selection while a namesake id lives on).

Test: creating 'b' with 'a's id yields a distinct id; activating b then
deleting a leaves the pointer intact.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: Simon Rosenberg

openhands-agent-server/openhands/agent_server/agent_profiles_router.py

@@ -15,7 +15,7 @@
 from collections.abc import Iterator
 from contextlib import contextmanager
 from typing import Annotated, Any
-from uuid import UUID
+from uuid import UUID, uuid4
 
 from fastapi import APIRouter, HTTPException, Path, Request, status
 from pydantic import BaseModel, Field, ValidationError
@@ -408,14 +408,18 @@ async def save_agent_profile(
     profile = _decrypt_profile_mcp_tools(profile, cipher)
 
     store = AgentProfileStore()
-    # The id is stable state, not a defaultable request field: overwriting a
-    # namesake keeps its id (so an active pointer never dangles) and bumps the
-    # revision, even when a create-style body omits both.
+    # The id is server-managed state, never a client-settable field — the active
+    # pointer is keyed on it. Overwriting a namesake keeps its id (so the pointer
+    # never dangles) and bumps the revision; creating a new name always mints a
+    # fresh id (ignoring any client-supplied one) so ids stay globally unique and
+    # the pointer is never ambiguous.
     existing_id, existing_rev = _existing_identity(store, name)
     if existing_id is not None:
         profile = profile.model_copy(
             update={"id": existing_id, "revision": (existing_rev or 0) + 1}
         )
+    else:
+        profile = profile.model_copy(update={"id": uuid4()})
     try:
         with _store_errors():
             store.save(profile, cipher=cipher, max_profiles=MAX_AGENT_PROFILES)

tests/agent_server/test_agent_profiles_router.py

@@ -205,6 +205,26 @@ def test_overwrite_preserves_id_and_pointer(client, store):
     assert client.get("/api/settings").json()["active_agent_profile_id"] == pid
 
 
+def test_create_mints_fresh_id_ignoring_client_id(client):
+    """Creating a new name never reuses a client-supplied id (ids stay unique).
+
+    Duplicate ids would make the id-keyed active pointer ambiguous — deleting
+    one profile could clear the active selection while a namesake id lives on.
+    """
+    client.post("/api/agent-profiles/a", json={"llm_profile_ref": "x"})
+    a_id = client.get("/api/agent-profiles/a").json()["profile"]["id"]
+
+    # Try to create 'b' reusing a's id; the server must mint a fresh one.
+    client.post("/api/agent-profiles/b", json={"llm_profile_ref": "y", "id": a_id})
+    b_id = client.get("/api/agent-profiles/b").json()["profile"]["id"]
+    assert b_id != a_id
+
+    # Activate b, delete a: the pointer must survive (ids are distinct).
+    client.post(f"/api/agent-profiles/{b_id}/activate")
+    client.delete("/api/agent-profiles/a")
+    assert client.get("/api/settings").json()["active_agent_profile_id"] == b_id
+
+
 def test_save_path_name_is_authoritative(client, store):
     """The path name overrides any ``name`` in the body."""
     response = client.post(