Skip to content

Commit ad12511

Browse files
committed
Fix _GatedLLM.completion override after _return_metrics removal
The `_return_metrics` parameter was removed from LLM/TestLLM.completion in 2bedbd8 (removed_in 1.29.0, on this release branch), but tests/agent_server/test_goal_loop.py's _GatedLLM override (added in #3770) still declared it as a positional param and forwarded it to super().completion(), which pyright flagged as an incompatible override and a 5-positional call against the new 4-positional signature. Drop _return_metrics to match.
1 parent 884c996 commit ad12511

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

tests/agent_server/test_goal_loop.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ def completion(
4343
self,
4444
messages,
4545
tools=None,
46-
_return_metrics=False,
4746
add_security_risk_prediction=False,
4847
on_token=None,
4948
**kwargs,
@@ -53,7 +52,6 @@ def completion(
5352
return super().completion(
5453
messages,
5554
tools,
56-
_return_metrics,
5755
add_security_risk_prediction,
5856
on_token,
5957
**kwargs,

0 commit comments

Comments
 (0)