Skip to content

Commit 960f3a9

Browse files
authored
Merge pull request #226 from ericglau/1030
Untrack directories on Dockerfile change
2 parents c050562 + 1c83e43 commit 960f3a9

File tree

1 file changed

+9
-9
lines changed
  • src/main/java/io/openliberty/tools/common/plugins/util

1 file changed

+9
-9
lines changed

src/main/java/io/openliberty/tools/common/plugins/util/DevUtil.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2896,7 +2896,7 @@ private void processFileChanges(
28962896
copyFile(fileChanged, configDirectory, serverDirectory, null);
28972897

28982898
if (isDockerfileDirectoryChanged(serverDirectory, fileChanged)) {
2899-
restartOnDockerfileDirectoryChanged();
2899+
untrackDockerfileDirectoriesAndRestart();
29002900
} else {
29012901
if (changeType == ChangeType.CREATE) {
29022902
redeployApp();
@@ -2915,7 +2915,7 @@ private void processFileChanges(
29152915
info("Config file deleted: " + fileChanged.getName());
29162916
deleteFile(fileChanged, configDirectory, serverDirectory, null);
29172917
if (isDockerfileDirectoryChanged(serverDirectory, fileChanged)) {
2918-
restartOnDockerfileDirectoryChanged();
2918+
untrackDockerfileDirectoriesAndRestart();
29192919
} else {
29202920
if (fileChanged.getName().equals("server.env")) {
29212921
// re-enable debug variables in server.env
@@ -2943,7 +2943,7 @@ private void processFileChanges(
29432943
copyConfigFolder(fileChanged, serverXmlFileParent, "server.xml");
29442944
copyFile(fileChanged, serverXmlFileParent, serverDirectory, "server.xml");
29452945
if (isDockerfileDirectoryChanged(serverDirectory, fileChanged)) {
2946-
restartOnDockerfileDirectoryChanged();
2946+
untrackDockerfileDirectoriesAndRestart();
29472947
} else if (changeType == ChangeType.CREATE) {
29482948
redeployApp();
29492949
}
@@ -2954,7 +2954,7 @@ private void processFileChanges(
29542954
deleteFile(fileChanged, configDirectory, serverDirectory, "server.xml");
29552955
// Let this restart if needed for container mode. Otherwise, nothing else needs to be done for config file delete.
29562956
if (isDockerfileDirectoryChanged(serverDirectory, fileChanged)) {
2957-
restartOnDockerfileDirectoryChanged();
2957+
untrackDockerfileDirectoriesAndRestart();
29582958
}
29592959
runTestThread(true, executor, numApplicationUpdatedMessages, true, false);
29602960
}
@@ -2964,7 +2964,7 @@ private void processFileChanges(
29642964
// This is for bootstrap.properties outside of the config folder
29652965
// restart server to load new properties
29662966
if (isDockerfileDirectoryChanged(fileChanged)) {
2967-
restartOnDockerfileDirectoryChanged();
2967+
untrackDockerfileDirectoriesAndRestart();
29682968
} else {
29692969
restartServer(false);
29702970
}
@@ -2974,7 +2974,7 @@ private void processFileChanges(
29742974
// This is for jvm.options outside of the config folder
29752975
// restart server to load new options
29762976
if (isDockerfileDirectoryChanged(fileChanged)) {
2977-
restartOnDockerfileDirectoryChanged();
2977+
untrackDockerfileDirectoriesAndRestart();
29782978
} else {
29792979
restartServer(false);
29802980
}
@@ -3013,7 +3013,7 @@ private void processFileChanges(
30133013
} else if (fileChanged.equals(dockerfileUsed)
30143014
&& directory.startsWith(dockerfileUsed.getParentFile().getCanonicalFile().toPath())
30153015
&& changeType == ChangeType.MODIFY) { // dockerfile
3016-
restartServer(true); // rebuild container and restart
3016+
untrackDockerfileDirectoriesAndRestart(); // untrack all Dockerfile directories, then rebuild container and restart
30173017
} else if (propertyFilesMap != null && propertyFilesMap.keySet().contains(fileChanged)) { // properties file
30183018
boolean reloadedPropertyFile = reloadPropertyFile(fileChanged);
30193019
// run all tests on properties file change
@@ -3022,7 +3022,7 @@ private void processFileChanges(
30223022
}
30233023
} else if (isDockerfileDirectoryChanged(fileChanged)) {
30243024
// If contents within a directory specified in a Dockerfile COPY command were changed, and not already processed by one of the other conditions above.
3025-
restartOnDockerfileDirectoryChanged();
3025+
untrackDockerfileDirectoriesAndRestart();
30263026
}
30273027
}
30283028

@@ -3032,7 +3032,7 @@ private void processFileChanges(
30323032
*
30333033
* @throws PluginExecutionException
30343034
*/
3035-
private void restartOnDockerfileDirectoryChanged() throws PluginExecutionException {
3035+
private void untrackDockerfileDirectoriesAndRestart() throws PluginExecutionException {
30363036
// Cancel and clear any WatchKeys that were added for to the Dockerfile directories
30373037
for (WatchKey key : dockerfileDirectoriesWatchKeys) {
30383038
key.cancel();

0 commit comments

Comments
 (0)