Skip to content

Handle loose app with target directory outside of project root #876

Open
@ericglau

Description

@ericglau

Maven projects can have the target directory outside of the project root, see here e.g.

<build>
    <directory>/Users/eric/tmp</directory>
</build>

For dev mode with containers, the loose application xml would currently show something like the following, which does not work since the paths are not in the container.

<?xml version="1.0" encoding="UTF-8"?>
<archive>
    <dir sourceOnDisk="${io.openliberty.tools.projectRoot}/src/main/webapp" targetInArchive="/"/>
    <dir sourceOnDisk="/Users/eric/tmp/classes/java/main" targetInArchive="/WEB-INF/classes/"/>
    <file sourceOnDisk="/Users/eric/tmp/tmp/META-INF/MANIFEST.MF" targetInArchive="/META-INF/MANIFEST.MF"/>
</archive>

Consider adding another variable for the build dir in addition to the project root, and use that for variable substitution as well.

If the build dir is outside of the project root, it would also need to be mounted by the docker run command.

(Related Gradle issue: OpenLiberty/ci.gradle#489)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions