Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 81e1aa8

Browse files
authoredJan 28, 2021
Merge pull request #108 from awisniew90/test_diff
Remove diff plugin from tests
2 parents 544ee58 + 86a41ac commit 81e1aa8

File tree

2 files changed

+1
-34
lines changed

2 files changed

+1
-34
lines changed
 

‎.github/workflows/stack-regression-tests.yml

-25
Original file line numberDiff line numberDiff line change
@@ -11,29 +11,6 @@ jobs:
1111
- name: Checkout
1212
uses: actions/checkout@v2
1313

14-
- name: Get stack image diff
15-
id: stack-image-diff
16-
uses: softprops/diffset@v1
17-
with:
18-
base: main
19-
stackimage_files: |
20-
stackimage/*
21-
templates/stackimage/*
22-
env:
23-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
24-
25-
- name: Get outer loop diff
26-
id: outer-loop-diff
27-
uses: softprops/diffset@v1
28-
with:
29-
base: main
30-
outerloop_files: |
31-
stackimage/*
32-
templates/stackimage/*
33-
templates/outer-loop/*
34-
env:
35-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
36-
3714
- name: Setup Minikube
3815
uses: manusa/actions-setup-minikube@v2.3.0
3916
with:
@@ -66,12 +43,10 @@ jobs:
6643
run: ./test/utils.sh buildStack
6744

6845
- name: Build stack image
69-
if: steps.stack-image-diff.outputs.stackimage_files
7046
run: ./test/utils.sh buildStackImage
7147

7248
- name: Inner loop test
7349
run: ./test/stack-test-inner-loop.sh
7450

7551
- name: Outer loop test
76-
if: steps.outer-loop-diff.outputs.outerloop_files
7752
run: ./test/stack-test-outer-loop.sh

‎test/README.md

+1-9
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ This runs the `build.sh` script to generate all stack content in the `generated/
1616

1717
### Build stack image
1818

19-
The stack image is built if changes are detected to `stackimage/` or `templates/stackimage`
19+
The stack image is built into the local docker registry using the name:version specified in the devfile
2020

2121
### Run inner loop tests
2222

@@ -32,7 +32,6 @@ Tests against following endpoints:
3232

3333
### Run outer loop tests
3434

35-
Outerloop tests are only done if changes are detected to `templates/outer-loop` or any stack image content (`stackimage/` or `templates/stackimage`)
3635
Basic setup:
3736

3837
Clone application-stack-intro, build docker image, install OL operator, deploy.
@@ -48,7 +47,6 @@ Tests against following endpoints:
4847

4948
1. Tests are triggered on each PR or update to a PR
5049
1. All local docker images are available for use by the Minikube cluster since Minikube is installed/started with `driver=none` (bare metal)
51-
1. Changes to specific files (which gates what steps are run) is controlled via the `softprops/diffset@v1` actions plugin
5250

5351

5452
## Known issues
@@ -63,12 +61,6 @@ Error: unable to create ingress: error creating ingress: Internal error occurred
6361

6462
If this occurs, the tests will need to be rerun.
6563

66-
1. Warning message due to known "bug" in `softprops/diffset@v1` plugin (https://github.com/softprops/diffset/issues/5):
67-
68-
```
69-
Unexpected input(s) 'stackimage_files', valid inputs are ['base']
70-
```
71-
7264
## Future Tests
7365

7466
1. Validate version changes in build.sh to make sure proper incrementation (i.e. you changed the outerloop Dockerfile but didnt increment the outerloop version)

0 commit comments

Comments
 (0)
Please sign in to comment.