dev content review

Signed-off-by: Gilbert Kwan <[email protected]>

Author: gkwan-ibm

.github/workflows/test.yml

@@ -60,11 +60,20 @@ jobs:
       - name: Post tests
         if: always()
         run: |
+          sudo chmod -R +rx jar/build
+          sudo chmod -R +rx war/build
+          sudo chmod -R +rx ear/build
           logsPath=$(sudo find . -name "console.log" | grep ear);
           sudo cat "$logsPath" | sudo grep Launching
       - name: Archive server logs if failed
         if: failure()
         uses: actions/upload-artifact@v4
         with:
           name: ear-logs
-          path: finish/ear/target/liberty/wlp/usr/servers/defaultServer/logs/
+          path: finish/ear/build/wlp/usr/servers/defaultServer/logs/
+      - name: Archive reports if failed
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: reports
+          path: finish/**/build/reports/

scripts/testApp.sh

@@ -13,6 +13,23 @@ cat ./build.gradle
 ./gradlew libertyStart
 sleep 5
 curl http://localhost:9080/converter/ | grep "Height Converters"
+./gradlew ear:test
 ./gradlew libertyStop
 
+./gradlew jar:test
 ./gradlew war:test
+
+if [ ! -f "jar/build/libs/guide-gradle-multimodules-jar-1.0-SNAPSHOT.jar" ]; then
+  echo "jar/build/libs/guide-gradle-multimodules-jar-1.0-SNAPSHOT.jar was not generated!"
+  exit 1
+fi
+
+if [ ! -f "war/build/libs/guide-gradle-multimodules-war-1.0-SNAPSHOT.war" ]; then
+  echo "war/build/libs/guide-gradle-multimodules-war-1.0-SNAPSHOT.war was not generated!"
+  exit 1
+fi
+
+if [ ! -f "ear/build/libs/guide-gradle-multimodules-ear-1.0-SNAPSHOT.ear" ]; then
+  echo "ear/build/libs/guide-gradle-multimodules-ear-1.0-SNAPSHOT.ear was not generated!"
+  exit 1
+fi