dev content review comments fixed

Signed-off-by: Arun Venmany <[email protected]>

Author: venmanyarun

README.adoc

@@ -199,7 +199,7 @@ start/build.gradle
 include::finish/build.gradle[]
 ----
 
-Set the [hotspot=packaging file=1]`basic configuration` for the project. Apply [gradle-java-plugin file=1]`gradle-java-plugin` to all sub projects. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules.
+Set the [hotspot=packaging file=1]`common configuration` for the project. Apply [gradle-java-plugin file=1]`gradle-java-plugin` to all sub projects. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules.
 
 
 

finish/build.gradle

@@ -6,8 +6,10 @@ allprojects  {
 subprojects {
     apply plugin: 'java'
 
-    sourceCompatibility = JavaVersion.VERSION_11
-    targetCompatibility = JavaVersion.VERSION_11
+    java {
+        sourceCompatibility = JavaVersion.VERSION_11
+        targetCompatibility = JavaVersion.VERSION_11
+    }
 
     tasks.withType(JavaCompile).configureEach {
         options.encoding = 'UTF-8'

finish/ear/build.gradle

@@ -21,10 +21,6 @@ buildscript {
     }
 }
 
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
 
 dependencies {
     // tag::war[]

finish/jar/build.gradle

@@ -6,11 +6,6 @@ tasks.withType(JavaCompile).configureEach {
     options.encoding = 'UTF-8'
 }
 
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
-
 dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
 }

start/build.gradle

@@ -6,8 +6,10 @@ allprojects  {
 subprojects {
     apply plugin: 'java'
 
-    sourceCompatibility = JavaVersion.VERSION_11
-    targetCompatibility = JavaVersion.VERSION_11
+    java {
+        sourceCompatibility = JavaVersion.VERSION_11
+        targetCompatibility = JavaVersion.VERSION_11
+    }
 
     tasks.withType(JavaCompile).configureEach {
         options.encoding = 'UTF-8'

start/ear/build.gradle

@@ -14,11 +14,6 @@ buildscript {
     }
 }
 
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
-
 dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
 }

start/jar/build.gradle

@@ -5,12 +5,6 @@ description = 'JAR Module'
 tasks.withType(JavaCompile).configureEach {
     options.encoding = 'UTF-8'
 }
-
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
-
 dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
 }

start/settings.gradle

@@ -1 +1,20 @@
 rootProject.name = 'guide-gradle-multimodules'
+// tag::includeJar[]
+include ':jar'
+// end::includeJar[]
+// tag::includeWar[]
+include ':war'
+// end::includeWar[]
+// tag::includeEar[]
+include ':ear'
+// end::includeEar[]
+
+// tag::jarDir[]
+project(':jar').projectDir = "$rootDir/jar" as File
+// end::jarDir[]
+// tag::warDir[]
+project(':war').projectDir = "$rootDir/war" as File
+// end::warDir[]
+// tag::earDir[]
+project(':ear').projectDir = "$rootDir/ear" as File
+// end::earDir[]