dev content review comments fixed (#14)

venmanyarun · gkwan-ibm · web-flow · commit a1ddd4a68100 · 2025-02-19T18:16:49.000-05:00
* dev content review comments fixed

Signed-off-by: Arun Venmany &lt;Arun.Kumar.V.N@ibm.com&gt;

* dev content review comments fixed

Signed-off-by: Arun Venmany &lt;Arun.Kumar.V.N@ibm.com&gt;

* dev content review comments fixed

Signed-off-by: Arun Venmany &lt;Arun.Kumar.V.N@ibm.com&gt;

* dev content review

Signed-off-by: Gilbert Kwan &lt;gkwan@ca.ibm.com&gt;

---------

Signed-off-by: Arun Venmany &lt;Arun.Kumar.V.N@ibm.com&gt;
Signed-off-by: Gilbert Kwan &lt;gkwan@ca.ibm.com&gt;
Co-authored-by: Gilbert Kwan &lt;gkwan@ca.ibm.com&gt;
diff --git a/README.adoc b/README.adoc
@@ -8,7 +8,7 @@
 :projectid: gradle-multimodules
 :page-layout: guide-multipane
 :page-duration: 30 minutes
-:page-releasedate: 2025-01-29
+:page-releasedate: 2025-03-29
 :page-description: Learn how to build an application consisting of JAR, WAR, and EAR modules with Gradle
 :page-related-guides: ['gradle-intro']
 :page-seo-title: Building a multi-module enterprise Java application with Gradle and Open Liberty
@@ -199,7 +199,7 @@ start/build.gradle
 include::finish/build.gradle[]
 ----
 
-Set the [hotspot=packaging file=1]`basic configuration` for the project. Apply [gradle-java-plugin file=1]`gradle-java-plugin` to all sub projects. This allows each child module to inherit the plug-ins, so that you can use the these to develop the modules.
+Set the [hotspot=allprojects file=1]`basic configuration` for the project. Apply [hotspot=java file=1]`java` plugin and its [hotspot=options file=1]`options` to all sub-projects. The plugins and dependencies will be downloaded from the repositories that are specified in the [hotspot=repositories file=1]`repositories` configuration. Each child module inherits all the configurations.
 
 
 
diff --git a/finish/build.gradle b/finish/build.gradle
@@ -1,21 +1,31 @@
+// tag::allprojects[]
 allprojects  {
     group = 'io.openliberty.guides'
     version = '1.0-SNAPSHOT'
 }
+// end::allprojects[]
 
 subprojects {
+    // tag::java[]
     apply plugin: 'java'
+    // end::java[]
 
-    sourceCompatibility = JavaVersion.VERSION_11
-    targetCompatibility = JavaVersion.VERSION_11
+    // tag::options[]
+    java {
+        sourceCompatibility = JavaVersion.VERSION_11
+        targetCompatibility = JavaVersion.VERSION_11
+    }
 
     tasks.withType(JavaCompile).configureEach {
         options.encoding = 'UTF-8'
         options.release.set(11)
     }
+    // end::options[]
 
+    // tag::repositories[]
     repositories {
         mavenLocal()
         mavenCentral()
     }
+    // end::repositories[]
 }
diff --git a/finish/ear/build.gradle b/finish/ear/build.gradle
@@ -21,10 +21,6 @@ buildscript {
     }
 }
 
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
 
 dependencies {
     // tag::war[]
diff --git a/finish/jar/build.gradle b/finish/jar/build.gradle
@@ -6,11 +6,6 @@ tasks.withType(JavaCompile).configureEach {
     options.encoding = 'UTF-8'
 }
 
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
-
 dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
 }
diff --git a/start/build.gradle b/start/build.gradle
@@ -6,8 +6,10 @@ allprojects  {
 subprojects {
     apply plugin: 'java'
 
-    sourceCompatibility = JavaVersion.VERSION_11
-    targetCompatibility = JavaVersion.VERSION_11
+    java {
+        sourceCompatibility = JavaVersion.VERSION_11
+        targetCompatibility = JavaVersion.VERSION_11
+    }
 
     tasks.withType(JavaCompile).configureEach {
         options.encoding = 'UTF-8'
diff --git a/start/ear/build.gradle b/start/ear/build.gradle
@@ -14,11 +14,6 @@ buildscript {
     }
 }
 
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
-
 dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
 }
diff --git a/start/jar/build.gradle b/start/jar/build.gradle
@@ -5,12 +5,6 @@ description = 'JAR Module'
 tasks.withType(JavaCompile).configureEach {
     options.encoding = 'UTF-8'
 }
-
-repositories {
-    mavenLocal()
-    mavenCentral()
-}
-
 dependencies {
     testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'
 }
diff --git a/start/settings.gradle b/start/settings.gradle
@@ -1 +1 @@
-rootProject.name = 'guide-gradle-multimodules'
+rootProject.name = 'guide-gradle-multimodules'

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,6 @@ buildscript {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`-repositories {`
`25`		`- mavenLocal()`
`26`		`- mavenCentral()`
`27`		`-}`
`28`	`24`
`29`	`25`	`dependencies {`
`30`	`26`	`// tag::war[]`
Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,6 @@ tasks.withType(JavaCompile).configureEach {`
`6`	`6`	`options.encoding = 'UTF-8'`
`7`	`7`	`}`
`8`	`8`
`9`		`-repositories {`
`10`		`- mavenLocal()`
`11`		`- mavenCentral()`
`12`		`-}`
`13`		`-`
`14`	`9`	`dependencies {`
`15`	`10`	`testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'`
`16`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,11 +14,6 @@ buildscript {`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`
`17`		`-repositories {`
`18`		`- mavenLocal()`
`19`		`- mavenCentral()`
`20`		`-}`
`21`		`-`
`22`	`17`	`dependencies {`
`23`	`18`	`testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'`
`24`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,12 +5,6 @@ description = 'JAR Module'`
`5`	`5`	`tasks.withType(JavaCompile).configureEach {`
`6`	`6`	`options.encoding = 'UTF-8'`
`7`	`7`	`}`
`8`		`-`
`9`		`-repositories {`
`10`		`- mavenLocal()`
`11`		`- mavenCentral()`
`12`		`-}`
`13`		`-`
`14`	`8`	`dependencies {`
`15`	`9`	`testImplementation 'org.junit.jupiter:junit-jupiter:5.11.4'`
`16`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-rootProject.name = 'guide-gradle-multimodules'`
	`1`	`+rootProject.name = 'guide-gradle-multimodules'`