Skip to content

Commit 193c848

Browse files
dev-koangkwan-ibmdependabot[bot]
authored
Update to use maven wrapper (#320)
* Update to use maven wrapper Signed-off-by: Dev Agarwal <[email protected]> * updated README Signed-off-by: Dev Agarwal <[email protected]> * Update README.adoc * Bump org.junit.jupiter:junit-jupiter from 5.12.2 to 5.13.0 in /start Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.12.2 to 5.13.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.12.2...r5.13.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-version: 5.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.junit.jupiter:junit-jupiter from 5.12.2 to 5.13.0 in /finish Bumps [org.junit.jupiter:junit-jupiter](https://github.com/junit-team/junit5) from 5.12.2 to 5.13.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.12.2...r5.13.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter dependency-version: 5.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: Dev Agarwal <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Gilbert Kwan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 parent 2dfbb51 commit 193c848

File tree

15 files changed

+1152
-17
lines changed

15 files changed

+1152
-17
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ jobs:
2929
VALIDATE_JSCPD: false
3030
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3131
LINTER_RULES_PATH: ./tools/pr-checker/linters/
32+
FILTER_REGEX_EXCLUDE: mvnw*
3233
DEFAULT_BRANCH: prod
3334
- name: Summary
3435
if: "! github.event.pull_request.head.repo.fork"

README.adoc

Lines changed: 63 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2018, 2024 IBM Corporation and others.
1+
// Copyright (c) 2018, 2025 IBM Corporation and others.
22
// Licensed under Creative Commons Attribution-NoDerivatives
33
// 4.0 International (CC BY-ND 4.0)
44
// https://creativecommons.org/licenses/by-nd/4.0/
@@ -70,11 +70,34 @@ endif::[]
7070

7171
The two microservices you will deploy are called `system` and `inventory`. The `system` microservice returns the JVM system properties of the running container. The `inventory` microservice adds the properties from the `system` microservice to the inventory. This demonstrates how communication can be established between pods inside a cluster. To build these applications, navigate to the `start` directory and run the following command.
7272

73+
include::{common-includes}/os-tabs.adoc[]
74+
75+
[.tab_content.windows_section]
76+
--
7377
[role='command']
7478
```
7579
cd start
76-
mvn clean package
80+
mvnw.cmd clean package
7781
```
82+
--
83+
84+
[.tab_content.mac_section]
85+
--
86+
[role='command']
87+
```
88+
cd start
89+
./mvnw clean package
90+
```
91+
--
92+
93+
[.tab_content.linux_section]
94+
--
95+
[role='command']
96+
```
97+
cd start
98+
./mvnw clean package
99+
```
100+
--
78101

79102

80103

@@ -352,19 +375,40 @@ Using the [hotspot=valueFrom1 hotspot=valueFrom2 hotspot=valueFrom3 hotspot=valu
352375

353376
// Static guide instruction
354377
ifndef::cloud-hosted[]
355-
Rebuild the application using `mvn clean package`.
378+
Rebuild the application using Maven `clean` and `package` goals.
379+
include::{common-includes}/os-tabs.adoc[]
380+
381+
[.tab_content.windows_section]
382+
--
356383
[role='command']
357384
```
358-
mvn clean package
385+
mvnw.cmd clean package
359386
```
387+
--
388+
389+
[.tab_content.mac_section]
390+
--
391+
[role='command']
392+
```
393+
./mvnw clean package
394+
```
395+
--
396+
397+
[.tab_content.linux_section]
398+
--
399+
[role='command']
400+
```
401+
./mvnw clean package
402+
```
403+
--
360404
endif::[]
361405

362406
// Cloud hosted guide instruction
363407
ifdef::cloud-hosted[]
364-
Rebuild the application using ***mvn clean package***.
408+
Rebuild the application using Maven ***clean package***.
365409
```bash
366410
cd /home/project/guide-kubernetes-microprofile-config/start
367-
mvn clean package
411+
./mvnw clean package
368412
```
369413
endif::[]
370414

@@ -497,12 +541,21 @@ ifndef::cloud-hosted[]
497541

498542
include::{common-includes}/os-tabs.adoc[]
499543

500-
[.tab_content.windows_section.mac_section]
544+
[.tab_content.windows_section]
545+
--
546+
Run the integration tests:
547+
[role='command']
548+
```
549+
mvnw.cmd failsafe:integration-test -Dsystem.context.root=/dev
550+
```
551+
--
552+
553+
[.tab_content.mac_section]
501554
--
502555
Run the integration tests:
503556
[role='command']
504557
```
505-
mvn failsafe:integration-test -Dsystem.context.root=/dev
558+
./mvnw failsafe:integration-test -Dsystem.context.root=/dev
506559
```
507560
--
508561

@@ -511,7 +564,7 @@ mvn failsafe:integration-test -Dsystem.context.root=/dev
511564
Run the integration tests against a cluster running at Minikube's IP address:
512565
[role='command']
513566
```
514-
mvn failsafe:integration-test -Dsystem.context.root=/dev -Dsystem.service.root=$(minikube ip):31000 -Dinventory.service.root=$(minikube ip):32000
567+
./mvnw failsafe:integration-test -Dsystem.context.root=/dev -Dsystem.service.root=$(minikube ip):31000 -Dinventory.service.root=$(minikube ip):32000
515568

516569
```
517570
--
@@ -535,7 +588,7 @@ sed -i 's=localhost:31000='"localhost:$SYSTEM_NODEPORT"'=g' system/pom.xml
535588
Run the integration tests by using the following command:
536589

537590
```bash
538-
mvn failsafe:integration-test \
591+
./mvnw failsafe:integration-test \
539592
-Dsystem.service.root=localhost:$SYSTEM_NODEPORT \
540593
-Dsystem.context.root=/dev \
541594
-Dinventory.service.root=localhost:$INVENTORY_NODEPORT
61.6 KB
Binary file not shown.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.9/apache-maven-3.9.9-bin.zip
2+
wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.3.2/maven-wrapper-3.3.2.jar

finish/inventory/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<dependency>
4949
<groupId>org.junit.jupiter</groupId>
5050
<artifactId>junit-jupiter</artifactId>
51-
<version>5.12.2</version>
51+
<version>5.13.0</version>
5252
<scope>test</scope>
5353
</dependency>
5454
<dependency>

0 commit comments

Comments
 (0)