Skip to content

Commit 1c3356f

Browse files
authored
Merge pull request #67 from ericglau/master
Fix imports, use of static method
2 parents cd86150 + 9e5a882 commit 1c3356f

File tree

6 files changed

+21
-21
lines changed

6 files changed

+21
-21
lines changed

Diff for: finish/src/main/java/io/openliberty/guides/config/CustomConfigSource.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,18 @@
1414
// tag::customConfig[]
1515
package io.openliberty.guides.config;
1616

17-
import javax.json.stream.JsonParser;
18-
import javax.json.stream.JsonParser.Event;
19-
import javax.json.Json;
20-
import java.math.BigDecimal;
21-
import java.util.*;
22-
import java.io.StringReader;
2317
import java.io.BufferedReader;
2418
import java.io.FileReader;
19+
import java.io.StringReader;
20+
import java.math.BigDecimal;
21+
import java.util.HashMap;
22+
import java.util.Map;
23+
import java.util.Set;
24+
25+
import javax.json.Json;
26+
import javax.json.stream.JsonParser;
27+
import javax.json.stream.JsonParser.Event;
28+
2529
import org.eclipse.microprofile.config.spi.ConfigSource;
2630

2731
public class CustomConfigSource implements ConfigSource {

Diff for: finish/src/main/java/io/openliberty/guides/inventory/InventoryHealth.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import javax.ws.rs.client.ClientBuilder;
2020
import javax.ws.rs.core.MediaType;
2121
import javax.ws.rs.core.Response;
22-
import io.openliberty.guides.inventory.client.SystemClient;
2322
import org.eclipse.microprofile.health.Health;
2423
import org.eclipse.microprofile.health.HealthCheck;
2524
import org.eclipse.microprofile.health.HealthCheckResponse;
@@ -30,14 +29,12 @@ public class InventoryHealth implements HealthCheck {
3029
@Inject
3130
InventoryConfig config;
3231

33-
private InventoryUtils invUtils = new InventoryUtils();
34-
3532
public boolean isHealthy() {
3633
if (config.isInMaintenance()) {
3734
return false;
3835
}
3936
try {
40-
String url = invUtils.buildUrl("http", "localhost",
37+
String url = InventoryUtils.buildUrl("http", "localhost",
4138
Integer.parseInt(System.getProperty("default.http.port")),
4239
"/system/properties");
4340
Client client = ClientBuilder.newClient();

Diff for: finish/src/main/java/io/openliberty/guides/inventory/model/SystemData.java

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
// end::copyright[]
1313
package io.openliberty.guides.inventory.model;
1414

15-
import java.util.ArrayList;
16-
import java.util.List;
1715
import java.util.Properties;
1816

1917
public class SystemData {

Diff for: start/src/main/java/io/openliberty/guides/config/CustomConfigSource.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,18 @@
1414
// tag::customConfig[]
1515
package io.openliberty.guides.config;
1616

17-
import javax.json.stream.JsonParser;
18-
import javax.json.stream.JsonParser.Event;
19-
import javax.json.Json;
20-
import java.math.BigDecimal;
21-
import java.util.*;
22-
import java.io.StringReader;
2317
import java.io.BufferedReader;
2418
import java.io.FileReader;
19+
import java.io.StringReader;
20+
import java.math.BigDecimal;
21+
import java.util.HashMap;
22+
import java.util.Map;
23+
import java.util.Set;
24+
25+
import javax.json.Json;
26+
import javax.json.stream.JsonParser;
27+
import javax.json.stream.JsonParser.Event;
28+
2529
import org.eclipse.microprofile.config.spi.ConfigSource;
2630

2731
public class CustomConfigSource implements ConfigSource {

Diff for: start/src/main/java/io/openliberty/guides/inventory/model/SystemData.java

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
// end::copyright[]
1313
package io.openliberty.guides.inventory.model;
1414

15-
import java.util.ArrayList;
16-
import java.util.List;
1715
import java.util.Properties;
1816

1917
public class SystemData {

Diff for: start/src/test/java/it/io/openliberty/guides/health/HealthTestUtil.java

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.io.File;
1919
import java.io.FileReader;
2020
import java.io.FileWriter;
21-
import java.io.IOException;
2221
import javax.json.JsonArray;
2322
import javax.json.JsonObject;
2423
import javax.ws.rs.client.Client;

0 commit comments

Comments
 (0)