AbstractDiagnosticsCollector: Investigate and resolve issues with matching qualified names.

[mrglavas]

This class is within the io.openliberty.tools.intellij.lsp4jakarta.lsp4ij package.

See analysis and areas of concern on this issue: #879.

Added an Epic for full test coverage of collectors to ensure no diagnostics are shown for incorrect import or annotations

[dessina-devasia]

Usage of nameEndsWith() in conjunction with isImportedJavaElement() is investigated.

protected static boolean isMatchedAnnotation(PsiClass unit, PsiAnnotation annotation, String annotationFQName) {
String elementName = annotation.getQualifiedName();
if (nameEndsWith(annotationFQName, elementName) && unit != null) {
// For performance reason, we check if the import of annotation name is
// declared
if (isImportedJavaElement(unit, annotationFQName))
return true;
// only check fully qualified annotations
if (annotationFQName.equals(elementName)) {
PsiReference ref = annotation.getReference();
PsiElement def = ref.resolve();
if (def instanceof PsiAnnotation) {
String fqName = ((PsiAnnotation)def).getQualifiedName();
return fqName.equals(annotationFQName);
}
}
}
return false;
}

The above is the code snippet supporting the same. Both the conditions must keep aside.

• nameEndsWith provides a fast suffix check to filter out annotations with non-matching names early on.
• isImportedJavaElement checks if the annotation is already imported, allowing for an early return if it is.
• If the import isn’t available, a fully qualified name check with equals confirms that the annotation matches precisely.

By keeping nameEndsWith, we optimize for cases where there’s no match early on, ensuring only likely candidates undergo further checks. This structure provides a good balance between efficiency and readability.