Skip to content

Commit 468c3d0

Browse files
committed
Merge remote-tracking branch 'upstream/main' into issue282_projectDetection_integrationTest
2 parents f8a1b71 + d9c4b06 commit 468c3d0

7 files changed

Lines changed: 113 additions & 92 deletions

File tree

CHANGELOG.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,23 @@
22

33
All notable changes to the Liberty Tools extension will be documented below.
44

5+
## 23.0.9
6+
7+
Version 23.0.9 of Liberty Tools for Visual Studio Code is a fix release that contains minor enhancements and fixes. Version 23.0.9 requires Visual Studio Code version 1.78+ and requires Java 17 or later.
8+
9+
Notable changes:
10+
11+
- Updated Liberty Config Language Server version to 2.0.1. For information regarding changes for version 2.0.1, refer to the release notes linked below:
12+
- https://github.com/OpenLiberty/liberty-language-server/releases/tag/liberty-langserver-2.0.1
13+
- https://github.com/OpenLiberty/liberty-language-server/releases/tag/lemminx-liberty-2.0.1
14+
- Bug fix for “Start in container” action not appearing when project parent folder is opened in VS Code Explorer - https://github.com/OpenLiberty/liberty-tools-vscode/issues/258
15+
- Bug fix for the Liberty Dashboard not refreshing project names after they are changed - https://github.com/OpenLiberty/liberty-tools-vscode/issues/177
16+
- Bug fix for parameter field in “Start…” command redirecting focus to the terminal - https://github.com/OpenLiberty/liberty-tools-vscode/issues/210
17+
- Added the build file path as a tooltip when hovering over project names in the Liberty dashboard - https://github.com/OpenLiberty/liberty-tools-vscode/issues/208
18+
19+
See the [commit log](https://github.com/OpenLiberty/liberty-tools-vscode/compare/23.0.6...23.0.9) for the full set of changes since the previous release.
20+
21+
522
## 23.0.6
623

724
Version 23.0.6 of Liberty Tools for Visual Studio Code contains minor enhancements and fixes. Version 23.0.6 requires Visual Studio Code version 1.78+ and requires Java 17 or later.

gulpfile.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ const download = require("gulp-download2");
33
const cp = require("child_process");
44

55
const libertyGroupId = "io.openliberty.tools";
6-
const libertyVersion = "2.0";
6+
const libertyVersion = "2.1.1";
77
const jakartaGroupId = "org.eclipse.lsp4jakarta";
8-
const jakartaVersion = "0.1.1";
8+
const jakartaVersion = "0.2.0";
99
var releaseLevel = "releases"; //"snapshots"; //snapshots or releases
1010

1111
const libertyLemminxName = "liberty-langserver-lemminx-" + libertyVersion + "-jar-with-dependencies.jar";
@@ -86,8 +86,7 @@ const jakartaGroupIdString = "&g=" + jakartaGroupId;
8686
const jakartaVersionString = "&v=" + jakartaVersion;
8787
const jakartaClassifierString = "&c=jar-with-dependencies";
8888

89-
// const jakartaJDTURL = eclipseRepoURL + jakartaReleaseLevelString + jakartaGroupIdString + "&a=org.eclipse.lsp4jakarta.jdt.core" + jakartaVersionString;
90-
const jakartaJDTURL = "https://download.eclipse.org/lsp4jakarta/releases/0.1.1/repository/plugins/org.eclipse.lsp4jakarta.jdt.core_0.1.1.20230614-1652.jar";
89+
const jakartaJDTURL = eclipseRepoURL + jakartaReleaseLevelString + jakartaGroupIdString + "&a=org.eclipse.lsp4jakarta.jdt.core" + jakartaVersionString;
9190
const jakartaLSURL = eclipseRepoURL + jakartaReleaseLevelString + jakartaGroupIdString + "&a=org.eclipse.lsp4jakarta.ls" + jakartaClassifierString + jakartaVersionString;
9291

9392
gulp.task("downloadLSP4JakartaJars", (done) => {

package-lock.json

Lines changed: 38 additions & 38 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "liberty-dev-vscode-ext",
33
"displayName": "Liberty Tools",
44
"description": "Liberty Tools for Visual Studio Code",
5-
"version": "23.0.7-SNAPSHOT",
5+
"version": "23.0.12-SNAPSHOT",
66
"publisher": "Open-Liberty",
77
"repository": {
88
"type": "git",
@@ -50,10 +50,10 @@
5050
],
5151
"contributes": {
5252
"javaExtensions": [
53-
"./jars/org.eclipse.lsp4jakarta.jdt.core-0.1.1.jar"
53+
"./jars/org.eclipse.lsp4jakarta.jdt.core-0.2.0.jar"
5454
],
5555
"xml.javaExtensions": [
56-
"./jars/liberty-langserver-lemminx-2.0-jar-with-dependencies.jar"
56+
"./jars/liberty-langserver-lemminx-2.1.1-jar-with-dependencies.jar"
5757
],
5858
"views": {
5959
"explorer": [

src/definitions/lsp4jakartaLSRequestNames.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
*/
1010

1111
// Jakarta Language API
12+
export const FILEINFO_REQUEST = "jakarta/java/fileInfo"
1213
export const JAVA_HOVER_REQUEST = "jakarta/java/hover";
1314
export const JAVA_DIAGNOSTICS_REQUEST = "jakarta/java/diagnostics";
14-
export const JAVA_CLASSPATH_REQUEST = "jakarta/java/classpath";
15-
export const JAVA_CODEACTION_REQUEST = "jakarta/java/codeaction";
16-
export const JAVA_CURSORCONTEXT_REQUEST = "jakarta/java/cursorcontext";
15+
export const JAVA_COMPLETION_REQUEST = "jakarta/java/completion";
16+
export const JAVA_CODEACTION_REQUEST = "jakarta/java/codeAction";
17+
export const JAVA_CODEACTION_RESOLVE_REQUEST = "jakarta/java/codeActionResolve";
18+
export const JAVA_PROJECT_LABELS_REQUEST = "jakarta/java/projectLabels";

src/extension.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ import { prepareExecutable } from "./util/javaServerStarter";
2222

2323
const LIBERTY_CLIENT_ID = "LANGUAGE_ID_LIBERTY";
2424
const JAKARTA_CLIENT_ID = "LANGUAGE_ID_JAKARTA";
25-
export const LIBERTY_LS_JAR = "liberty-langserver-2.0-jar-with-dependencies.jar";
26-
export const JAKARTA_LS_JAR = "org.eclipse.lsp4jakarta.ls-0.1.1-jar-with-dependencies.jar";
25+
export const LIBERTY_LS_JAR = "liberty-langserver-2.1.1-jar-with-dependencies.jar";
26+
export const JAKARTA_LS_JAR = "org.eclipse.lsp4jakarta.ls-0.2.0-jar-with-dependencies.jar";
2727

2828
let libertyClient: LanguageClient;
2929
let jakartaClient: LanguageClient;
@@ -76,10 +76,12 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
7676
console.log("LSP4Jakarta is ready, binding requests...");
7777

7878
// Delegate requests from Jakarta LS to the Jakarta JDT core
79-
bindRequest(lsp4jakartaLS.JAVA_CLASSPATH_REQUEST);
79+
bindRequest(lsp4jakartaLS.FILEINFO_REQUEST);
80+
bindRequest(lsp4jakartaLS.JAVA_COMPLETION_REQUEST);
8081
bindRequest(lsp4jakartaLS.JAVA_CODEACTION_REQUEST);
82+
bindRequest(lsp4jakartaLS.JAVA_CODEACTION_RESOLVE_REQUEST);
8183
bindRequest(lsp4jakartaLS.JAVA_DIAGNOSTICS_REQUEST);
82-
bindRequest(lsp4jakartaLS.JAVA_CURSORCONTEXT_REQUEST);
84+
bindRequest(lsp4jakartaLS.JAVA_PROJECT_LABELS_REQUEST);
8385

8486
item.text = localize("jakarta.ls.thumbs.up");
8587
item.tooltip = localize("jakarta.ls.started");
@@ -211,14 +213,15 @@ function startLangServer(context: ExtensionContext, requirements: RequirementsDa
211213
function prepareClientOptions(Liberty_LS :boolean) {
212214
if (Liberty_LS) {
213215
return {
214-
// Filter to `bootstrap.properties` and `server.env` files within `src/main/liberty/config` or `usr/servers`
216+
// Filter to `*.properties` and `*.env` files, let LCLS handle filtering for default/custom configs
215217
documentSelector: [{ scheme: "file",
216-
pattern: "**/{src/main/liberty/config,usr/servers/**}/{bootstrap.properties,server.env}" }],
218+
pattern: "**/{*.properties,*.env}" }],
217219
synchronize: {
218220
configurationSection: SUPPORTED_LANGUAGE_IDS,
219221
fileEvents: [
220-
workspace.createFileSystemWatcher("**/bootstrap.properties"),
221-
workspace.createFileSystemWatcher("**/server.env")
222+
workspace.createFileSystemWatcher("**/*.properties"),
223+
workspace.createFileSystemWatcher("**/*.env"),
224+
workspace.createFileSystemWatcher("**/liberty-plugin-config.xml")
222225
],
223226
}
224227
};

0 commit comments

Comments
 (0)