Clarify which subproject when necessary for attach debugger and view test report

Author: mattbsox

src/liberty/devCommands.ts

@@ -573,29 +573,38 @@ export async function runTests(libProject?: LibertyProject | undefined): Promise
 // open surefire, failsafe, or gradle test report
 export async function openReport(reportType: string, libProject?: LibertyProject | undefined): Promise<void> {
     if (libProject !== undefined) {
-        const path = Path.dirname(libProject.getPath());
+        // Resolve the target project (handles aggregators with multiple Liberty children)
+        const projectProvider: ProjectProvider = ProjectProvider.getInstance();
+        const targetProject = await projectProvider.resolveCommandTarget(libProject, localize("command.view.test.report"));
+        
+        if (targetProject === undefined) {
+            // User cancelled or no valid target found
+            return;
+        }
+        
+        const path = Path.dirname(targetProject.getPath());
         if (path !== undefined) {
             let report: any;
             let reportTypeLabel = reportType;
             if (reportType === "gradle") {
                 reportTypeLabel = "test";
             }
             let showErrorMessage: boolean = true;
-            if (libProject.getContextValue() === LIBERTY_MAVEN_PROJECT || libProject.getContextValue() === LIBERTY_MAVEN_PROJECT_CONTAINER) {
+            if (targetProject.getContextValue() === LIBERTY_MAVEN_PROJECT || targetProject.getContextValue() === LIBERTY_MAVEN_PROJECT_CONTAINER) {
                 report = getReportFile(path, "reports", reportType + ".html");
                 // show the error message only if both "reports" and "site" dirs do not contain the test reports
                 // set to false since this will be the first location checked
-                showErrorMessage = false; 
-                if (!await checkReportAndDisplay(report, reportType, reportTypeLabel, libProject, showErrorMessage)) {
+                showErrorMessage = false;
+                if (!await checkReportAndDisplay(report, reportType, reportTypeLabel, targetProject, showErrorMessage)) {
                     report = getReportFile(path, "site", reportType + "-report.html");
                     // show the error message only if both "reports" and "site" dirs do not contain the test reports
                     // set to true since this will be the second location checked
-                    showErrorMessage = true; 
-                    await checkReportAndDisplay(report, reportType, reportTypeLabel, libProject, showErrorMessage);
+                    showErrorMessage = true;
+                    await checkReportAndDisplay(report, reportType, reportTypeLabel, targetProject, showErrorMessage);
                 }
-            } else if (libProject.getContextValue() === LIBERTY_GRADLE_PROJECT || libProject.getContextValue() === LIBERTY_GRADLE_PROJECT_CONTAINER) {
-                report = await getGradleTestReport(libProject.path, path);
-                await checkReportAndDisplay(report, reportType, reportTypeLabel, libProject, showErrorMessage);
+            } else if (targetProject.getContextValue() === LIBERTY_GRADLE_PROJECT || targetProject.getContextValue() === LIBERTY_GRADLE_PROJECT_CONTAINER) {
+                report = await getGradleTestReport(targetProject.path, path);
+                await checkReportAndDisplay(report, reportType, reportTypeLabel, targetProject, showErrorMessage);
             }
         }
     } else if (ProjectProvider.getInstance() && reportType) {

src/locales/en.json

@@ -81,5 +81,6 @@
     "command.start.custom.dev.mode": "start custom dev mode",
     "command.stop.dev.mode": "stop dev mode",
     "command.run.tests": "run tests",
-    "command.attach.debugger": "attach debugger"
+    "command.attach.debugger": "attach debugger",
+    "command.view.test.report": "view test report"
 }