stale references

Author: Siddharth Saladi

src/test/utils/testUtils.ts

@@ -524,35 +524,31 @@ export async function clearCommandPalette() {
 export async function waitForDashboardToLoad(section: any): Promise<void> {
     const wait = getWaitHelper();
     logger.info('Waiting for Liberty Dashboard to load');
-    
-    // Expand the section
-    await waitForSuccess(async () => {
-        await section.expand();
-    });
-    
-    // Wait for section container to become stable after expansion
-    await wait.sleep(2000);
-    
-    // Wait for items to appear with retry on ElementNotInteractableError
+
+    // Re-fetch the section on every iteration — same stale-reference fix as
+    // getDashboardItem.  The captured section reference goes stale on mac Previous
+    // during workspace activation and getVisibleItems() throws forever.
     await wait.forCondition(async () => {
         try {
-            const items = await section.getVisibleItems();
+            const freshSection = await getDashboardSection(new SideBarView());
+            await freshSection.expand();
+            const items = await freshSection.getVisibleItems();
             if (items && items.length > 0) {
                 logger.info(`Dashboard loaded with ${items.length} items`);
                 return true;
             }
         } catch (error: any) {
-            // Retry on ElementNotInteractableError
-            if (error.name === 'ElementNotInteractableError') {
+            if (error.name === 'ElementNotInteractableError' ||
+                error.name === 'StaleElementReferenceError') {
                 logger.info('Container not yet interactable, retrying...');
                 return;
             }
             throw error;
         }
         return;
     }, {
-        timeout: 120000, // 2 minutes max
-        pollInterval: 5000, // check every 5 seconds
+        timeout: 120000,
+        pollInterval: 5000,
         message: 'Dashboard items did not load'
     });
 }