Skip to content

Commit 0950189

Browse files
authored
Merge pull request #7901 from tevans78/revertPR7524-from-19.0.0.6
Revert "Fix inject trace"
2 parents a710257 + 8ebb586 commit 0950189

File tree

70 files changed

+333
-659
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+333
-659
lines changed

dev/com.ibm.ws.app.manager.war/src/com/ibm/ws/app/manager/ear/internal/EARDeployedAppInfoFactoryImpl.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,7 @@
4848
@Component(service = DeployedAppInfoFactory.class,
4949
property = { "service.vendor=IBM", "type:String=ear" })
5050
public class EARDeployedAppInfoFactoryImpl extends AbstractDeployedAppInfoFactory implements DeployedAppInfoFactory {
51-
private static final TraceComponent _tc = Tr.register(EARDeployedAppInfoFactoryImpl.class, new String[] { "webcontainer", "applications", "app.manager" },
52-
"com.ibm.ws.app.manager.war.internal.resources.Messages",
53-
"com.ibm.ws.app.manager.ear.internal.EARDeployedAppInfoFactoryImpl");
51+
private static final TraceComponent _tc = Tr.register(EARDeployedAppInfoFactoryImpl.class);
5452

5553
@Reference
5654
protected DeployedAppServices deployedAppServices;
@@ -178,7 +176,7 @@ protected WsResource resolveExpansion(String appName) {
178176
* time stamp.
179177
*
180178
* @param absPath The absolute path of the file which is to be tested.
181-
* @param file The file which is to be tested.
179+
* @param file The file which is to be tested.
182180
*
183181
* @return The new time stamp of the file, if the file is to be expanded.
184182
* Null if the file is not to be expanded.
@@ -274,11 +272,11 @@ protected void expand(
274272
* expand the application to the expanded applications location.
275273
*
276274
* @param appInfo Information for the application for which to create
277-
* deployment information.
275+
* deployment information.
278276
* @return Deployment information for the application.
279277
*
280278
* @throws UnableToAdaptException Thrown if the deployment information
281-
* count not be created.
279+
* count not be created.
282280
*/
283281
@Override
284282
public DeployedAppInfo createDeployedAppInfo(ApplicationInformation<DeployedAppInfo> appInfo) throws UnableToAdaptException {

dev/com.ibm.ws.app.manager/src/com/ibm/ws/app/manager/internal/monitor/ApplicationMonitor.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -334,9 +334,9 @@ private static abstract class BaseApplicationListener implements com.ibm.ws.adap
334334
/**
335335
* Constructs a new instance of this listener and creates the notifier to which we'll be registered. It does not actually start the listener though.
336336
*
337-
* @param applicationProperties The properties for the application being monitored
337+
* @param applicationProperties The properties for the application being monitored
338338
* @param monitoringContainerInformation Information about which containers notification mechanism we should be using and which entries and containers within it we should
339-
* be listening to
339+
* be listening to
340340
* @throws UnableToAdaptException If we cannot adapt the root container to a {@link Notifier}
341341
*/
342342
public BaseApplicationListener(Notification monitoringInformation,
@@ -372,7 +372,6 @@ private synchronized void stop() {
372372
*
373373
* @return This listener's ID.
374374
*/
375-
@Override
376375
public String getId() {
377376
return id;
378377
}
@@ -390,9 +389,9 @@ private static final class RootApplicationListener extends BaseApplicationListen
390389
/**
391390
* Constructs a new instance of this listener and creates the notifier to which we'll be registered. It does not actually start the listener though.
392391
*
393-
* @param applicationProperties The properties for the application being monitored
392+
* @param applicationProperties The properties for the application being monitored
394393
* @param monitoringContainerInformation Information about which containers notification mechanism we should be using and which entries and containers within it we should
395-
* be listening to
394+
* be listening to
396395
* @throws UnableToAdaptException If we cannot adapt the root container to a {@link Notifier}
397396
*/
398397
public RootApplicationListener(Container container,
@@ -445,9 +444,9 @@ private static final class ApplicationListener extends BaseApplicationListener {
445444
/**
446445
* Constructs a new instance of this listener and creates the notifier to which we'll be registered. It does not actually start the listener though.
447446
*
448-
* @param applicationProperties The properties for the application being monitored
447+
* @param applicationProperties The properties for the application being monitored
449448
* @param monitoringContainerInformation Information about which containers notification mechanism we should be using and which entries and containers within it we should
450-
* be listening to
449+
* be listening to
451450
* @throws UnableToAdaptException If we cannot adapt the root container to a {@link Notifier} of if we cannot adapt the app's container to a ClassLoadingButler
452451
*/
453452
public ApplicationListener(Notification monitoringInformation,
@@ -521,9 +520,9 @@ private static final class CompleteApplicationListener extends BaseApplicationLi
521520
/**
522521
* Constructs a new instance of this listener and creates the notifier to which we'll be registered. It does not actually start the listener though.
523522
*
524-
* @param applicationProperties The properties for the application being monitored
523+
* @param applicationProperties The properties for the application being monitored
525524
* @param monitoringContainerInformation Information about which containers notification mechanism we should be using and which entries and containers within it we should
526-
* be listening to
525+
* be listening to
527526
* @throws UnableToAdaptException If we cannot adapt the root container to a {@link Notifier}
528527
*/
529528
public CompleteApplicationListener(Container container,

dev/com.ibm.ws.app.manager/src/com/ibm/ws/app/manager/internal/monitor/DropinMonitor.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@
5454
configurationPolicy = ConfigurationPolicy.IGNORE,
5555
property = "service.vendor=IBM")
5656
public class DropinMonitor {
57-
private static final TraceComponent _tc = Tr.register(DropinMonitor.class, new String[] { "applications", com.ibm.ws.app.manager.internal.AppManagerConstants.TRACE_GROUP },
58-
com.ibm.ws.app.manager.internal.AppManagerConstants.TRACE_MESSAGES,
59-
"com.ibm.ws.app.manager.internal.monitor.DropinMonitor");
57+
private static final TraceComponent _tc = Tr.register(DropinMonitor.class);
6058

6159
private BundleContext _ctx;
6260
private WsLocationAdmin locationService;
@@ -349,7 +347,7 @@ private String getAppLocation(File currentFile) {
349347
/**
350348
* Returns the message helper for the specified application handler type.
351349
*
352-
* @param type application handler type
350+
* @param type application handler type
353351
* @param fileName file name from which type can be inferred if not specified
354352
* @return the message helper for the specified application handler type.
355353
*/
@@ -386,9 +384,9 @@ private AppMessageHelper getAppMessageHelper(String type, String fileName) {
386384
* Takes a file and an optional file type, and updates the file. If no type is given it will use the
387385
* extension of the file given.
388386
*
389-
* @param ca the configuration admin service.
387+
* @param ca the configuration admin service.
390388
* @param currentFile the file of the application to install. Can be a directory
391-
* @param type the type of the application.
389+
* @param type the type of the application.
392390
*
393391
*/
394392
private void startApplication(File currentFile, String type) {

dev/com.ibm.ws.beanvalidation.core/src/com/ibm/ws/beanvalidation/service/Validation20ClassLoader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* It should return the correct validation.xml for the module currently under execution.
3232
*/
3333
public class Validation20ClassLoader extends ClassLoader {
34-
private static final TraceComponent tc = Tr.register(Validation20ClassLoader.class, null, null);
34+
private static final TraceComponent tc = Tr.register(Validation20ClassLoader.class);
3535
String moduleHint;
3636

3737
public Validation20ClassLoader(ClassLoader parent, String hint) {

dev/com.ibm.ws.classloading/src/com/ibm/ws/classloading/internal/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
@Trivial
3131
final class Util {
32-
static final TraceComponent tc = Tr.register(Util.class,"ClassLoadingService","com.ibm.ws.classloading.internal.resources.ClassLoadingServiceMessages");
32+
static final TraceComponent tc = Tr.register(Util.class);
3333

3434
private Util() {
3535
throw null;

dev/com.ibm.ws.classloading/src/com/ibm/ws/library/internal/Util.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import java.util.zip.ZipFile;
2727

2828
public enum Util {;
29-
private static final TraceComponent tc = Tr.register(Util.class,SharedLibraryConstants.TR_GROUP, SharedLibraryConstants.NLS_PROPS);
29+
private static final TraceComponent tc = Tr.register(Util.class);
3030

3131
@FFDCIgnore(PrivilegedActionException.class)
3232
static boolean isArchive(final File f) {

dev/com.ibm.ws.classloading/src/com/ibm/wsspi/classloading/ApiType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public enum ApiType {
3939

4040
// OSGi APIs are marked spec:api, which is obviously not in this enum.
4141
// This means that OSGi application API will not be visible to EE applications.
42-
private static final TraceComponent tc = Tr.register(ApiType.class,"ClassLoadingService", "com.ibm.ws.classloading.internal.resources.ClassLoadingServiceMessages");
42+
private static final TraceComponent tc = Tr.register(ApiType.class);
4343

4444
private final String attributeName;
4545

dev/com.ibm.ws.httpservice/src/com/ibm/ws/httpsvc/internal/HttpServiceContainer.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
* bundle.
3939
*/
4040
public class HttpServiceContainer implements HttpContainer {
41-
private static final TraceComponent tc = Tr.register(HttpServiceContainer.class, com.ibm.ws.httpsvc.internal.HttpSvcConstants.TRACE_GROUP, null);
41+
private static final TraceComponent tc = Tr.register(HttpServiceContainer.class);
4242

4343
private static final class SingletonSessionManager {
4444
static final SessionManager instance = new SessionManager();
@@ -61,7 +61,7 @@ public HttpServiceContainer() {
6161

6262
/**
6363
* Activate this DS component.
64-
*
64+
*
6565
* @param context
6666
* @throws Exception
6767
*/
@@ -77,7 +77,7 @@ protected void activate(ComponentContext context) throws Exception {
7777

7878
/**
7979
* Deactivate this DS component.
80-
*
80+
*
8181
* @param context
8282
* @throws Exception
8383
*/
@@ -137,7 +137,7 @@ public synchronized void removeContextRoot(String contextRoot) {
137137
/**
138138
* DS method for runtime updates to configuration without stopping and
139139
* restarting the component.
140-
*
140+
*
141141
* @param properties
142142
*/
143143
protected void modified(Map<?, ?> properties) {
@@ -151,7 +151,7 @@ protected void modified(Map<?, ?> properties) {
151151

152152
/**
153153
* Process configuration information.
154-
*
154+
*
155155
* @param properties
156156
*/
157157
protected synchronized void processConfig(Dictionary<?, ?> properties) {

dev/com.ibm.ws.httpservice/src/com/ibm/ws/httpsvc/internal/RegisteredHttpServiceImpl.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
*
4646
*/
4747
public class RegisteredHttpServiceImpl implements ExtHttpService {
48-
private static final TraceComponent tc = Tr.register(RegisteredHttpServiceImpl.class, com.ibm.ws.httpsvc.internal.HttpSvcConstants.TRACE_GROUP, null);
48+
private static final TraceComponent tc = Tr.register(RegisteredHttpServiceImpl.class);
4949

5050
/** DS-managed reference to the HTTP Container */
5151
private HttpServiceContainer container;
@@ -67,12 +67,14 @@ protected void unsetHttpContainer(HttpServiceContainer ref) {}
6767
private Set<Filter> localFilters;
6868
private ServletContextManager contextManager;
6969

70-
private final Object servletLock = new Object() {};
71-
private final Object filterLock = new Object() {};
70+
private final Object servletLock = new Object()
71+
{};
72+
private final Object filterLock = new Object()
73+
{};
7274

7375
/**
7476
* Activate this component.
75-
*
77+
*
7678
* @param ctxt
7779
*/
7880
protected void activate(ComponentContext ctxt) {
@@ -90,7 +92,7 @@ protected void activate(ComponentContext ctxt) {
9092

9193
/**
9294
* Deactivate this component.
93-
*
95+
*
9496
* @param ctxt
9597
*/
9698
protected void deactivate(ComponentContext ctxt, int reason) {

0 commit comments

Comments
 (0)