Skip to content

Commit 528c6b6

Browse files
jimblyejimblye
committed
Fix compile errors by making TraceComponent static
1 parent a54abfd commit 528c6b6

File tree

12 files changed

+79
-73
lines changed

12 files changed

+79
-73
lines changed

‎dev/com.ibm.ws.microprofile.graphql.authorization/src/com/ibm/ws/microprofile/graphql/authorization/component/GraphQLAuthorizationExtension.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"bean.defining.annotations=org.eclipse.microprofile.graphql.GraphQLApi",
3636
"service.vendor=IBM" })
3737
public class GraphQLAuthorizationExtension implements Extension, WebSphereCDIExtension {
38-
TraceComponent tc = Tr.register(GraphQLAuthorizationExtension.class);
38+
private static final TraceComponent tc = Tr.register(GraphQLAuthorizationExtension.class);
3939

4040
@Trivial
4141
public void beforeBeanDiscovery(@Observes BeforeBeanDiscovery beforeBeanDiscovery, BeanManager beanManager) {

‎dev/com.ibm.ws.persistence/src/com/ibm/wsspi/persistence/internal/eclipselink/LogChannel.java‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
*******************************************************************************/
1313
package com.ibm.wsspi.persistence.internal.eclipselink;
1414

15+
import java.util.concurrent.ConcurrentHashMap;
16+
1517
import org.eclipse.persistence.logging.SessionLogEntry;
1618

1719
import com.ibm.websphere.ras.Tr;
@@ -22,8 +24,12 @@
2224
//TODO(151905) -- Cleanup. Poached from Liberty
2325
@Trivial
2426
class LogChannel {
25-
private final TraceComponent _tc;
27+
// Static map to hold TraceComponents per channel name
28+
private static final ConcurrentHashMap<String, TraceComponent> _traceComponents = new ConcurrentHashMap<>();
2629
private static final TraceComponent _stc = Tr.register(LogChannel.class);
30+
31+
// The TraceComponent for this specific channel instance
32+
private final TraceComponent _tc;
2733

2834
/**
2935
* Log levels (per EclipseLink)
@@ -38,11 +44,13 @@ class LogChannel {
3844
* <li>1=FINEST
3945
* <li>0=TRACE
4046
* </ul>
41-
*
47+
*
4248
* @param channel
4349
*/
4450
LogChannel(String channel) {
45-
_tc = Tr.register(channel, LogChannel.class, PersistenceServiceConstants.TRACE_GROUP);
51+
// Get or create TraceComponent for this channel from static map
52+
_tc = _traceComponents.computeIfAbsent(channel,
53+
ch -> Tr.register(ch, LogChannel.class, PersistenceServiceConstants.TRACE_GROUP));
4654
}
4755

4856
boolean shouldLog(int level) {

‎dev/com.ibm.ws.security.oauth/src/com/ibm/ws/security/oauth20/error/impl/BrowserAndServerLogMessage.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,12 @@
2525
* other line is updated at some point.
2626
*/
2727
public class BrowserAndServerLogMessage {
28+
private static final TraceComponent tc = Tr.register(BrowserAndServerLogMessage.class);
2829
private Enumeration<Locale> requestLocales = null;
29-
private final TraceComponent tc;
3030
private final String msgKey;
3131
private final Object[] inserts;
3232

33-
public BrowserAndServerLogMessage(TraceComponent tc, String msgKey, Object... inserts) {
34-
this.tc = tc;
33+
public BrowserAndServerLogMessage(String msgKey, Object... inserts) {
3534
this.msgKey = msgKey;
3635
this.inserts = inserts;
3736
}

‎dev/com.ibm.ws.security.oauth/src/com/ibm/ws/security/oauth20/plugins/OidcBaseClientValidator.java‎

Lines changed: 26 additions & 26 deletions
Large diffs are not rendered by default.

‎dev/com.ibm.ws.security.oauth/src/com/ibm/ws/security/oauth20/plugins/custom/OauthClientStore.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ void logMessageAndThrowOidcServerException(OAuthStoreException e, String msgKey,
323323

324324
// Use an empty string as the last insert to avoid an unused insert (e.g. "{2}") showing up in the exception message
325325
updatedMsgArgs = appendStringMessageToArgs("", msgArgs);
326-
throw new OidcServerException(new BrowserAndServerLogMessage(tc, msgKey, updatedMsgArgs), OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e);
326+
throw new OidcServerException(new BrowserAndServerLogMessage(msgKey, updatedMsgArgs), OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e);
327327

328328
}
329329

‎dev/com.ibm.ws.security.oauth/src/com/ibm/ws/security/oauth20/plugins/db/CachedDBOidcClientProvider.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ void logMessageAndThrowOidcServerException(String methodName, SQLException e, St
910910

911911
// Use an empty string as the last insert to avoid an unused insert (e.g. "{2}") showing up in the exception message
912912
updatedMsgArgs = appendStringMessageToArgs("", msgArgs);
913-
throw new OidcServerException(new BrowserAndServerLogMessage(tc, msgKey, updatedMsgArgs), OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e);
913+
throw new OidcServerException(new BrowserAndServerLogMessage(msgKey, updatedMsgArgs), OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e);
914914
}
915915

916916
/**
@@ -927,7 +927,7 @@ void logMessageAndThrowOidcServerException(String methodName, IllegalArgumentExc
927927

928928
// Use an empty string as the last insert to avoid an unused insert (e.g. "{2}") showing up in the exception message
929929
updatedMsgArgs = appendStringMessageToArgs("", msgArgs);
930-
throw new OidcServerException(new BrowserAndServerLogMessage(tc, msgKey, updatedMsgArgs), OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e);
930+
throw new OidcServerException(new BrowserAndServerLogMessage(msgKey, updatedMsgArgs), OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e);
931931
}
932932

933933
Object[] appendStringMessageToArgs(String additionalInsert, Object... msgArgs) {

‎dev/com.ibm.ws.security.oauth/src/com/ibm/ws/security/oauth20/web/CoverageMapEndpointServices.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ protected void handleEndpointRequest(OAuth20Provider provider, HttpServletReques
5454
if (request.getMethod().equalsIgnoreCase(HTTP_METHOD_GET) || request.getMethod().equalsIgnoreCase(HTTP_METHOD_HEAD)) {
5555
processHeadOrGet(provider, request, response);
5656
} else {
57-
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage(tc, "OAUTH_UNSUPPORTED_METHOD", new Object[] { request.getMethod(), this.getClass().getSimpleName() });
57+
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage("OAUTH_UNSUPPORTED_METHOD", new Object[] { request.getMethod(), this.getClass().getSimpleName() });
5858
Tr.error(tc, updateMsg.getServerErrorMessage());
5959
throw new OidcServerException(updateMsg, OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_METHOD_NOT_ALLOWED);
6060
}
@@ -146,20 +146,20 @@ private String validateTokenType(HttpServletRequest request, HttpServletResponse
146146
throws IOException, OidcServerException {
147147
String queryString = request.getQueryString();
148148
if (queryString == null) {
149-
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage(tc, "OAUTH_COVERAGE_MAP_MISSING_PARAMS", new Object[] { OAuth20Constants.TOKEN_TYPE });
149+
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage("OAUTH_COVERAGE_MAP_MISSING_PARAMS", new Object[] { OAuth20Constants.TOKEN_TYPE });
150150
Tr.error(tc, updateMsg.getServerErrorMessage());
151151
throw new OidcServerException(updateMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
152152
}
153153

154154
Map<String, String[]> queryParms = parseQueryParameters(queryString);
155155
String[] tokenTypes = queryParms.get(OAuth20Constants.TOKEN_TYPE);
156156
if (tokenTypes == null) {
157-
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage(tc, "OAUTH_COVERAGE_MAP_MISSING_TOKEN_PARAM", new Object[] { OAuth20Constants.TOKEN_TYPE });
157+
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage("OAUTH_COVERAGE_MAP_MISSING_TOKEN_PARAM", new Object[] { OAuth20Constants.TOKEN_TYPE });
158158
Tr.error(tc, updateMsg.getServerErrorMessage());
159159
throw new OidcServerException(updateMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
160160
}
161161
if (tokenTypes.length > 1) {
162-
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage(tc, "OAUTH_COVERAGE_MAP_MULTIPLE_TOKEN_PARAM", new Object[] { OAuth20Constants.TOKEN_TYPE });
162+
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage("OAUTH_COVERAGE_MAP_MULTIPLE_TOKEN_PARAM", new Object[] { OAuth20Constants.TOKEN_TYPE });
163163
Tr.error(tc, updateMsg.getServerErrorMessage());
164164
throw new OidcServerException(updateMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
165165

@@ -169,7 +169,7 @@ private String validateTokenType(HttpServletRequest request, HttpServletResponse
169169
if (tokenType.equalsIgnoreCase(OAuth20Constants.SUBTYPE_BEARER)) {
170170
return tokenType.toLowerCase();
171171
}
172-
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage(tc, "OAUTH_COVERAGE_MAP_UNRECOGNIZED_TOKEN_PARAM", new Object[] { tokenType });
172+
BrowserAndServerLogMessage updateMsg = new BrowserAndServerLogMessage("OAUTH_COVERAGE_MAP_UNRECOGNIZED_TOKEN_PARAM", new Object[] { tokenType });
173173
Tr.error(tc, updateMsg.getServerErrorMessage());
174174
throw new OidcServerException(updateMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
175175
}

‎dev/com.ibm.ws.security.oauth/src/com/ibm/ws/security/oauth20/web/RegistrationEndpointServices.java‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ protected void handleEndpointRequest(OAuth20Provider provider, HttpServletReques
112112
} else if (request.getMethod().equalsIgnoreCase(HTTP_METHOD_DELETE)) {
113113
processDelete(provider, request, response);
114114
} else {
115-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_UNSUPPORTED_METHOD", new Object[] { request.getMethod(), "Registration Endpoint Service" });
115+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_UNSUPPORTED_METHOD", new Object[] { request.getMethod(), "Registration Endpoint Service" });
116116
Tr.error(tc, errorMsg.getServerErrorMessage());
117117
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_SERVER_ERROR, HttpServletResponse.SC_METHOD_NOT_ALLOWED);
118118
}
@@ -140,7 +140,7 @@ private void processHeadOrGetSingleClient(String clientId, OidcOAuth20ClientProv
140140
OidcBaseClient client = clientProvider.get(clientId);
141141
if (client == null) {
142142
// CWWKS1424E
143-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_CLIENTID_NOT_FOUND", new Object[] { clientId });
143+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_CLIENTID_NOT_FOUND", new Object[] { clientId });
144144
Tr.event(tc, errorMsg.getServerErrorMessage());
145145
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT, HttpServletResponse.SC_NOT_FOUND);
146146

@@ -232,7 +232,7 @@ private void processPost(OAuth20Provider provider, HttpServletRequest request, H
232232
// POST is only allowed at the direct servlet path /registration
233233
String clientId = extractClientId(request.getPathInfo());
234234
if (!OidcOAuth20Util.isNullEmpty(clientId)) {
235-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_INVALID_REQUEST_PATH");
235+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_INVALID_REQUEST_PATH");
236236
Tr.error(tc, errorMsg.getServerErrorMessage());
237237
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
238238
}
@@ -241,7 +241,7 @@ private void processPost(OAuth20Provider provider, HttpServletRequest request, H
241241
OidcBaseClient newClient = getOidcBaseClientFromRequestBody(request);
242242

243243
if (newClient == null) {
244-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_REGISTRATION_REQUEST_MISSING_CLIENT");
244+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_REGISTRATION_REQUEST_MISSING_CLIENT");
245245
Tr.error(tc, errorMsg.getServerErrorMessage());
246246
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
247247
}
@@ -388,7 +388,7 @@ private void processDelete(OAuth20Provider provider, HttpServletRequest request,
388388
// If no clientId is specified at end of /registration/* return error 400 response
389389
String clientId = extractClientId(request.getPathInfo());
390390
if (OidcOAuth20Util.isNullEmpty(clientId)) {
391-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_MISSING_CLIENTID", new Object[] { request.getMethod(), OAuth20Constants.CLIENT_ID });
391+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_MISSING_CLIENTID", new Object[] { request.getMethod(), OAuth20Constants.CLIENT_ID });
392392
Tr.error(tc, errorMsg.getServerErrorMessage());
393393
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
394394
}
@@ -399,7 +399,7 @@ private void processDelete(OAuth20Provider provider, HttpServletRequest request,
399399

400400
// If clientId does not exist in database, return error 404 response
401401
if (currClient == null) {
402-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_INVALID_CLIENTID", new Object[] { request.getMethod(), OAuth20Constants.CLIENT_ID, clientId });
402+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_INVALID_CLIENTID", new Object[] { request.getMethod(), OAuth20Constants.CLIENT_ID, clientId });
403403
Tr.error(tc, errorMsg.getServerErrorMessage());
404404
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT, HttpServletResponse.SC_NOT_FOUND);
405405

@@ -429,7 +429,7 @@ private OidcBaseClient getOidcBaseClientFromRequestBody(HttpServletRequest reque
429429
try {
430430
return GSON.fromJson(request.getReader(), OidcBaseClient.class);
431431
} catch (JsonParseException e) {
432-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_MALFORMED_REQUEST");
432+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_MALFORMED_REQUEST");
433433
Tr.error(tc, errorMsg.getServerErrorMessage());
434434
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT_METADATA, HttpServletResponse.SC_BAD_REQUEST);
435435

@@ -455,7 +455,7 @@ private void processClientId(OidcBaseClient client, OidcOAuth20ClientProvider cl
455455
if (!OidcOAuth20Util.isNullEmpty(clientId)) {
456456
// Throw error if client_id already exists
457457
if (clientProvider.exists(clientId)) {
458-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_CLIENTID_EXISTS", new Object[] { clientId });
458+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_CLIENTID_EXISTS", new Object[] { clientId });
459459
Tr.error(tc, errorMsg.getServerErrorMessage());
460460
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT_METADATA, HttpServletResponse.SC_BAD_REQUEST);
461461
}
@@ -502,7 +502,7 @@ private void processNewClientSecret(OidcBaseClient client) throws OidcServerExce
502502
if (!OidcOAuth20Util.isNullEmpty(client.getTokenEndpointAuthMethod())
503503
&& client.getTokenEndpointAuthMethod().equals(OIDCConstants.OIDC_DISC_TOKEN_EP_AUTH_METH_SUPP_NONE)
504504
&& !OidcOAuth20Util.isNullEmpty(client.getClientSecret())) {
505-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_PUBLIC_CLIENT_CREATE_FAILURE");
505+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_PUBLIC_CLIENT_CREATE_FAILURE");
506506
Tr.error(tc, errorMsg.getServerErrorMessage());
507507
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT_METADATA, HttpServletResponse.SC_BAD_REQUEST);
508508

@@ -519,7 +519,7 @@ private ClientSecretAction processUpdateClientSecret(OidcBaseClient incomingClie
519519
}
520520

521521
if (action == null) {
522-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_INVALID_CONFIG");
522+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_INVALID_CONFIG");
523523
Tr.error(tc, errorMsg.getServerErrorMessage());
524524
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT_METADATA, HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
525525

@@ -555,7 +555,7 @@ private ClientSecretAction setSecretAndGetActionForNonEmptyUpdatedClientSecret(O
555555
|| incomingClient.getTokenEndpointAuthMethod().equals(OIDCConstants.OIDC_DISC_TOKEN_EP_AUTH_METH_SUPP_CLIENT_SECRET_POST)) {
556556
if (incomingClient.getClientSecret().equals("*")) {
557557
if (OidcOAuth20Util.isNullEmpty(existingClient.getClientSecret())) {
558-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_CLIENT_SECRET_UPDATE_FAILURE");
558+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_CLIENT_SECRET_UPDATE_FAILURE");
559559
Tr.error(tc, errorMsg.getServerErrorMessage());
560560
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT_METADATA, HttpServletResponse.SC_BAD_REQUEST);
561561

@@ -593,7 +593,7 @@ private ClientSecretAction getActionForNonEmptyClientSecretForTokenEndptAuthMeth
593593
}
594594

595595
private void throwErrorForInvalidPublicClientUpdate() throws OidcServerException {
596-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_PUBLIC_CLIENT_UPDATE_FAILURE");
596+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_PUBLIC_CLIENT_UPDATE_FAILURE");
597597
Tr.error(tc, errorMsg.getServerErrorMessage());
598598
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT_METADATA, HttpServletResponse.SC_BAD_REQUEST);
599599
}
@@ -615,7 +615,7 @@ private static String computeRegistrationUri(HttpServletRequest request, String
615615
private OidcOAuth20Client validateClientIdExists(String clientId, OidcOAuth20ClientProvider clientProvider) throws OidcServerException {
616616
OidcOAuth20Client client = clientProvider.get(clientId);
617617
if (client == null) {
618-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_CLIENTID_NOT_FOUND", new Object[] { clientId });
618+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_CLIENTID_NOT_FOUND", new Object[] { clientId });
619619
Tr.error(tc, errorMsg.getServerErrorMessage());
620620
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_CLIENT, HttpServletResponse.SC_NOT_FOUND);
621621
}
@@ -626,7 +626,7 @@ private OidcOAuth20Client validateClientIdExists(String clientId, OidcOAuth20Cli
626626
private String validateRequestContainsClientId(HttpServletRequest request) throws OidcServerException {
627627
String clientId = extractClientId(request.getPathInfo());
628628
if (OidcOAuth20Util.isNullEmpty(clientId)) {
629-
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage(tc, "OAUTH_CLIENT_REGISTRATION_MISSING_CLIENTID", new Object[] { request.getMethod(), OAuth20Constants.CLIENT_ID });
629+
BrowserAndServerLogMessage errorMsg = new BrowserAndServerLogMessage("OAUTH_CLIENT_REGISTRATION_MISSING_CLIENTID", new Object[] { request.getMethod(), OAuth20Constants.CLIENT_ID });
630630
Tr.error(tc, errorMsg.getServerErrorMessage());
631631
throw new OidcServerException(errorMsg, OIDCConstants.ERROR_INVALID_REQUEST, HttpServletResponse.SC_BAD_REQUEST);
632632

0 commit comments

Comments
 (0)