Skip to content

Commit 7021508

Browse files
committed
Guard connection pool histograms in beta, bump service.ranking of mp telemetry's OpenTelemetryInfoFactoryImpl to 1500, update feature resolver singletons map
1 parent 3a1b46b commit 7021508

File tree

5 files changed

+51
-13
lines changed

5 files changed

+51
-13
lines changed

dev/com.ibm.ws.connectionpool.monitor/bnd.bnd

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#*******************************************************************************
2-
# Copyright (c) 2017, 2023 IBM Corporation and others.
2+
# Copyright (c) 2017, 2024 IBM Corporation and others.
33
# All rights reserved. This program and the accompanying materials
44
# are made available under the terms of the Eclipse Public License 2.0
55
# which accompanies this distribution, and is available at
@@ -56,4 +56,5 @@ instrument.disabled: true
5656
com.ibm.ws.org.osgi.annotation.versioning;version=latest,\
5757
com.ibm.wsspi.org.osgi.service.component.annotations;version=latest,\
5858
com.ibm.wsspi.org.osgi.service.event;version=latest,\
59-
com.ibm.ws.container.service.compat;version=latest
59+
com.ibm.ws.container.service.compat;version=latest,\
60+
com.ibm.ws.kernel.boot.core;version=latest

dev/com.ibm.ws.connectionpool.monitor/src/com/ibm/ws/connectionpool/monitor/metrics/MetricsManager.java

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import com.ibm.websphere.ras.Tr;
2626
import com.ibm.websphere.ras.TraceComponent;
27+
import com.ibm.ws.kernel.productinfo.ProductInfo;
2728

2829
@Component(configurationPolicy = IGNORE, immediate = true)
2930
public class MetricsManager {
@@ -47,6 +48,12 @@ public void deactivate() {
4748
}
4849

4950
public static MetricsManager getInstance() {
51+
52+
//beta - return no instance
53+
if (!ProductInfo.getBetaEdition()) {
54+
return null;
55+
}
56+
5057
if (instance != null) {
5158
return instance;
5259
}
@@ -63,7 +70,11 @@ public static MetricsManager getInstance() {
6370
* @param duration recorded Duration of the wait time
6471
*/
6572
public void updateWaitTimeMetrics(String poolName, Duration duration) {
66-
metricRuntimes.stream().forEach(adapters -> adapters.updateWaitTimeMetrics(poolName, duration));
73+
//just in case
74+
if (!ProductInfo.getBetaEdition()) {
75+
metricRuntimes.stream().forEach(adapters -> adapters.updateWaitTimeMetrics(poolName, duration));
76+
}
77+
6778
}
6879

6980
/**
@@ -72,7 +83,11 @@ public void updateWaitTimeMetrics(String poolName, Duration duration) {
7283
* @param Duration recorded Duration of the (in) use time.
7384
*/
7485
public void updateInUseTimeMetrics(String poolName, Duration duration) {
75-
metricRuntimes.stream().forEach(adapters -> adapters.updateInUseTimeMetrics(poolName, duration));
86+
//just in case
87+
if (!ProductInfo.getBetaEdition()) {
88+
metricRuntimes.stream().forEach(adapters -> adapters.updateInUseTimeMetrics(poolName, duration));
89+
}
90+
7691
}
7792

7893
}

dev/com.ibm.ws.kernel.feature.resolver_fat/publish/verify/singleton_expected.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13865,6 +13865,12 @@
1386513865
<resolved>io.openliberty.mpJwtPropagation-2.1</resolved>
1386613866
<resolved>io.openliberty.cdi3.0-transaction2.0</resolved>
1386713867
<resolved>io.openliberty.cdi3.0-appSecurity</resolved>
13868+
<resolved-feature>io.openliberty.servlet5.0-monitor1.0</resolved-feature>
13869+
<resolved-feature>com.ibm.websphere.appserver.distributedMapPMI-1.0</resolved-feature>
13870+
<resolved-feature>io.openliberty.restfulWS3.0-monitor1.0</resolved-feature>
13871+
<resolved-feature>io.openliberty.httpStat-monitor1.0.jakarta</resolved-feature>
13872+
<resolved-feature>monitor-1.0</resolved-feature>
13873+
<resolved-feature>com.ibm.websphere.appserver.sessionMonitor-1.0</resolved-feature>
1386813874
</output>
1386913875
</case>
1387013876
<case>
@@ -15587,6 +15593,11 @@
1558715593
<resolved>io.openliberty.cdi3.0-jndi1.0</resolved>
1558815594
<resolved>io.openliberty.cdi4.0-servlet6.0</resolved>
1558915595
<resolved>io.openliberty.cdi3.0-transaction2.0</resolved>
15596+
<resolved-feature>io.openliberty.servlet5.0-monitor1.0</resolved-feature>
15597+
<resolved-feature>io.openliberty.restfulWS3.0-monitor1.0</resolved-feature>
15598+
<resolved-feature>io.openliberty.httpStat-monitor1.0.jakarta</resolved-feature>
15599+
<resolved-feature>monitor-1.0</resolved-feature>
15600+
<resolved-feature>com.ibm.websphere.appserver.sessionMonitor-1.0</resolved-feature>
1559015601
</output>
1559115602
</case>
1559215603
<case>

dev/com.ibm.ws.kernel.feature.resolver_fat/publish/verify/singleton_expected_WL.xml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,11 @@
215215
<resolved-feature>io.openliberty.cdi3.0-jndi1.0</resolved-feature>
216216
<resolved-feature>io.openliberty.cdi4.0-servlet6.0</resolved-feature>
217217
<resolved-feature>io.openliberty.cdi3.0-transaction2.0</resolved-feature>
218+
<resolved-feature>io.openliberty.servlet5.0-monitor1.0</resolved-feature>
219+
<resolved-feature>io.openliberty.restfulWS3.0-monitor1.0</resolved-feature>
220+
<resolved-feature>io.openliberty.httpStat-monitor1.0.jakarta</resolved-feature>
221+
<resolved-feature>monitor-1.0</resolved-feature>
222+
<resolved-feature>com.ibm.websphere.appserver.sessionMonitor-1.0</resolved-feature>
218223
</output>
219224
</case>
220225
<case>
@@ -7292,6 +7297,12 @@
72927297
<resolved-feature>io.openliberty.mpJwtPropagation-2.1</resolved-feature>
72937298
<resolved-feature>io.openliberty.cdi3.0-transaction2.0</resolved-feature>
72947299
<resolved-feature>io.openliberty.cdi3.0-appSecurity</resolved-feature>
7300+
<resolved-feature>io.openliberty.servlet5.0-monitor1.0</resolved-feature>
7301+
<resolved-feature>com.ibm.websphere.appserver.distributedMapPMI-1.0</resolved-feature>
7302+
<resolved-feature>io.openliberty.restfulWS3.0-monitor1.0</resolved-feature>
7303+
<resolved-feature>io.openliberty.httpStat-monitor1.0.jakarta</resolved-feature>
7304+
<resolved-feature>monitor-1.0</resolved-feature>
7305+
<resolved-feature>com.ibm.websphere.appserver.sessionMonitor-1.0</resolved-feature>
72957306
</output>
72967307
</case>
72977308
<case>

dev/io.openliberty.microprofile.telemetry.internal.common/src/io/openliberty/microprofile/telemetry/internal/common/info/OpenTelemetryInfoFactoryImpl.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,14 @@
2020
import java.util.concurrent.atomic.AtomicReference;
2121
import java.util.function.BiFunction;
2222

23+
import org.apache.commons.lang3.concurrent.LazyInitializer;
24+
import org.eclipse.microprofile.config.Config;
25+
import org.eclipse.microprofile.config.ConfigProvider;
26+
import org.eclipse.microprofile.config.spi.ConfigSource;
27+
import org.osgi.service.component.annotations.Activate;
28+
import org.osgi.service.component.annotations.Component;
29+
import org.osgi.service.component.annotations.Reference;
30+
2331
import com.ibm.websphere.ras.Tr;
2432
import com.ibm.websphere.ras.TraceComponent;
2533
import com.ibm.ws.container.service.app.deploy.ApplicationInfo;
@@ -32,14 +40,6 @@
3240
import com.ibm.ws.runtime.metadata.MetaDataSlot;
3341
import com.ibm.ws.threadContext.ComponentMetaDataAccessorImpl;
3442

35-
import org.apache.commons.lang3.concurrent.LazyInitializer;
36-
import org.eclipse.microprofile.config.Config;
37-
import org.eclipse.microprofile.config.ConfigProvider;
38-
import org.eclipse.microprofile.config.spi.ConfigSource;
39-
import org.osgi.service.component.annotations.Activate;
40-
import org.osgi.service.component.annotations.Component;
41-
import org.osgi.service.component.annotations.Reference;
42-
4343
import io.openliberty.microprofile.telemetry.internal.common.AgentDetection;
4444
import io.openliberty.microprofile.telemetry.internal.common.constants.OpenTelemetryConstants;
4545
import io.openliberty.microprofile.telemetry.internal.interfaces.OpenTelemetryInfoFactory;
@@ -51,7 +51,7 @@
5151
import io.opentelemetry.sdk.resources.ResourceBuilder;
5252

5353
// We want this to start before CDI so the meta data slot is ready before anyone triggers the CDI producer.
54-
@Component(service = { ApplicationStateListener.class, OpenTelemetryInfoFactory.class }, property = { "service.vendor=IBM", "service.ranking:Integer=150" })
54+
@Component(service = { ApplicationStateListener.class, OpenTelemetryInfoFactory.class }, property = { "service.vendor=IBM", "service.ranking:Integer=1500" })
5555
public class OpenTelemetryInfoFactoryImpl implements ApplicationStateListener, OpenTelemetryInfoFactory {
5656

5757
/*

0 commit comments

Comments
 (0)