Skip to content

Commit e36a6c8

Browse files
committed
Remove TODO comments that are no longer needed
1 parent da22ff9 commit e36a6c8

File tree

2 files changed

+3
-35
lines changed

2 files changed

+3
-35
lines changed

Diff for: dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/inbound/HttpInboundServiceContextImpl.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -546,8 +546,6 @@ protected HttpRequestMessageImpl getRequestImpl() {
546546
setStartTime();
547547
HttpRequestMessageImpl req = getMyRequest();
548548

549-
// if applicable set the HTTP/2 specific content length
550-
//TODO: Netty H2
551549
if (!getHttpConfig().useNetty() && myLink instanceof H2HttpInboundLinkWrap) {
552550
int len = ((H2HttpInboundLinkWrap) myLink).getH2ContentLength();
553551
if (len != -1) {
@@ -945,7 +943,7 @@ public VirtualConnection sendRawResponseBody(WsByteBuffer[] body, InterChannelCa
945943
* @return HttpInvalidMessageException (null if valid)
946944
*/
947945
protected HttpInvalidMessageException checkResponseValidity() {
948-
946+
949947
// if this wasn't a HEAD request, then check to make sure we sent the
950948
// same amount of bytes that were in the content-length header
951949
if (!MethodValues.HEAD.equals(getRequest().getMethodValue())) {
@@ -2125,7 +2123,7 @@ public void setStartTime() {
21252123

21262124
if (Objects.nonNull(nettyContext)) {
21272125
nettyContext.channel().attr(NettyHttpConstants.REQUEST_START_TIME).set(this.startTime);
2128-
}
2126+
}
21292127
}
21302128
}
21312129
}
@@ -2195,7 +2193,7 @@ public void setRemoteUser(String remoteUser) {
21952193
}
21962194

21972195
public String getRemoteUser() {
2198-
return this.remoteUser;
2196+
return this.remoteUser;
21992197
}
22002198

22012199
public void initForwardedValues() {

Diff for: dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyVirtualConnectionImpl.java

-30
Original file line numberDiff line numberDiff line change
@@ -44,139 +44,109 @@ public void init() {
4444

4545
@Override
4646
public void destroy() {
47-
// TODO Auto-generated method stub
48-
4947
}
5048

5149
@Override
5250
public Map<Object, Object> getStateMap() {
53-
// TODO Auto-generated method stub
5451
return stateStore;
5552
}
5653

5754
@Override
5855
public boolean requestPermissionToRead() {
59-
// TODO Auto-generated method stub
6056
return false;
6157
}
6258

6359
@Override
6460
public boolean requestPermissionToWrite() {
65-
// TODO Auto-generated method stub
6661
return false;
6762
}
6863

6964
@Override
7065
public boolean requestPermissionToClose(long waitForPermission) {
71-
// TODO Auto-generated method stub
7266
return false;
7367
}
7468

7569
@Override
7670
public void setReadStateToDone() {
77-
// TODO Auto-generated method stub
78-
7971
}
8072

8173
@Override
8274
public void setWriteStateToDone() {
83-
// TODO Auto-generated method stub
84-
8575
}
8676

8777
@Override
8878
public boolean isInputStateTrackingOperational() {
89-
// TODO Auto-generated method stub
9079
return false;
9180
}
9281

9382
@Override
9483
public Object getLockObject() {
95-
// TODO Auto-generated method stub
9684
return this;
9785
}
9886

9987
@Override
10088
public boolean requestPermissionToFinishRead() {
101-
// TODO Auto-generated method stub
10289
return false;
10390
}
10491

10592
@Override
10693
public boolean requestPermissionToFinishWrite() {
107-
// TODO Auto-generated method stub
10894
return false;
10995
}
11096

11197
@Override
11298
public void setReadStatetoCloseAllowedNoSync() {
113-
// TODO Auto-generated method stub
114-
11599
}
116100

117101
@Override
118102
public void setWriteStatetoCloseAllowedNoSync() {
119-
// TODO Auto-generated method stub
120-
121103
}
122104

123105
@Override
124106
public boolean getCloseWaiting() {
125-
// TODO Auto-generated method stub
126107
return false;
127108
}
128109

129110
@Override
130111
public boolean isCloseWithReadOutstanding() {
131-
// TODO Auto-generated method stub
132112
return false;
133113
}
134114

135115
@Override
136116
public boolean isCloseWithWriteOutstanding() {
137-
// TODO Auto-generated method stub
138117
return false;
139118
}
140119

141120
@Override
142121
public void setInetAddressingValid(boolean _newValue) {
143-
// TODO Auto-generated method stub
144-
145122
}
146123

147124
@Override
148125
public boolean getInetAddressingValid() {
149-
// TODO Auto-generated method stub
150126
return false;
151127
}
152128

153129
@Override
154130
public void setConnectionDescriptor(ConnectionDescriptor _newObject) {
155-
// TODO Auto-generated method stub
156-
157131
}
158132

159133
@Override
160134
public ConnectionDescriptor getConnectionDescriptor() {
161-
// TODO Auto-generated method stub
162135
return null;
163136
}
164137

165138
@Override
166139
public int attemptToSetFileChannelCapable(int value) {
167-
// TODO Auto-generated method stub
168140
return 0;
169141
}
170142

171143
@Override
172144
public int getFileChannelCapable() {
173-
// TODO Auto-generated method stub
174145
return 0;
175146
}
176147

177148
@Override
178149
public boolean isFileChannelCapable() {
179-
// TODO Auto-generated method stub
180150
return false;
181151
}
182152

0 commit comments

Comments
 (0)