Netty: Review TODO comments in netty code and make necessary changes

[pnicolucci]

Review the components changed for Netty for // TODO comments and ensure we have solutions / issues for these.

1. com.ibm.ws.transport.http
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/genericbnf/internal/BNFHeadersImpl.java#L2616 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/frames/Frame.java#L96 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/hpack/DynamicTable.java#L179 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/hpack/H2HeaderField.java#L49 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/hpack/H2Headers.java#L415 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/hpack/HpackConstants.java#L57 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/H2ConnectionLinkProxy.java -> Remove Auto-generated TODO comments in H2ConnectionLinkProxy #31133
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/H2StreamProcessor.java#L118 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/h2internal/H2WriteTree.java#L154 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/inbound/HttpInboundLink.java#L993 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/inbound/HttpInboundLink.java#L1010 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/inbound/HttpInboundServiceContextImpl.java#L550 (Netty Specific) Can be removed!
     • Netty: Remove TODO comments that are no longer needed #31248
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/inbound/HttpInputStreamImpl.java#L108 NEED NETTY ISSUE
     • Netty: Handle DataFormatException  #31249
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/outbound/HttpOutputStreamImpl.java#L423 ( CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/values/CookieSameSiteData.java#L49 ( CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpBaseMessageImpl.java#L2535 ( CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpBaseMessageImpl.java#L2977 ( CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpChannelConfig.java#L242 (auto-generated can be cleaned up)
     • Remove auto-generated TODO comments in com.ibm.ws.transport.http - netty-transport-http branch #31184
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpConfigConstants.java#L442 NEED NETTY ISSUE
     • Netty: Change internal value for netty beta for partitioned #31250
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpRequestMessageImpl.java#L575 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpRequestMessageImpl.java#L593 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpResponseMessageImpl.java#L567 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpServiceContextImpl.java#L2955 (Netty specific)
     • Netty: getResponse API instead of Netty response object directly #31275
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpServiceContextImpl.java#L3013 (Netty specific)
     • Netty: Add ssl ALPN to handleNettyPreload #31276
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpServiceContextImpl.java#L3297 (Netty specific)
     • Netty: Verify if NettyHttpConstants.RESPONSE_BYTES_WRITTEN is necessary #31277
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/channel/internal/HttpServiceContextImpl.java#L4410 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java#L216 (Netty specific)
     • Netty: determine if prepareForUpgrade is still being used #31278 (New issue for investigation)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java#L761 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java#L780 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpDispatcherLink.java#L1380 (Netty specific)
     • Remove commented out code: Netty: Remove commented code in getSSLContext() #31279
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/channel/HttpRequestImpl.java#L324 (auto generated can be cleaned up)
     • Remove auto-generated TODO comments in com.ibm.ws.transport.http #31183
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/dispatcher/internal/HttpDispatcher.java#L717 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/internal/HttpChain.java#L604 (CFW)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/inbound/NettyInboundServiceContext.java ( Open issue to re-enable this when ready)
     • Netty: complete work for NettyInboundServiceContext.java #31274
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/inbound/NettyTCPReadRequestContext.java#L165 (
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/inbound/NettyTCPReadRequestContext.java#L242
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/inbound/NettyTCPReadRequestContext.java#L275
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyBaseMessage.java (In general, there are a lot of unimplemented methods here we need to review)
     • Netty: Determine if we need to add trailer support in NettyBaseMessage #31280
     • Netty: Clean up NettyBaseMessage unimplemented methods #31281
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyRequestMessage.java#L149
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyRequestMessage.java#L333
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyRequestMessage.java#L763
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyRequestMessage.java#L834
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyRequestMessage.java#L917
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/message/NettyResponseMessage.java
     • Netty: Clean up NettyResponseMessage unimplemented methods #31309
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/http2/LibertyNettyALPNHandler.java#L76
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/http2/LibertyUpgradeCodec.java#L113
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/http2/LibertyUpgradeCodec.java#L180
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/inbound/HttpDispatcherHandler.java#L77
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/inbound/HttpDispatcherHandler.java#L84
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/inbound/HttpDispatcherHandler.java#L176
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/inbound/LibertyHttpRequestHandler.java#L49
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/HttpPipelineInitializer.java#L218
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/HttpPipelineInitializer.java#L252
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/HttpPipelineInitializer.java#L294
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/LibertySslHandler.java#L40
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/pipeline/LibertySslHandler.java#L96
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyHttpChannelConfig.java#L162
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyHttpRequestImpl.java#L88
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyHttpRequestImpl.java#L214
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyHttpRequestImpl.java#L240
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyHttpRequestImpl.java#L312
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyHttpRequestImpl.java#L372
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/netty/NettyVirtualConnectionImpl.java (There are many auto-generated, review and clean up)
     • Netty: Remove TODO comments that are no longer needed #31248
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/netty/upgrade/NettyServletUpgradeHandler.java#L119
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/netty/upgrade/NettyServletUpgradeHandler.java#L124
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/netty/upgrade/NettyServletUpgradeHandler.java#L129
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/netty/upgrade/NettyServletUpgradeHandler.java#L258
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/ws/http/internal/HttpEndpointImpl.java#L1388
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/wsspi/http/ee7/HttpInboundConnectionExtended.java#L25
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/wsspi/http/ee7/HttpInputStreamEE7.java#L57 (auto-generated can be cleaned up)
     • Remove auto-generated TODO comments in com.ibm.ws.transport.http #31183
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.transport.http/src/com/ibm/wsspi/http/ee7/HttpOutputStreamEE7.java#L60 (auto-generated can be cleaned up)
     • Remove auto-generated TODO comments in com.ibm.ws.transport.http #31183
2. io.openliberty.netty.internal -> NONE
3. io.openliberty.netty.internal.impl
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyFrameworkImpl.java#L87
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyFrameworkImpl.java#L247
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyFrameworkImpl.java#L358 -> Remove Auto-generated TODOs in NettyFrameworkImpl #31131
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyFrameworkImpl.java#L365 -> Remove Auto-generated TODOs in NettyFrameworkImpl #31131
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyQuiesceListener.java#L71
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/tcp/TCPChannelInitializerImpl.java#L49
     • Netty: Add logging equal to CFW in TCPChannelInitializerImpl #31310
4. io.openliberty.netty.internal.tls.impl
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.tls.impl/src/io/openliberty/netty/internal/tls/impl/NettyTlsProviderImpl.java#L44
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.tls.impl/src/io/openliberty/netty/internal/tls/impl/NettyTlsProviderImpl.java#L280
5. com.ibm.ws.sipcontainer
   • There are 390 TODO comments in this component we need to review these rather than list them all here.
   • Removal of auto-generated TODO comments: Remove auto-generated todo comments in com.ibm.ws.sipcontainer #31182
6. com.ibm.ws.wsoc
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/configurator/DefaultServerEndpointConfigurator.java#L117 (Not Netty related)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/external/RemoteEndpointAsyncExt.java#L119 (Not Netty related)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/external/RemoteEndpointBasicExt.java#L128 (Not Netty related)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/external/SessionExt.java#L196 (Not Netty related)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/outbound/NettyHttpRequestorWsoc10.java#L142 (Netty specific, also system.out should be removed)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/outbound/NettyHttpRequestorWsoc10.java (8 auto-generated can be cleaned up)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/outbound/NettyHttpRequestorWsoc10.java#L320 (Netty specific also system.out should be removed)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/outbound/WsocChain.java#L385
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/outbound/WsocChain.java#L397 (auto-generated can be clean up)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/outbound/WsocOutboundChain.java#L110 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.wsoc/src/com/ibm/ws/wsoc/MessageReader.java#L570
7. com.ibm.ws.wsoc.1.1 -> None in this component
8. com.ibm.ws.messaging.comms.client
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/comms/client/ClientSideConnection.java#L208
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/comms/client/ConsumerSessionProxy.java#L2130
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/comms/common/CommsByteBuffer.java#L1827
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/comms/common/CommsDiagnosticModule.java#L62
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/octracker/ConnectionDataGroup.java#L711 (Netty specific auto generated, can be cleaned up)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/CommsOutboundChain.java#L89
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/Connection.java#L376 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/NettyConnectionReadCompletedCallback.java#L236 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/NettyConnectionReadCompletedCallback.java#L241 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/NettyConnectionReadCompletedCallback.java#L443 (Netty specific auto-generated, can be cleaned up)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/NettyConnectionReadCompletedCallback.java#L534 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/NettyConnectionWriteCompletedCallback.java#L321 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/impl/OutboundConnection.java#L82
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyJMSClientHandler.java#L105 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnection.java#L92 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnection.java#L97 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnection.java#L143 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnectionContext.java#L65 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnectionContext.java#L106 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyNetworkConnectionFactory.java#L109 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/netty/NettyToWsBufferDecoder.java#L55 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/approxtime/impl/RichQuickApproxTimeImpl.java#L49 (Not Netty related)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientFramework.java#L132
     • Issue already exists: Investigate unused code path in JMS Netty #22692
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientFramework.java#L175
     • Issue already exists: Investigate unused code path in JMS Netty #22692
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientFramework.java#L234 (Not Netty related)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientTransportFactory.java#L95
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientTransportFactory.java#L149
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientTransportFactory.java#L151
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/framework/impl/RichClientTransportFactory.java#L162
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/impl/JFapChannelFactory.java#L154 ( 4 auto-generated, we can ignore these)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.client/src/com/ibm/ws/sib/jfapchannel/richclient/impl/JFapChannelOutbound.java#L80 (one not auto generated and 4 auto generated we can ignore the auto generated)
9. com.ibm.ws.messaging.comms.server
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/jfap/inbound/channel/NettyInboundChain.java#L406 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/comms/server/clientsupport/CATConsumer.java#L664
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/comms/server/clientsupport/CATMainConsumer.java#L318
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/comms/server/clientsupport/ServerTransportReceiveListener.java#L1737
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/jfapchannel/server/impl/JFapChannelInbound.java#L102 (There are also 5 auto-generated that can be ignored)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/jfapchannel/server/impl/JFapDiscriminator.java#L216
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/jfapchannel/server/impl/NettyJMSServerHandler.java#L187 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/jfapchannel/server/impl/NettyJMSServerHandler.java#L223 (Netty specific)
   • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.messaging.comms.server/src/com/ibm/ws/sib/jfapchannel/server/impl/NettyJMSServerHandler.java#L237 (Netty specific)
10. io.openliberty.grpc.1.0
    • NONE
11. io.openliberty.grpc.1.0.internal
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.grpc.1.0.internal/src/io/grpc/servlet/AsyncServletOutputStreamWriter.java#L254 (Not Netty related)
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.grpc.1.0.internal/src/io/grpc/servlet/ServletServerStream.java#L88 (Not Netty related)
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.grpc.1.0.internal/src/io/openliberty/grpc/internal/servlet/GrpcServletUtils.java#L90 (Not Netty related)
12. io.openliberty.grpc.1.0.internal.client
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.grpc.1.0.internal.client/src/io/openliberty/grpc/internal/client/config/GrpcClientConfigValidation.java#L70 (Not Netty related)
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.grpc.1.0.internal.client/src/io/openliberty/grpc/internal/client/security/authorization/oauth/GrpcOAuthPropagationHelper.java#L124 (Not Netty related)
13. io.openliberty.grpc.1.0.internal.client.monitor
    • NONE
14. io.openliberty.grpc.1.0.internal.client.security
    • NONE
15. io.openliberty.grpc.1.0.internal.common
    • NONE
16. io.openliberty.grpc.1.0.internal.monitor
    • NONE
17. io.openliberty.grpc.client.1.0.thirdparty
    • NONE
18. io.openliberty.io.grpc.1.0
    • NONE
19. com.ibm.ws.ssl
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/websphere/ssl/SSLConfig.java#L393
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/runtime/util/StreamHandlerUtils.java#L197
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/config/ProtocolHelper.java#L96
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/config/WSKeyStore.java#L96
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/internal/KeystoreConfigurationFactory.java#L384 (auto-generated)
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/internal/SSLComponent.java#L170
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/internal/SSLComponent.java#L190
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/internal/SSLComponent.java#L241
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.ssl/src/com/ibm/ws/ssl/SSLPropertyUtils.java#L102
20. com.ibm.ws.channel.ssl
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.channel.ssl/src/com/ibm/ws/channel/ssl/internal/SSLChannel.java#L129
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.channel.ssl/src/com/ibm/ws/channel/ssl/internal/SSLConnectionLink.java#L1153
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.channel.ssl/src/com/ibm/ws/channel/ssl/internal/SSLReadServiceContext.java#L1634
    • https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/com.ibm.ws.channel.ssl/src/com/ibm/ws/channel/ssl/internal/SSLUtils.java#L1205

[pnicolucci]

.5 PW as of 3/17/2025 to go through the code and open issues for any remaining work we find for GA