Netty: Review NettyFrameworkImpl

[pnicolucci]

https://github.com/OpenLiberty/open-liberty/blob/netty-transport-http/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyFrameworkImpl.java

1. // TODO: Should we use this or maybe the event loop on activate?
2. //TODO: change to same log used in traditional channel.

[volosied]

1. Recommend approach I see is to use outboundConnections = new DefaultChannelGroup(childGroup.next()); Testing to verify....

2. I don't see an exact match. Logic between Netty and Channel Framework differs.

Closest match may be

open-liberty/dev/com.ibm.ws.channelfw/src/com/ibm/ws/channelfw/internal/ChannelFrameworkImpl.java

Lines 3036 to 3037 in 7e578aa

	FFDCFilter.processException(e, getClass().getName() + ".stopChainInternal", "2711", this, new Object[] { chain, this });
	Tr.error(tc, "chain.stop.error", new Object[] { chain.getName(), e.toString() });

---

I did see a Destroying all endpoints message in Channel:

open-liberty/dev/com.ibm.ws.channelfw/src/com/ibm/websphere/channelfw/osgi/CHFWBundle.java

Line 157 in d1e7fc4

Tr.event(this, tc, "Destroying all endpoints");

I see the following exception, but it's for the chain:

open-liberty/dev/com.ibm.ws.channelfw/src/com/ibm/websphere/channelfw/ChannelUtils.java

Line 900 in d1e7fc4

Tr.debug(tc, "Error stopping chain: " + t);

Main quiesce logic for Netty looks to be within:

open-liberty/dev/io.openliberty.netty.internal.impl/src/io/openliberty/netty/internal/impl/NettyQuiesceListener.java

Line 54 in d1e7fc4

public ScheduledFuture<?> startTasks() {