Skip to content

Netty: Inconsistent Naming: useRemoteIpOptions and useForwardingHeaders #32407

@volosied

Description

@volosied

useForwardingHeaders was renamed to useRemoteIpOptions to better reflect the config in only some code locations:
https://openliberty.io/docs/latest/reference/config/remoteIp.html

However, HttpInboundConnectionExtended.java uses useForwardedHeaders and that means additional renames.

There's also a slight rename here:

public boolean useForwardedHeaders() {
return getHttpConfig().useForwardingHeaders();
}

This should be reworked for consistency post Netty beta.
Originally posted by @volosied in #32308 (comment)

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Less Complex Issues

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions