Skip to content

Conversation

@jjiwooLim
Copy link
Member

@jjiwooLim jjiwooLim commented Dec 3, 2025

Fix intermittent test failure due to race condition.
Added sync parameter to the sessionPut call to force synchronous write to cache

This change does not affect the functionality of the test as the test is just checking the configuration of httpSessionCahce-writeContents

@jjiwooLim
Copy link
Member Author

jjiwooLim commented Dec 3, 2025

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Member

LibbyBot commented Dec 3, 2025

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@jjiwooLim
Copy link
Member Author

jjiwooLim commented Dec 4, 2025

Build looks good, removed the copyrights header

@jjiwooLim jjiwooLim requested a review from pnicolucci December 4, 2025 23:17
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* IBM Corporation - initial API and implementation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove the copyright header, my comment was specific to two things:

  1. Just remove the Contributors section as it is no longer necessary for example:
/*******************************************************************************
 * Copyright (c) 2018, 2022 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License 2.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-2.0/
 * 
 * SPDX-License-Identifier: EPL-2.0
 *******************************************************************************/
  1. Update the copyright header date range to include 2025 if you agree that this is a significant enough change.

Also it would be good for someone from the session team to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants