-
Notifications
You must be signed in to change notification settings - Fork 623
Fix intermittent test failure in SessionCacheTwoServerTest #33584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integration
Are you sure you want to change the base?
Conversation
|
!build (view Open Liberty Personal Build - ✅ completed successfully!) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
...ibm.ws.session.cache_fat/fat/src/com/ibm/ws/session/cache/fat/SessionCacheTwoServerTest.java
Outdated
Show resolved
Hide resolved
|
Build looks good, removed the copyrights header |
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Contributors: | ||
| * IBM Corporation - initial API and implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove the copyright header, my comment was specific to two things:
- Just remove the Contributors section as it is no longer necessary for example:
/*******************************************************************************
* Copyright (c) 2018, 2022 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*******************************************************************************/
- Update the copyright header date range to include 2025 if you agree that this is a significant enough change.
Also it would be good for someone from the session team to review this.
Fix intermittent test failure due to race condition.
Added sync parameter to the sessionPut call to force synchronous write to cache
This change does not affect the functionality of the test as the test is just checking the configuration of httpSessionCahce-writeContents
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).