Skip to content

Fix intermittent test failure in SessionCacheTwoServerTest #33584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjiwooLim wants to merge 2 commits into
base: integration
Choose a base branch
from
+3 −15
Open

Fix intermittent test failure in SessionCacheTwoServerTest #33584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c51c3cd
add sync parameter to the sessionPut call to force synchronous write …
jjiwooLim Dec 3, 2025
305ab3f
remove the unnecessary copyright header
jjiwooLim Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions ....ws.session.cache_fat/fat/src/com/ibm/ws/session/cache/fat/SessionCacheTwoServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,3 @@
/*******************************************************************************
* Copyright (c) 2018, 2022 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-2.0/
*
* SPDX-License-Identifier: EPL-2.0
*
* Contributors:
* IBM Corporation - initial API and implementation
Copy link
Member

@pnicolucci pnicolucci Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove the copyright header, my comment was specific to two things:

  1. Just remove the Contributors section as it is no longer necessary for example:
/*******************************************************************************
 * Copyright (c) 2018, 2022 IBM Corporation and others.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License 2.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-2.0/
 * 
 * SPDX-License-Identifier: EPL-2.0
 *******************************************************************************/
  1. Update the copyright header date range to include 2025 if you agree that this is a significant enough change.

Also it would be good for someone from the session team to review this.

*******************************************************************************/
package com.ibm.ws.session.cache.fat;

import static org.junit.Assert.assertNotSame;
Expand Down Expand Up @@ -236,8 +224,8 @@ public void testHttpSessionListener() throws Exception {
public void testModifyWithoutPut() throws Exception {
List<String> session = new ArrayList<>();
if (session != null) {
appA.sessionPut("testModifyWithoutPut-key", new StringBuffer("MyValue"), session, true);
Thread.sleep(500);
appA.sessionPut("testModifyWithoutPut-key&sync=true", new StringBuffer("MyValue"), session, true);
Thread.sleep(500);
try {
appB.invokeServlet("testStringBufferAppendWithoutSetAttribute&key=testModifyWithoutPut-key", session);
// appA should not see the update because it does not get written to the persistent store without a putAttribute per writeContents=ONLY_SET_ATTRIBUTES
Expand Down Expand Up @@ -331,7 +319,7 @@ public void testMaxInactiveInterval() throws Exception {
List<String> session = new ArrayList<>();
if (session != null) {
appA.sessionPut("testMaxInactiveInterval-key", 55901, session, true);
Thread.sleep(500);
Thread.sleep(500);
appB.sessionGet("testMaxInactiveInterval-key", 55901, session);
appA.invokeServlet("setMaxInactiveInterval", session); //set max inactive interval to 1 second

Expand Down