Record entity that lacks an id

[njr-11]

I noticed a user attempting to use an entity that was missing a unique identifier and also not annotated @Entity. If the latter were present, Jakarta Persistence would raise an error and we even have an error path test for that already. However, in this case, there was no @Entity annotation, and we missed detecting any problem until ending up with a NullPointerException and raised a misleading error message.

• I have considered the risk of behavior change or other zero migration impact (https://github.com/OpenLiberty/open-liberty/wiki/Behavior-Changes).
• If this PR fixes an Issue, the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN" (verify release bug label if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).
• If this PR resolves an external Known Issue (including APARS), the description includes "Fixes #FILLMEIN" or "Resolves #FILLMEIN".

[njr-11]

!build
notification=newcomment

[LibbyBot]

Your Open Liberty Personal Build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=d3efac1d-515a-4637-a871-781b8c4cf408

Note: Target locations of links might be accessible only to IBM employees.

[LibbyBot]

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=d3efac1d-515a-4637-a871-781b8c4cf408 - Open Liberty Personal Build completed with errors/failures.

[njr-11]

!build
notification=newcomment

[LibbyBot]

Your Open Liberty Personal Build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=ecfaec28-7966-440b-990e-f930573f2a4e

Note: Target locations of links might be accessible only to IBM employees.

[LibbyBot]

Code analysis and actions

DO NOT DELETE THIS COMMENT.

• 3 FAT files were changed, added, or removed.

• Check that the build did not break the affected FAT suite(s).

• 6 product code files were changed.

• Please describe in a separate comment how you tested your changes.

• 1 messages files were changed and need an L2 review.

• @OpenLiberty/message-reviewer Please review.

  • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

• 1 NLS files were changed and need an ID review.

• @OpenLiberty/message-reviewer Please review.

  • dev/io.openliberty.data.internal.persistence/resources/io/openliberty/data/internal/persistence/resources/CWWKDMessages.nlsprops

[helyarp]

The messages are well written. I've suggested a change to one message.

[helyarp]

Instead of One of the record components ({1}), change it to The ({1}) record component

[njr-11]

@helyarp thanks for reviewing so quickly.
{1} is actually a list of the record components, so this will look like,

CWWKD1121E: The org.example.Person record cannot be used as an entity
because it lacks a unqiue identifier. One of the record components (ssn, firstName, lastName, birthday) must ...

so it would be incorrect to say "The record component" because the value has multiple.

[helyarp]

@njr-11 Hi, thanks for the explanation. Keep what you have. I'll add the ID reviewed label.

[LibbyBot]

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=ecfaec28-7966-440b-990e-f930573f2a4e - Open Liberty Personal Build completed with errors/failures.