Reset ThreadIdentity for SyncToOSThread in EJB After Each Invocation #33620
+14
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: We need to update the code to reset the thread identity back to the server identity when EJBSecurityCollaboratorImpl.postInvoke() is called. Currently, although we are correctly setting the syncToOSThreadToken in the EJBSecurityContext during preInvoke, this token is not being propagated to postInvoke because we are returning a SecurityCookieImpl object that does not contain the token field. This fix adds the syncToOSThreadToken field to SecurityCookieImpl and ensures the token is properly transferred from the EJBSecurityContext to the cookie during preInvoke, allowing postInvoke to retrieve and use it to reset the thread identity.
wrodrig
added
the
bug
Contributor
Author
|
!build Note: Target locations of links might be accessible only to IBM employees. |
Member
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
utle
removed
the
bug
wrodrig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to update the code to reset the thread identity back to the server identity when EJBSecurityCollaboratorImpl.postInvoke() is called.
Currently, although we are correctly setting the syncToOSThreadToken in the EJBSecurityContext during preInvoke, this token is not being propagated to postInvoke because we are returning a SecurityCookieImpl object that does not contain the token field.
This fix adds the syncToOSThreadToken field to SecurityCookieImpl and ensures the token is properly transferred from the EJBSecurityContext to the cookie during preInvoke, allowing postInvoke to retrieve and use it to reset the thread identity.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).