Open
Description
There are a lot of pull requests for new fixtures that are not yet reviewed and merged. Reviewing them (and maybe fixing smaller issues) helps get this number down and the number of fixtures in OFL up!
See the step-by-step instructions for fixture reviews:
These are the steps that take the longest when reviewing a fixture:
- Checking whether at least 3 links are present. Otherwise, finding suitable links.
- link to a manual PDF containing all DMX modes
- link to a product page on the official manufacturer website
- link to a YouTube or Vimeo video that showcases or explains the fixture
- Checking whether all DMX modes from the manual are included in the fixture definition.
- Checking whether all DMX modes' channels from the manual are included in the fixture definition.
- Checking whether all DMX channels' capabilities from the manual are included in the fixture definition.
If you could go through some PRs with thenew-fixture
label and comment on them with the results of those checks, that would help immensely. Thank you already :)For the fixtures passing these tests, these are some common tasks that often need to be fixed:
- replace capability type
StrobeSpeed
withShutterStrobe
where that one fits better- replace capability type
Generic
withMaintenance
where that one fits better- rename modes that have no name in the manual to the usual
5-channel
/5ch
format- link to an English manual / product page (if one exists) instead of one in another language
Pull requests with these fixes against the original fixture pull requests (see e.g. #2023) are highly appreciated!