Skip to content

☑ Help with reviewing new fixtures #2429

Open
@FloEdelmann

Description

@FloEdelmann

There are a lot of pull requests for new fixtures that are not yet reviewed and merged. Reviewing them (and maybe fixing smaller issues) helps get this number down and the number of fixtures in OFL up!

See the step-by-step instructions for fixture reviews:

These are the steps that take the longest when reviewing a fixture:

  1. Checking whether at least 3 links are present. Otherwise, finding suitable links.
    • link to a manual PDF containing all DMX modes
    • link to a product page on the official manufacturer website
    • link to a YouTube or Vimeo video that showcases or explains the fixture
  2. Checking whether all DMX modes from the manual are included in the fixture definition.
  3. Checking whether all DMX modes' channels from the manual are included in the fixture definition.
  4. Checking whether all DMX channels' capabilities from the manual are included in the fixture definition.
    If you could go through some PRs with the new-fixture label and comment on them with the results of those checks, that would help immensely. Thank you already :)

For the fixtures passing these tests, these are some common tasks that often need to be fixed:

  • replace capability type StrobeSpeed with ShutterStrobe where that one fits better
  • replace capability type Generic with Maintenance where that one fits better
  • rename modes that have no name in the manual to the usual 5-channel/5ch format
  • link to an English manual / product page (if one exists) instead of one in another language

Pull requests with these fixes against the original fixture pull requests (see e.g. #2023) are highly appreciated!

Metadata

Metadata

Assignees

No one assigned

    Labels

    difficulty-easyImplementation is relatively straighforward.good first issueEasy to pick up for new contributors. Only little domain knowledge required.hacktoberfestGood issue for users participating in the Hacktoberfest.help wantedMore information/insights or implementation wanted from others.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions