fix: allow non-critics when using multiple-gpu

LovelyBuggies · LovelyBuggies · commit 1dd72371cd50 · 2026-02-24T21:42:51.000-05:00
diff --git a/comlrl/trainers/actor_critic/iac.py b/comlrl/trainers/actor_critic/iac.py
@@ -97,9 +97,10 @@ def __post_init__(self) -> None:
                 raise ValueError(
                     "parallel_training='mp' requires explicit agent_devices."
                 )
-            if self.critic_devices is None:
+            if self.use_separate_critic and self.critic_devices is None:
                 raise ValueError(
-                    "parallel_training='mp' requires explicit critic_devices."
+                    "parallel_training='mp' requires explicit critic_devices when "
+                    "use_separate_critic=True."
                 )
         self.parallel_training = mode
 

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,10 @@ def __post_init__(self) -> None:`
`97`	`97`	`raise ValueError(`
`98`	`98`	`"parallel_training='mp' requires explicit agent_devices."`
`99`	`99`	`)`
`100`		`- if self.critic_devices is None:`
	`100`	`+ if self.use_separate_critic and self.critic_devices is None:`
`101`	`101`	`raise ValueError(`
`102`		`- "parallel_training='mp' requires explicit critic_devices."`
	`102`	`+ "parallel_training='mp' requires explicit critic_devices when "`
	`103`	`+ "use_separate_critic=True."`
`103`	`104`	`)`
`104`	`105`	`self.parallel_training = mode`
`105`	`106`