Skip to content

Commit 8e664e6

Browse files
author
Sven Reichel
authored
PHP-CS-Fixer: static methods for tests (#4)
1 parent 4304691 commit 8e664e6

11 files changed

+50
-48
lines changed

‎.php-cs-fixer.dist.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,16 @@
99
'modernize_types_casting' => true,
1010
'nullable_type_declaration_for_default_null_value' => true,
1111
'single_quote' => true,
12+
'php_unit_test_case_static_method_calls' => true,
1213
'trailing_comma_in_multiline' => ['after_heredoc' => true, 'elements' => ['arguments', 'array_destructuring', 'arrays']],
1314
])
1415
->setFinder(
1516
PhpCsFixer\Finder::create()
1617
->in([
1718
__DIR__ . '/src',
19+
__DIR__ . '/tests',
1820
])
1921
->name('*.php')
2022
->ignoreDotFiles(true)
21-
->ignoreVCS(true)
22-
);
23+
->ignoreVCS(true),
24+
);

‎tests/unit/Copy/AbstractCopyPluginTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,6 @@ public function setUp(): void
3535
*/
3636
public function testGetFileSystem(): void
3737
{
38-
$this->assertInstanceOf(Filesystem::class, $this->subject->getFileSystem());
38+
static::assertInstanceOf(Filesystem::class, $this->subject->getFileSystem());
3939
}
4040
}

‎tests/unit/Copy/Plugins/ChartJsTest.php

+9-9
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function setUp(): void
3535
*/
3636
public function testGetUnpkgName(): void
3737
{
38-
$this->assertSame('chart.js', $this->subject->getUnpkgName());
38+
static::assertSame('chart.js', $this->subject->getUnpkgName());
3939
}
4040

4141
/**
@@ -45,9 +45,9 @@ public function testGetUnpkgName(): void
4545
public function testGetUnpkgVersion(): void
4646
{
4747
try {
48-
$this->assertIsString($this->subject->getUnpkgVersion());
48+
static::assertIsString($this->subject->getUnpkgVersion());
4949
} catch (OutOfBoundsException $exception) {
50-
$this->assertSame('Package "nnnick/chartjs" is not installed', $exception->getMessage());
50+
static::assertSame('Package "nnnick/chartjs" is not installed', $exception->getMessage());
5151
}
5252
}
5353

@@ -56,7 +56,7 @@ public function testGetUnpkgVersion(): void
5656
*/
5757
public function testGetUnpkgSource(): void
5858
{
59-
$this->assertSame('dist', $this->subject->getUnpkgSource());
59+
static::assertSame('dist', $this->subject->getUnpkgSource());
6060
}
6161

6262

@@ -71,38 +71,38 @@ public function testGetUnpkgFiles(): void
7171
2 => 'helpers.js',
7272
3 => 'helpers.js.map',
7373
];
74-
$this->assertSame($result, $this->subject->getUnpkgFiles());
74+
static::assertSame($result, $this->subject->getUnpkgFiles());
7575
}
7676

7777
/**
7878
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\ChartJs::getComposerName()
7979
*/
8080
public function testGetComposerName(): void
8181
{
82-
$this->assertSame('nnnick/chartjs', $this->subject->getComposerName());
82+
static::assertSame('nnnick/chartjs', $this->subject->getComposerName());
8383
}
8484

8585
/**
8686
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\ChartJs::getComposerSource()
8787
*/
8888
public function testGetComposerSource(): void
8989
{
90-
$this->assertSame('dist', $this->subject->getComposerSource());
90+
static::assertSame('dist', $this->subject->getComposerSource());
9191
}
9292

9393
/**
9494
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\ChartJs::getComposerFiles()
9595
*/
9696
public function testGetComposerFiles(): void
9797
{
98-
$this->assertSame(['*.js', '*.map'], $this->subject->getComposerFiles());
98+
static::assertSame(['*.js', '*.map'], $this->subject->getComposerFiles());
9999
}
100100

101101
/**
102102
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\ChartJs::getCopyTarget()
103103
*/
104104
public function testGetCopyTarget(): void
105105
{
106-
$this->assertSame('js/lib/chartjs', $this->subject->getCopyTarget());
106+
static::assertSame('js/lib/chartjs', $this->subject->getCopyTarget());
107107
}
108108
}

‎tests/unit/Copy/Plugins/FlatpickrTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function setUp(): void
3535
*/
3636
public function testGetUnpkgName(): void
3737
{
38-
$this->assertSame('flatpickr', $this->subject->getUnpkgName());
38+
static::assertSame('flatpickr', $this->subject->getUnpkgName());
3939
}
4040

4141
/**
@@ -44,9 +44,9 @@ public function testGetUnpkgName(): void
4444
public function testGetUnpkgVersion(): void
4545
{
4646
try {
47-
$this->assertIsString($this->subject->getUnpkgVersion());
47+
static::assertIsString($this->subject->getUnpkgVersion());
4848
} catch (OutOfBoundsException $exception) {
49-
$this->assertSame('Package "nnnick/chartjs" is not installed', $exception->getMessage());
49+
static::assertSame('Package "nnnick/chartjs" is not installed', $exception->getMessage());
5050
}
5151
}
5252

@@ -55,7 +55,7 @@ public function testGetUnpkgVersion(): void
5555
*/
5656
public function testGetUnpkgSource(): void
5757
{
58-
$this->assertSame('dist', $this->subject->getUnpkgSource());
58+
static::assertSame('dist', $this->subject->getUnpkgSource());
5959
}
6060

6161
/**
@@ -67,14 +67,14 @@ public function testGetUnpkgFiles(): void
6767
0 => 'flatpickr.min.css',
6868
1 => 'flatpickr.min.js',
6969
];
70-
$this->assertSame($result, $this->subject->getUnpkgFiles());
70+
static::assertSame($result, $this->subject->getUnpkgFiles());
7171
}
7272

7373
/**
7474
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\Flatpickr::getCopyTarget()
7575
*/
7676
public function testGetCopyTarget(): void
7777
{
78-
$this->assertSame('js/lib/flatpickr', $this->subject->getCopyTarget());
78+
static::assertSame('js/lib/flatpickr', $this->subject->getCopyTarget());
7979
}
8080
}

‎tests/unit/Copy/Plugins/FlowJsTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,30 @@ public function setUp(): void
3434
*/
3535
public function testGetComposerName(): void
3636
{
37-
$this->assertSame('flowjs/flowjs', $this->subject->getComposerName());
37+
static::assertSame('flowjs/flowjs', $this->subject->getComposerName());
3838
}
3939

4040
/**
4141
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\FlowJs::getComposerSource()
4242
*/
4343
public function testGetComposerSource(): void
4444
{
45-
$this->assertSame('dist', $this->subject->getComposerSource());
45+
static::assertSame('dist', $this->subject->getComposerSource());
4646
}
4747

4848
/**
4949
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\FlowJs::getComposerFiles()
5050
*/
5151
public function testGetComposerFiles(): void
5252
{
53-
$this->assertSame(['*.js'], $this->subject->getComposerFiles());
53+
static::assertSame(['*.js'], $this->subject->getComposerFiles());
5454
}
5555

5656
/**
5757
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\FlowJs::getCopyTarget()
5858
*/
5959
public function testGetCopyTarget(): void
6060
{
61-
$this->assertSame('js/lib/uploader', $this->subject->getCopyTarget());
61+
static::assertSame('js/lib/uploader', $this->subject->getCopyTarget());
6262
}
6363
}

‎tests/unit/Copy/Plugins/JQueryTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,30 @@ public function setUp(): void
3434
*/
3535
public function testGetComposerName(): void
3636
{
37-
$this->assertSame('components/jquery', $this->subject->getComposerName());
37+
static::assertSame('components/jquery', $this->subject->getComposerName());
3838
}
3939

4040
/**
4141
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\JQuery::getComposerSource()
4242
*/
4343
public function testGetComposerSource(): void
4444
{
45-
$this->assertSame('', $this->subject->getComposerSource());
45+
static::assertSame('', $this->subject->getComposerSource());
4646
}
4747

4848
/**
4949
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\JQuery::getComposerFiles()
5050
*/
5151
public function testGetComposerFiles(): void
5252
{
53-
$this->assertSame(['*.js', '*.map'], $this->subject->getComposerFiles());
53+
static::assertSame(['*.js', '*.map'], $this->subject->getComposerFiles());
5454
}
5555

5656
/**
5757
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\JQuery::getCopyTarget()
5858
*/
5959
public function testGetCopyTarget(): void
6060
{
61-
$this->assertSame('js/lib/jquery', $this->subject->getCopyTarget());
61+
static::assertSame('js/lib/jquery', $this->subject->getCopyTarget());
6262
}
6363
}

‎tests/unit/Copy/Plugins/TinyMceLanguagesTest.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function setUp(): void
3535
*/
3636
public function testGetComposerName(): void
3737
{
38-
$this->assertSame('mklkj/tinymce-i18n', $this->subject->getComposerName());
38+
static::assertSame('mklkj/tinymce-i18n', $this->subject->getComposerName());
3939
}
4040

4141
/**
@@ -44,9 +44,9 @@ public function testGetComposerName(): void
4444
public function testGetComposerSource(): void
4545
{
4646
try {
47-
$this->assertSame('langs7', $this->subject->getComposerSource());
47+
static::assertSame('langs7', $this->subject->getComposerSource());
4848
} catch (OutOfBoundsException $exception) {
49-
$this->assertSame('Package "tinymce/tinymce" is not installed', $exception->getMessage());
49+
static::assertSame('Package "tinymce/tinymce" is not installed', $exception->getMessage());
5050
}
5151
}
5252

@@ -55,14 +55,14 @@ public function testGetComposerSource(): void
5555
*/
5656
public function testGetComposerFiles(): void
5757
{
58-
$this->assertSame(['*.css', '*.js'], $this->subject->getComposerFiles());
58+
static::assertSame(['*.css', '*.js'], $this->subject->getComposerFiles());
5959
}
6060

6161
/**
6262
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\TinyMceLanguages::getCopyTarget()
6363
*/
6464
public function testGetCopyTarget(): void
6565
{
66-
$this->assertSame('js/lib/tinymce/langs', $this->subject->getCopyTarget());
66+
static::assertSame('js/lib/tinymce/langs', $this->subject->getCopyTarget());
6767
}
6868
}

‎tests/unit/Copy/Plugins/TinyMceTest.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,30 @@ public function setUp(): void
3434
*/
3535
public function testGetComposerName(): void
3636
{
37-
$this->assertSame('tinymce/tinymce', $this->subject->getComposerName());
37+
static::assertSame('tinymce/tinymce', $this->subject->getComposerName());
3838
}
3939

4040
/**
4141
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\TinyMce::getComposerSource()
4242
*/
4343
public function testGetComposerSource(): void
4444
{
45-
$this->assertSame('', $this->subject->getComposerSource());
45+
static::assertSame('', $this->subject->getComposerSource());
4646
}
4747

4848
/**
4949
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\TinyMce::getComposerFiles()
5050
*/
5151
public function testGetComposerFiles(): void
5252
{
53-
$this->assertSame(['*.css', '*.js'], $this->subject->getComposerFiles());
53+
static::assertSame(['*.css', '*.js'], $this->subject->getComposerFiles());
5454
}
5555

5656
/**
5757
* @covers \OpenMage\ComposerPlugin\Copy\Plugins\TinyMce::getCopyTarget()
5858
*/
5959
public function testGetCopyTarget(): void
6060
{
61-
$this->assertSame('js/lib/tinymce', $this->subject->getCopyTarget());
61+
static::assertSame('js/lib/tinymce', $this->subject->getCopyTarget());
6262
}
6363
}

‎tests/unit/Copy/Unpkg/ConfigTest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function setUp(): void
3636
*/
3737
public function testGetValidatedConfig(?array $expectedResult, $packageConfig): void
3838
{
39-
$this->assertSame($expectedResult, $this->subject->getValidatedConfig($packageConfig));
39+
static::assertSame($expectedResult, $this->subject->getValidatedConfig($packageConfig));
4040
}
4141

4242
public function provideGetValidatedConfig(): Generator
@@ -152,7 +152,7 @@ public function testUnpkgName(): void
152152
{
153153
$source = '';
154154
$this->subject->setUnpkgName($source);
155-
$this->assertSame($source, $this->subject->getUnpkgName());
155+
static::assertSame($source, $this->subject->getUnpkgName());
156156
}
157157

158158
/**
@@ -163,7 +163,7 @@ public function testUnpkgVersion(): void
163163
{
164164
$source = '';
165165
$this->subject->setUnpkgVersion($source);
166-
$this->assertSame($source, $this->subject->getUnpkgVersion());
166+
static::assertSame($source, $this->subject->getUnpkgVersion());
167167
}
168168

169169
/**
@@ -174,7 +174,7 @@ public function testUnpkgSource(): void
174174
{
175175
$source = '';
176176
$this->subject->setUnpkgSource($source);
177-
$this->assertSame($source, $this->subject->getUnpkgSource());
177+
static::assertSame($source, $this->subject->getUnpkgSource());
178178
}
179179

180180
/**
@@ -185,7 +185,7 @@ public function testCopyTarget(): void
185185
{
186186
$target = '';
187187
$this->subject->setCopyTarget($target);
188-
$this->assertSame($target, $this->subject->getCopyTarget());
188+
static::assertSame($target, $this->subject->getCopyTarget());
189189
}
190190

191191
/**
@@ -196,6 +196,6 @@ public function testUnpkgFiles(): void
196196
{
197197
$files = [];
198198
$this->subject->setUnpkgFiles($files);
199-
$this->assertSame($files, $this->subject->getUnpkgFiles());
199+
static::assertSame($files, $this->subject->getUnpkgFiles());
200200
}
201201
}

‎tests/unit/Copy/Unpkg/GenericTest.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public function setUp(): void
5050
*/
5151
public function testGetUnpkgName(): void
5252
{
53-
$this->assertSame('name', $this->subject->getUnpkgName());
53+
static::assertSame('name', $this->subject->getUnpkgName());
5454
}
5555

5656
/**
@@ -66,7 +66,7 @@ public function testGetUnpkgName(): void
6666
*/
6767
public function testGetUnpkgVersion(): void
6868
{
69-
$this->assertSame('version', $this->subject->getUnpkgVersion());
69+
static::assertSame('version', $this->subject->getUnpkgVersion());
7070
}
7171

7272
/**
@@ -81,7 +81,7 @@ public function testGetUnpkgVersion(): void
8181
*/
8282
public function testGetUnpkgSource(): void
8383
{
84-
$this->assertSame('source', $this->subject->getUnpkgSource());
84+
static::assertSame('source', $this->subject->getUnpkgSource());
8585
}
8686

8787
/**
@@ -96,7 +96,7 @@ public function testGetUnpkgSource(): void
9696
*/
9797
public function testGetUnpkgFiles(): void
9898
{
99-
$this->assertSame([], $this->subject->getUnpkgFiles());
99+
static::assertSame([], $this->subject->getUnpkgFiles());
100100
}
101101

102102
/**
@@ -111,6 +111,6 @@ public function testGetUnpkgFiles(): void
111111
*/
112112
public function testGetCopyTarget(): void
113113
{
114-
$this->assertSame('target', $this->subject->getCopyTarget());
114+
static::assertSame('target', $this->subject->getCopyTarget());
115115
}
116116
}

0 commit comments

Comments
 (0)