rector: InlineIfToExplicitIfRector (#5209)

* rector: `InlineIfToExplicitIfRector`

- see https://getrector.com/rule-detail/inline-if-to-explicit-if-rector

* typo

* rector

Author: sreichel

.rector.php

@@ -47,14 +47,6 @@
             Php85\ArrayDimFetch\ArrayFirstLastRector::class,
         ])
         ->withConfiguredRule(RenameClassConstFetchRector::class, [
-            new RenameClassAndConstFetch('Zend_Log', 'EMERG', 'Monolog\Level', 'Emergency'),
-            new RenameClassAndConstFetch('Zend_Log', 'ALERT', 'Monolog\Level', 'Alert'),
-            new RenameClassAndConstFetch('Zend_Log', 'CRIT', 'Monolog\Level', 'Critical'),
-            new RenameClassAndConstFetch('Zend_Log', 'ERR', 'Monolog\Level', 'Error'),
-            new RenameClassAndConstFetch('Zend_Log', 'WARN', 'Monolog\Level', 'Warning'),
-            new RenameClassAndConstFetch('Zend_Log', 'NOTICE', 'Monolog\Level', 'Notice'),
-            new RenameClassAndConstFetch('Zend_Log', 'INFO', 'Monolog\Level', 'Info'),
-            new RenameClassAndConstFetch('Zend_Log', 'DEBUG', 'Monolog\Level', 'Debug'),
             new RenameClassAndConstFetch('Zend_Measure_Length', 'CENTIMETER', 'Mage_Core_Helper_Measure_Length', 'CENTIMETER'),
             new RenameClassAndConstFetch('Zend_Measure_Length', 'INCH', 'Mage_Core_Helper_Measure_Length', 'INCH'),
             new RenameClassAndConstFetch('Zend_Measure_Weight', 'KILOGRAM', 'Mage_Core_Helper_Measure_Weight', 'KILOGRAM'),
@@ -78,7 +70,6 @@
             CodeQuality\ClassMethod\ExplicitReturnNullRector::class, # todo: TMP
             CodeQuality\Empty_\SimplifyEmptyCheckOnEmptyArrayRector::class, # todo: TMP
             CodeQuality\Equal\UseIdenticalOverEqualWithSameTypeRector::class, # todo: TMP
-            CodeQuality\Expression\InlineIfToExplicitIfRector::class, # todo: TMP (!?!)
             CodeQuality\Expression\TernaryFalseExpressionToIfRector::class, # todo: TMP (!?!)
             CodeQuality\Foreach_\ForeachItemsAssignToEmptyArrayToAssignRector::class, # todo: TMP
             CodeQuality\Identical\SimplifyBoolIdenticalTrueRector::class, # todo: TMP

app/code/core/Mage/Paygate/Model/Authorizenet.php

@@ -1698,12 +1698,29 @@ protected function _parseTransactionDetailsXmlResponseToVarienObject(Varien_Simp
             ->setTransactionStatus((string) $responseTransactionXmlDocument->transactionStatus)
         ;
         //some additional fields:
-        isset($responseTransactionXmlDocument->responseReasonDescription) && $response->setResponseReasonDescription((string) $responseTransactionXmlDocument->responseReasonDescription);
-        isset($responseTransactionXmlDocument->FDSFilterAction)           && $response->setFdsFilterAction((string) $responseTransactionXmlDocument->FDSFilterAction);
-        isset($responseTransactionXmlDocument->FDSFilters)                && $response->setFdsFilters(serialize($responseTransactionXmlDocument->FDSFilters->asArray()));
-        isset($responseTransactionXmlDocument->transactionType)           && $response->setTransactionType((string) $responseTransactionXmlDocument->transactionType);
-        isset($responseTransactionXmlDocument->submitTimeUTC)             && $response->setSubmitTimeUtc((string) $responseTransactionXmlDocument->submitTimeUTC);
-        isset($responseTransactionXmlDocument->submitTimeLocal)           && $response->setSubmitTimeLocal((string) $responseTransactionXmlDocument->submitTimeLocal);
+        if (isset($responseTransactionXmlDocument->responseReasonDescription)) {
+            $response->setResponseReasonDescription((string) $responseTransactionXmlDocument->responseReasonDescription);
+        }
+
+        if (isset($responseTransactionXmlDocument->FDSFilterAction)) {
+            $response->setFdsFilterAction((string) $responseTransactionXmlDocument->FDSFilterAction);
+        }
+
+        if (isset($responseTransactionXmlDocument->FDSFilters)) {
+            $response->setFdsFilters(serialize($responseTransactionXmlDocument->FDSFilters->asArray()));
+        }
+
+        if (isset($responseTransactionXmlDocument->transactionType)) {
+            $response->setTransactionType((string) $responseTransactionXmlDocument->transactionType);
+        }
+
+        if (isset($responseTransactionXmlDocument->submitTimeUTC)) {
+            $response->setSubmitTimeUtc((string) $responseTransactionXmlDocument->submitTimeUTC);
+        }
+
+        if (isset($responseTransactionXmlDocument->submitTimeLocal)) {
+            $response->setSubmitTimeLocal((string) $responseTransactionXmlDocument->submitTimeLocal);
+        }
 
         return $response;
     }