~ remove deprecated revalidateCookie

Author: Hanmac

.phpstan.dist.baselines/method.childReturnType.php

@@ -291,11 +291,6 @@
     'count' => 1,
     'path' => __DIR__ . '/../app/code/core/Mage/Api/Model/Session.php',
 ];
-$ignoreErrors[] = [
-    'rawMessage' => 'Return type (void) of method Mage_Api_Model_Session::revalidateCookie() should be compatible with return type ($this(Mage_Core_Model_Session_Abstract_Varien)) of method Mage_Core_Model_Session_Abstract_Varien::revalidateCookie()',
-    'count' => 1,
-    'path' => __DIR__ . '/../app/code/core/Mage/Api/Model/Session.php',
-];
 $ignoreErrors[] = [
     'rawMessage' => 'Return type (Mage_Core_Model_Abstract) of method Mage_Api_Model_User::delete() should be covariant with return type ($this(Mage_Core_Model_Abstract)) of method Mage_Core_Model_Abstract::delete()',
     'count' => 1,

.phpstan.dist.baselines/method.deprecated.php

@@ -192,12 +192,6 @@
     'count' => 1,
     'path' => __DIR__ . '/../app/code/core/Mage/Core/Model/Layout/Update.php',
 ];
-$ignoreErrors[] = [
-    'rawMessage' => 'Call to deprecated method revalidateCookie() of class Mage_Core_Model_Session_Abstract_Varien:
-after 1.4 cookie renew moved to session start method',
-    'count' => 1,
-    'path' => __DIR__ . '/../app/code/core/Mage/Core/Model/Session/Abstract/Varien.php',
-];
 $ignoreErrors[] = [
     'rawMessage' => 'Call to deprecated method isCurrentlySecure() of class Mage_Core_Model_Store.',
     'count' => 3,

app/code/core/Mage/Api/Model/Session.php

@@ -74,15 +74,6 @@ public function setSessionId($sessId = null)
         return $this;
     }
 
-    /**
-     * @return void
-     */
-    #[Override]
-    public function revalidateCookie()
-    {
-        // In api we don't use cookies
-    }
-
     /**
      * @return bool
      */

app/code/core/Mage/Core/Model/Session/Abstract/Varien.php

@@ -269,16 +269,6 @@ public function getCookie()
         return Mage::getSingleton('core/cookie');
     }
 
-    /**
-     * Revalidate cookie
-     * @return $this
-     */
-    #[Deprecated(message: 'after 1.4 cookie renew moved to session start method')]
-    public function revalidateCookie()
-    {
-        return $this;
-    }
-
     /**
      * Init session with namespace
      *
@@ -300,7 +290,6 @@ public function init($namespace, $sessionName = null)
         $this->_data = &$_SESSION[$namespace];
 
         $this->validate();
-        $this->revalidateCookie();
 
         return $this;
     }