Make all PHPUnit data providers static (PHPUnit 10+ compatibility) (#5486)

* Initial plan

* Make all PHPUnit data provider methods static for PHPUnit 10+ compatibility

Agent-Logs-Url: https://github.com/OpenMage/magento-lts/sessions/0ed20cbc-5be3-48bb-b912-3c3d652e7126

Co-authored-by: sreichel <5022236+sreichel@users.noreply.github.com>

* Fix $this-> calls in static data provider methods

Agent-Logs-Url: https://github.com/OpenMage/magento-lts/sessions/0ed20cbc-5be3-48bb-b912-3c3d652e7126

Co-authored-by: sreichel <5022236+sreichel@users.noreply.github.com>

* Fix staticMethod.dynamicCall: use self:: instead of $this-> for static getTestString() in ImagesTest

Agent-Logs-Url: https://github.com/OpenMage/magento-lts/sessions/9fa5d994-5e8d-4668-9088-7b9d5bdef1e5

Co-authored-by: sreichel <5022236+sreichel@users.noreply.github.com>

* Update copilot-instructions.md with PHPUnit testing standards learned from PR

Agent-Logs-Url: https://github.com/OpenMage/magento-lts/sessions/f69826d6-8f46-432e-bc98-5ef558d758c4

Co-authored-by: sreichel <5022236+sreichel@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sreichel <5022236+sreichel@users.noreply.github.com>
Co-authored-by: Sven Reichel <github-sr@hotmail.com>

Author: Copilot

.github/copilot-instructions.md

@@ -60,6 +60,16 @@ This project aims to provide a stable and secure version of Magento 1.x, with on
 - Use strict comparisons (`===` and `!==`) instead of loose comparisons (`==` and `!=`) in new code.
 - Avoid using empty() function in new code. Use explicit checks instead.
 
+## PHPUnit Testing Standards
+
+- All PHPUnit data provider methods must be declared `public static` (required by PHPUnit 10+).
+- Data provider methods follow the naming convention `provide*` (e.g., `provideValidateData`).
+- Inside `static` data provider methods, never use `$this->`. Use `static::` to call other methods from traits or `self::` for calls in the same class.
+- When a helper method is made `static` (e.g., a method used inside a data provider), all callers — including regular (non-static) test methods — must also be updated from `$this->method()` to `self::method()`.
+- PHPStan is configured with `dynamicCallOnStaticMethod: true` in `.phpstan.dist.neon`. Never call a static method via `$this->` — it will cause a `staticMethod.dynamicCall` error.
+- Data provider trait helper methods (e.g., `getAllBlockClasses`, `getTestString`) that are consumed by static data providers must themselves be declared `static`.
+- Test class setup should use `setUpBeforeClass()` for shared static state and `setUp()` for per-test instance state.
+
 ## UI guidelines
 
 - Do not use prototype libraries. Use modern JavaScript (ES6+) features and libraries.

tests/unit/Base/ClassLoadingTest.php

@@ -24,7 +24,7 @@ public function testClassExists(bool $expectedResult, string $class): void
         self::assertSame($expectedResult, class_exists($class));
     }
 
-    public function provideClassExistsData(): Generator
+    public static function provideClassExistsData(): Generator
     {
         yield 'class exists #1' => [
             true,

tests/unit/Base/DefaultConfigTest.php

@@ -28,7 +28,7 @@ public function testGetStoreConfig(string $expectedResult, string $path, null|bo
     }
 
 
-    public function provideGetStoreConfig(): Generator
+    public static function provideGetStoreConfig(): Generator
     {
         yield Mage_Adminhtml_Helper_Dashboard_Data::XML_PATH_ENABLE_CHARTS => [
             '1',

tests/unit/Base/XmlFileLoadingTest.php

@@ -43,7 +43,7 @@ public function testXmlReaderIsValid(string $filepath): void
         self::assertTrue($xml->isValid());
     }
 
-    public function provideXmlFiles(): Generator
+    public static function provideXmlFiles(): Generator
     {
         $root = realpath(__DIR__ . '/../../../') . '/';
 

tests/unit/Error/ProcessorTest.php

@@ -45,7 +45,7 @@ public function testGetHostUrl(string $expectedResult, array $serverVars): void
         self::assertSame($expectedResult, $this->subject->getHostUrl());
     }
 
-    public function provideGetHostUrl(): Generator
+    public static function provideGetHostUrl(): Generator
     {
         yield 'default' => [
             'http://localhost',

tests/unit/Mage/Cms/Helper/Wysiwyg/ImagesTest.php

@@ -58,15 +58,15 @@ public function testGetStorage(): void
      */
     public function testIdEncode(): void
     {
-        self::assertIsString(self::$subject->idEncode($this->getTestString()));
+        self::assertIsString(self::$subject->idEncode(self::getTestString()));
     }
 
     /**
      * @group Helper
      */
     public function testIdDecode(): void
     {
-        self::assertIsString(self::$subject->idDecode($this->getTestString()));
+        self::assertIsString(self::$subject->idDecode(self::getTestString()));
     }
 
     /**

tests/unit/Traits/DataProvider/Base/BoolTrait.php

@@ -15,7 +15,7 @@
 
 trait BoolTrait
 {
-    public function provideBool(): Generator
+    public static function provideBool(): Generator
     {
         yield 'true' => [
             true,

tests/unit/Traits/DataProvider/Base/IntOrNullTrait.php

@@ -15,7 +15,7 @@
 
 trait IntOrNullTrait
 {
-    public function provideIntOrNull(): Generator
+    public static function provideIntOrNull(): Generator
     {
         yield 'null' => [
             null,

tests/unit/Traits/DataProvider/Base/ModulesTrait.php

@@ -21,7 +21,7 @@ trait ModulesTrait
     /**
      * @return array<int, string>
      */
-    final public function provideAllModules(): array
+    final public static function provideAllModules(): array
     {
         return [
             'Mage_Admin',
@@ -86,10 +86,10 @@ final public function provideAllModules(): array
         ];
     }
 
-    public function provideAllActiveModules(): array
+    public static function provideAllActiveModules(): array
     {
         $disabled   = static::$disabledModules;
-        $modules    = $this->provideAllModules();
+        $modules    = static::provideAllModules();
 
         foreach ($modules as $idx => $module) {
             if (in_array($module, $disabled)) {

tests/unit/Traits/DataProvider/Base/NumericStringTrait.php

@@ -15,7 +15,7 @@
 
 trait NumericStringTrait
 {
-    public function provideNumericString(): Generator
+    public static function provideNumericString(): Generator
     {
         yield 'zero' => [
             '0',