Refund makes an order go back into processing?

[fballiano]

Hi everybody,
I've been reported something weird happening on a customer's project, when refunding the order goes back to processing state. I've been checking the thing and I've found that https://github.com/OpenMage/magento-lts/blob/Flyingmana-patch-1/app/code/core/Mage/Sales/Model/Order/Payment.php (line 725) is actally doing exactly that, during the refund method it resets the order state to processing.

Does it make sense to you? Am I missing something? Cause to me that's not the right behaviour.
Thanks everybody!

[justinbeaty]

That would seem to not be the right behavior. I asked one of my store owners and she said she's never seen that happen though. She always checked to make sure it says closed. But she will keep an eye out to make sure the order wouldn't get shipped again.

Edit: git blame says that's from version 1.4.0. Maybe there is something else that sets it to complete, like a sales_order_payment_refund observer?

[elidrissidev]

Yes it does go into processing state, but it should go to closed state directly after as you can see from the snippet below the method _checkStatewhich is called before saving the order, so maybe one of the conditions fails (Line 2383):

magento-lts/app/code/core/Mage/Sales/Model/Order.php

Lines 2359 to 2392 in 8b9bfae

	protected function _checkState()
	{
	if (!$this->getId()) {
	return $this;
	}
	$userNotification = $this->hasCustomerNoteNotify() ? $this->getCustomerNoteNotify() : null;
	if (!$this->isCanceled()
	&& !$this->canUnhold()
	&& !$this->canInvoice()
	&& !$this->canShip()) {
	if (0 == $this->getBaseGrandTotal() || $this->canCreditmemo()) {
	if ($this->getState() !== self::STATE_COMPLETE) {
	$this->_setState(self::STATE_COMPLETE, true, '', $userNotification);
	}
	} /**
	* Order can be closed just in case when we have refunded amount.
	* In case of "0" grand total order checking ForcedCanCreditmemo flag
	*/
	elseif (floatval($this->getTotalRefunded()) || (!$this->getTotalRefunded()
	&& $this->hasForcedCanCreditmemo())
	) {
	if ($this->getState() !== self::STATE_CLOSED) {
	$this->_setState(self::STATE_CLOSED, true, '', $userNotification);
	}
	}
	}
	if ($this->getState() == self::STATE_NEW && $this->getIsInProcess()) {
	$this->setState(self::STATE_PROCESSING, true, '', $userNotification);
	}
	return $this;
	}

Here is a test I did in a clean installation:

Let me know if it helps.