Annoying bug: Add to Wishlist is not working properly

[addison74]

OpenMage v20.0.6

To reproduce this annoying issue you should have created before: a category, a product associated to the category, a customer account.

Do not login into the account!

In frontend visit as guest the created category and press [Add to Wishlist]. You will be redirected as usual to path /customer/account/login/. Fill up the email and password and press [Login].

Instead of getting into the customer account and see the confirmation that the product was added to wishlist you will get the category page with the following error message: "Please add product to wishlist again". See the image bellow:

Please note you are logged in already. By pressing again [Add to Wishlist] the product will be added to wishlist and you are now visiting the customer page which is the correct behavior. See the image bellow:

I did not check this issue with other versions of Magento but I suppose it is coming from the changes the team made when added form keys for Add Wishlist. I will make time to install a fresh Magento 1.9.4.3 which has no form keys form Add to Cart, Add to Wishlist and Add to Compare and see if I confirm it again.

As it is now this issue creates confusion and becomes really annoying for a visitor.

[addison74]

I checked the part of the code which is responsible for the error: /app/code/core/Mage/Wishlist/controllers/IndexController.php

public function indexAction()
    {
        if (!$this->_getWishlist()) {
            return $this->norouteAction();
        }
        $this->loadLayout();

        if ($this->_isFormKeyEnabled() && strpos($this->_getRefererUrl(), 'login')) {
            Mage::getSingleton('core/session')->addError(Mage::helper('wishlist')->__(
                'Please add product to wishlist again.'
            ));
            return $this->_redirectUrl(Mage::getSingleton('customer/session')->getBeforeWishlistUrl());
        }

Look at that if statement. Running the code these two variables have the following values:

$this->_isFormKeyEnabled() = bool(true)
strpos($this->_getRefererUrl(), 'login') = int(40)

Based on these values the evaluation is always true. Magento is doing the job just of part of it creating a new logged session but instead of accessing the customer account and adding the product to the wishlist it is coming back to the page from where the request came.

I will do more tests by changing in one template AddToWishListUrlCustom to AddToWishListUrl for backward compatibility. If it is not working again I will replace the core file with one from a previous version to see what is happening.

[addison74]

In Magento Team did a change in the Index controller in 1.9.4.3. Making a diff between OpenMage 20.0.6 and Magento 1.9.4.2 the if statement from above was introduced. By commenting the lines 144 - 149 in /app/code/core/Mage/Wishlist/controllers/IndexController.php I was able to use this feature as usual without any error. All templates remained the same as before with the modifications introduced in 1.9.4.3. Here is an example from a template:

[...]
<?php $_params = $this->escapeHtml(json_encode(array('form_key' => $this->getFormKey()))); ?>
[...]
<?php if ($this->helper('wishlist')->isAllow()) : ?>
<?php $_wishlistUrl = $this->getAddToWishlistUrlCustom($_product, false); ?>
<li>
<a href="#"
    data-url="<?php echo $_wishlistUrl ?>"
    data-params="<?php echo $_params ?>"
    class="link-wishlist"
    onclick="customFormSubmit('<?php echo $_wishlistUrl ?>', '<?php echo $_params ?>', 'post')">
    <?php echo $this->__('Add to Wishlist') ?>
</a>
</li>

Let's evaluate a little the code from the controller. There is no doubt $this->_isFormKeyEnabled() value is always true. If I navigate as I guest by pressing [Add to Wishlist] button I will be redirected to login page (/customer/account/login/) . The URL contains "login" string and strpos function will return a positive value. In this way the if evaluation will always be true. The guest will login but will have to add again the product which is annoying and a bug into the code.

I did a modification by changing login string to login1. I was able to login into my account and see the item added to the wishlist. No errors and this is the same like commenting the if statement. If anyone has some time please evaluate what is the impact of commenting the code. At least with this modification we will solve the issue.

To solve this issue I see the following scenarios:

1. Commenting/Removing the if statement and returning to Magento 1.9.4.2.
2. Modify login word in the path (same result as 1 but a dead piece of code).
3. Change the error message from "Please add product to wishlist again." to "You could not add products to wishlish as guest. You are logged in please add the product again."

Any insides are welcomed.

[sreichel]

@addison74 I'd remove "bug confirmed" and close.

It looks like it is wanted - to refresh the formkey. I dont think its neccessaary to change to message.

[addison74]

If a Guest visitor wants to add a product to the wishlist, he should be informed about the whole procedure through a message. First, he would be told that he will be redirected to the login page, and after creating/accessing the account to add the product. If you don't want the redirecting, a message can be displayed that you must log into the account to be able to add products to the wishlisht, I think this would be much better.

As a personal opinion, the message displayed after logging in is very confusing "Please add product to wishlist again". I just added the product then I logged in and why do I need to add it again? I mean, should I go back and repeat the same steps, but in what page I added it? Maybe a link to go back to the page from where I started it should be the solution, like Magento Team did after adding a product in the wishlist, the displayed message is "Product ABC has been added to your wishlist. Click [here] to continue shopping."

Also the message "Please add product to wishlist again" must be change to "Please add the product to the wishlisht again", accompanied by an explanation.

[sreichel]

Move to discussions?

[addison74]

I would not move it to the Discussions section. Let's analyze the feature to add products to the Wish List for Guest visitors.

1. Click on the "Add to Wishlist" link no matter where the link is.
2. Redirect to create/login page.
3. Create create/login (you have to wait if administrator approves the account)
4. Error message "Please add the product to the wishlist again".
5. Go back in the browser history to find the page from where the whole process started. What do we do if the product was in a carousel of random products?

Step 5 is really annoying, based on an unprofessional approach. I should search for the product or use the browser history. How do we solve this issue?

Solution 1: When I click the "Add to Wishlist" link, I should see a warning message on the same page like this "Please log into your customer account to add products to the Wish List. If you don't have one please create it.". In this message I will include also the link to /customer/account. In my opinion redirection in a few seconds is not an option.

Solution 2: When I click the "Add to Wishlist" link, I am redirected to the Customer Account page (create / login page). I create/login into my customer account then I should be redirected to the page where the whole process started. A warning message should inform me to add the product to the wish list. To solve the problem with the random product, I should keep the added product "somewhere" (session, ...) then redirect to its page after logging into the account.

[sreichel]

Solution 2: When I click the "Add to Wishlist" link, I am redirected to the Customer Account page (create / login page). I create/login into my customer account then I should be redirected to the page where the whole process started.

Can you retry? This happens for me. After login i get redirected to the page where i wanted to add the product to wishlist.

[addison74]

@sreichel - I am using a fresh install, OpenMage v20 the latest with the Magento Sample Data pack. The environment is as usual based on DDEV and PHP 8.4.

In order to see this bug in action clear your browser cache or disable it (better). Visit this category first https://openmage.ddev.site/women/tops-blouses.html then add "Elizabeth Knit Top" to the wish list. Next you will get this page https://openmage.ddev.site/customer/account/login/, use your credentials. You will be redirected to the category seeing the error message "Please add product to the wishlist again". Except the message which is not explanatory and the missing "the" in the phrase, all is good. Let's go further.

Category Page
Logout from your customer account then access this category https://openmage.ddev.site/home-decor/electronics.html. Follow the same steps as above adding this time MADISON LX2200. Once you login into the customer account your will be redirected to the "Top and Blouses" category. This is wrong.

Product Page
Logout from your account then access this product page https://openmage.ddev.site/home-decor/electronics/madison-lx2200.html. Add it to the Wish List. Once you login you will be redirected again to "Top and Blouses" category. This is wrong as well.

Please note I did not check what is happening for other places in the Frontend, like CMS pages (Home), Cart page, Blocks in pages where Add to Wishlist is available.

Personal comments

1. The error message must be more explicit, why you have to add again the product. Maybe when getting the login page we should see a warning why this is happening, prepare for redirecting and adding the product again.
2. The redirects are not working properly.

[sreichel]

Thanks. Will check it later.