Allow valid TLDs to be configurable or allow that no validation takes place

[pquerner]

Description (*)

During the check of the hostname part of an email address in \Zend_Validate_EmailAddress::_validateHostnamePart, the Top Level Domain (TLD) will be validated in \Zend_Validate_Hostname::isValid.
The TLD is finally tested against a hardcoded values from \Zend_Validate_Hostname::$_validIdns.

For reasons unknown to me, in a project the part ->setValidateTld(false) is added before the isValid call in \Zend_Validate_EmailAddress::_validateHostnamePart.

I only checked validation of the email during customer registration. It can be that this part was needed for something else, I am not sure yet.
I checked against 1.9.4.5 and the list of TLD seems to be in order.

If $this->_options['tld'] is true (controllable by setValidateTld), the TLD matching will take place, otherwise not.

Expected behavior (*)

I have no expectation, other than to perhaps allow from the backend to control to whether or not validate parts of the email or not.
Or maybe (partially) control the list of TLDs in case new TLDs get added - and ZF1future doesnt get updated (unlikely)

Benefits

As I have not established a use-case for this feature request, and I cannot grasp the use-case myself, I feel like the benefits are very minor. Its only created as its maybe worth a discussion.

Also, reports from the Discord said thats "impossible" (or rather more difficult) for Zend classes to be overwritten since ZF1future introduction. A Zend class can no longer simply be put in the app/local codepool for overwrites.
Thats just a side-note, in case a more dramatic use case arises to control parts of how Zend behaves. And maybe more projects exists that changed behaviour from Zend.

Additional information

This feature request was created since flyingmana asked for it on Discord.

[fballiano]

@pquerner are you still having the problem? since I remember something was updated regarding emails but i'm not sure.

[pquerner]

New tld come out all the time (it feels like), and the hardcoded tlds will not stand the test of time. So we are dependend on zend(future) or openmage does it some place else.

So yea, its still an issue. Either disable validation (bad-ish) or control the tld list manually. Or resort to maybe some API which will fetch the tlds periodically and adjust. (If one API exists)

[kiatng]

Ref Shardj/zf1-future#72

[sreichel]

Lets go for it?

[pquerner]

Is this something to put into https://github.com/OpenMage/composer-patches as a composer patch?

[sreichel]

If you have to change Zend_xyz, yes. Maybe add a PR to https://github.com/Shardj/zf1-future.

[pquerner]

The plan in my head is currently something like:

1. Find API to get all current TLDs of the world
2. Periodically update the list
3. Put the list in a new table
4. Add grid to that table to openmage backend
5. That grid controls which domains are safelisted or on the blocklist. Maybe both?
6. That list of safelist or blocklist domains is being tested, instead of the hardcoded domains list during validation (\Zend_Validate_Hostname::$_validIdns)

All of this is by default off and must be enabled first. When it is turned off, a list of the \Zend_Validate_Hostname::$_validIdns is being displayed in the backend (in the grid) instead, with no ability to change it.

Using a API ensures the list of TLD is being kept up-to-date with no or small oversight. But I don't know if such API exist or if it is free.

[sreichel]

Mabey its easier to frequently check if there is a new version of https://data.iana.org/TLD/tlds-alpha-by-domain.txt (#3450 (comment))