Searching the code there are still some `strftimes` present:

[sreichel]

          Searching the code there are still some `strftimes` present:

Originally posted by @boesbo in #2934 (comment)

[kiatng]

It's not so straight forward to replace strftime(), which is from C lib, which format spec is also used in js\calendar\calendar.js.
We can consider this: https://github.com/alphp/strftime

[boesbo]

It's not so straight forward to replace strftime(), which is from C lib, which format spec is also used in js\calendar\calendar.js. We can consider this: https://github.com/alphp/strftime

I think it is not necessary to add this library, but simply use the date function, with some precautions. I have little time now, but if there is no PR, as soon as I can I will do mine

[sreichel]

We can consider to replace all date functions with https://github.com/briannesbitt/Carbon

[Hanmac]

What should we do about this?

magento-lts/app/code/core/Mage/Adminhtml/Model/System/Config/Source/Date/Short.php

Lines 21 to 33 in 593ce77

	class Mage_Adminhtml_Model_System_Config_Source_Date_Short
	{
	public function toOptionArray()
	{
	$arr = [];
	$arr[] = ['label' => '', 'value' => ''];
	$arr[] = ['label' => strftime('MM/DD/YY (%m/%d/%y)'), 'value' => '%m/%d/%y'];
	$arr[] = ['label' => strftime('MM/DD/YYYY (%m/%d/%Y)'), 'value' => '%m/%d/%Y'];
	$arr[] = ['label' => strftime('DD/MM/YY (%d/%m/%y)'), 'value' => '%d/%m/%y'];
	$arr[] = ['label' => strftime('DD/MM/YYYY (%d/%m/%Y)'), 'value' => '%d/%m/%Y'];
	return $arr;
	}
	}

The config source isn't used in Magento, and while we could change the label to not rely on strftime anymore,
we probably can't change the value in case the source is used somewhere else?

just mark the class as deprecated?

[kiatng]

What should we do about this?

Mark it @deprecated and delete the file later. The output is:

 array(5) {
  [0] => array(2) {
    ["label"] => string(0) ""
    ["value"] => string(0) ""
  }
  [1] => array(2) {
    ["label"] => string(19) "MM/DD/YY (12/06/24)"
    ["value"] => string(8) "%m/%d/%y"
  }
  [2] => array(2) {
    ["label"] => string(23) "MM/DD/YYYY (12/06/2024)"
    ["value"] => string(8) "%m/%d/%Y"
  }
  [3] => array(2) {
    ["label"] => string(19) "DD/MM/YY (06/12/24)"
    ["value"] => string(8) "%d/%m/%y"
  }
  [4] => array(2) {
    ["label"] => string(23) "DD/MM/YYYY (06/12/2024)"
    ["value"] => string(8) "%d/%m/%Y"
  }
}

Which looks like the options in a dropdown for configuring date formatting, which is specific for strftime(). So, if we mark it as deprecated, there is no need to change anything. We can delete it when PHP throws an error.

[Hanmac]

The last use of strftime directly is this one:

magento-lts/app/code/core/Mage/Core/Block/Html/Date.php

Lines 85 to 92 in cbd47bc

	public function getEscapedValue($index = null)
	{
	if ($this->getFormat() && $this->getValue()) {
	return strftime($this->getFormat(), strtotime($this->getValue()));
	}
	return htmlspecialchars($this->getValue());
	}

but I don't see it being using anywhere

[sreichel]

but I don't see it being using anywhere

Think its safe to replace with date()

(1426165)

[Hanmac]

@sreichel yeah, probably

but I mean it more like it couldn't find a place where core/html_date->getEscapedValue is called

there are some places that use this block with format:

• Mage_Catalog_Block_Product_View_Options_Type_Date
  setFormat(Mage::app()->getLocale()->getDateStrFormat(Mage_Core_Model_Locale::FORMAT_TYPE_SHORT))
• Mage_CatalogSearch_Block_Advanced_Form
  ->setFormat('%m/%d/%y')

but these places use the calendar ifFormat, not for getEscapedValue