Skip to content

Adminhtml: improved info for order sent status #4623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

sreichel
Copy link
Contributor

Description (*)

See #4620 (comment)

Fixed Issues (if relevant)

@github-actions github-actions bot added Template : admin Relates to admin template Component: Sales Relates to Mage_Sales Component: Adminhtml Relates to Mage_Adminhtml translations Relates to app/locale labels Feb 10, 2025
@sreichel sreichel requested a review from addison74 February 10, 2025 15:19
@sreichel sreichel added this to the 20.13.0 milestone Feb 10, 2025
@sreichel sreichel closed this Feb 10, 2025
@OpenMage OpenMage deleted a comment from sreichel Feb 12, 2025
@OpenMage OpenMage deleted a comment from sreichel Feb 12, 2025
@OpenMage OpenMage deleted a comment from sreichel Feb 12, 2025
@OpenMage OpenMage deleted a comment from sreichel Feb 12, 2025
@OpenMage OpenMage deleted a comment from sreichel Feb 12, 2025
@OpenMage OpenMage deleted a comment from sreichel Feb 12, 2025
@sreichel sreichel modified the milestones: 20.13.0, 20.14.0 Mar 7, 2025
@sreichel sreichel reopened this Mar 7, 2025
@sreichel sreichel requested a review from kiatng March 12, 2025 23:57
kiatng
kiatng previously approved these changes Mar 14, 2025
@addison74
Copy link
Contributor

This PR needs changes before merging.

@sreichel sreichel removed this from the 20.14.0 milestone Mar 14, 2025
@sreichel
Copy link
Contributor Author

For change wordings please make suggestions via review (select lines & ctrl+h).

@@ -52,6 +47,10 @@ $orderStoreDate = $this->formatDate($_order->getCreatedAtStoreDate(), 'medium',
<td class="label"><label><?php echo Mage::helper('sales')->__('Order Status') ?></label></td>
<td class="value"><strong><span id="order_status"><?php echo $_order->getStatusLabel() ?></span></strong></td>
</tr>
<tr>
<td class="label"><label><?php echo Mage::helper('sales')->__('Order Confirmation Email') ?></label></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a two-word label. These two variants are more appropriate.

Variant 1

Suggested change
<td class="label"><label><?php echo Mage::helper('sales')->__('Order Confirmation Email') ?></label></td>
<td class="label"><label><?php echo Mage::helper('sales')->__('Email Confirmation') ?></label></td>

Variant 2

Suggested change
<td class="label"><label><?php echo Mage::helper('sales')->__('Order Confirmation Email') ?></label></td>
<td class="label"><label><?php echo Mage::helper('sales')->__('Order Confirmation') ?></label></td>

I asked Copilot and Chatgpt for their opinions, both argued that "Order Confirmation" is more appropriate, as it covers confirmations sent by email, SMS, phone. Personally, I would prefer Email Confirmation because it specifies the confirmation method available in OpenMage.

If we are analyzing the label names in that block that obviously refer to the order, then the word "Order" should be removed from the "Order Date" and "Order Status" forms. Here is what it would look like in my opinion

order_block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree on that.

  • "Email" suffix ... its no SMS, fax, ...
  • "Order" prefix ... this block is displayed for orders, invoices, shippings ... so it could be missleading w/o it.

I really thought about how to name it - and it was also named "order confirmation email" before.

@addison74
Copy link
Contributor

Regarding the positioning of the copy icon, the issue is still visible in the legacy theme.

copy_icon

@sreichel sreichel closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Sales Relates to Mage_Sales enhancement Template : admin Relates to admin template translations Relates to app/locale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy feature in the view order page
3 participants