[BUG] Taxvat, Dob, and Gender Attributes Ignore WEBSITE Scope and Only Work on GLOBAL Scope

[empiricompany]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

The Taxvat attribute (along with other account-level attributes such as dob and gender) only works at the GLOBAL scope and does not respect custom values set at the WEBSITE scope.

For example, if Taxvat is disabled GLOBALLY but required for a specific WEBSITE, it does not appear on the Account Edit form.

The issue comes from app\code\core\Mage\Customer\Block\Widget\Taxvat.php

class Mage_Customer_Block_Widget_Taxvat extends Mage_Customer_Block_Widget_Abstract
{
    public function _construct()
    {
        parent::_construct();
        $this->setTemplate('customer/widget/taxvat.phtml');
    }

    /**
     * @return bool
     */
    public function isEnabled()
    {
        return (bool)Mage::getStoreConfig('customer/address/taxvat_show'); <==== possible fix read from config
        return (bool)$this->_getAttribute('taxvat')->getIsVisible();
    }

    /**
     * @return bool
     */
    public function isRequired()
    {
        return (bool)Mage::getStoreConfig('customer/address/taxvat_show') == 'req'; <==== possible fix read from config
        return (bool)$this->_getAttribute('taxvat')->getIsRequired();
    }

    /**
     * @return Mage_Customer_Model_Customer
     */
    public function getCustomer()
    {
        return Mage::getSingleton('customer/session')->getCustomer();
    }
}

Called from various templates such as app\design\frontend\rwd\default\template\customer\form\edit.phtml

<?php $_dob = $this->getLayout()->createBlock('customer/widget_dob') ?>
<?php if ($_dob->isEnabled()): ?>
    <li><?php echo $_dob->setDate($this->getCustomer()->getDob())->toHtml() ?></li>
<?php endif ?>
<?php $_taxvat = $this->getLayout()->createBlock('customer/widget_taxvat') ?>
<?php if ($_taxvat->isEnabled()): ?>
    <li><?php echo $_taxvat->setTaxvat($this->getCustomer()->getTaxvat())->toHtml() ?></li>
<?php endif ?>
<?php $_gender = $this->getLayout()->createBlock('customer/widget_gender') ?>
<?php if ($_gender->isEnabled()): ?>
    <li><?php echo $_gender->setGender($this->getCustomer()->getGender())->toHtml() ?></li>
<?php endif ?>

Expected Behavior

The Taxvat, Dob, and gender attributes should respect the WEBSITE scope configuration.
If an attribute is disabled GLOBALLY but enabled for a specific WEBSITE, it should be visible and functional on the Account Edit form accordingly.

Steps To Reproduce

1. Go to Admin Panel → Stores → Configuration → Customers → Customer Configuration → Name and Address Options.
2. Set Taxvat to Disabled at the GLOBAL scope.
3. Switch to a specific WEBSITE scope and set Taxvat to Required.
4. Save the configuration and clear the cache.
5. Log in to the storefront as a customer on the WEBSITE where Taxvat was set to Required, then navigate to Account Edit.

Issue: The Taxvat field does not appear, despite being set as Required for that WEBSITE.

Environment

- OpenMage:20.12.0
- php:8.2.2

Anything else?

No response

[kiatng]

I'm not sure how to fix this, but the proper way should be at the model level. The values for the fields is_visible and is_required for the 3 attributes are set in the config, so they should be read from the table core_config_data and not from the eav tables. If this is the case, then it seems these should be deprecated:

• file app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Customer/Show/Customer.php

• magento-lts/app/code/core/Mage/Eav/Model/Attribute.php

  Lines 137 to 141 in 8fd1faa

  	protected function _getScopeValue($key)
  	{
  	$scopeKey = sprintf('scope_%s', $key);
  	return $this->getData($scopeKey) ?? $this->getData($key);
  	}

This is because the values for scope_is_visible and scope_is_required are never set and are always null

[empiricompany]

@kiatng yes, but I don't know if it could alter the behavior in other parts of the code

[kiatng]

Well, there should be only one source of truth, which is the configurations per website.