[BUG] PHP 8.5 issues

[addison74]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

DDEV now allows using PHP 8.5 ORC3. I changed the php version today in the config.yaml file and after restarting I got a lot of errors for both Frontend and Backend.

Here is one for the Backend:

Deprecated functionality: Constant PDO::MYSQL_ATTR_USE_BUFFERED_QUERY is deprecated since 8.5, use Pdo\Mysql::ATTR_USE_BUFFERED_QUERY instead  in /var/www/html/lib/Varien/Db/Adapter/Pdo/Mysql.php on line 398

#0 /var/www/html/lib/Varien/Db/Adapter/Pdo/Mysql.php(398): mageCoreErrorHandler()
#1 /var/www/html/vendor/shardj/zf1-future/library/Zend/Db/Adapter/Abstract.php(460): Varien_Db_Adapter_Pdo_Mysql->_connect()
#2 /var/www/html/vendor/shardj/zf1-future/library/Zend/Db/Adapter/Pdo/Abstract.php(267): Zend_Db_Adapter_Abstract->query()
#3 /var/www/html/lib/Varien/Db/Adapter/Pdo/Mysql.php(501): Zend_Db_Adapter_Pdo_Abstract->query()
#4 /var/www/html/app/code/core/Mage/Core/Model/Resource.php(173): Varien_Db_Adapter_Pdo_Mysql->query()
#5 /var/www/html/app/code/core/Mage/Core/Model/Resource.php(102): Mage_Core_Model_Resource->_newConnection()
#6 /var/www/html/app/code/core/Mage/Core/Model/Resource/Setup.php(132): Mage_Core_Model_Resource->getConnection()
#7 /var/www/html/app/code/core/Mage/Core/Model/Resource/Setup.php(230): Mage_Core_Model_Resource_Setup->__construct()
#8 /var/www/html/app/code/core/Mage/Core/Model/App.php(435): Mage_Core_Model_Resource_Setup::applyAllUpdates()
#9 /var/www/html/app/code/core/Mage/Core/Model/App.php(340): Mage_Core_Model_App->_initModules()
#10 /var/www/html/app/Mage.php(763): Mage_Core_Model_App->run()
#11 /var/www/html/index.php(51): Mage::run()
#12 {main}

Here is one for the Frontend

Deprecated:  Case statements followed by a semicolon (;) are deprecated, use a colon (:) instead in /var/www/html/vendor/react/promise/src/functions.php on line 300

Deprecated:  Case statements followed by a semicolon (;) are deprecated, use a colon (:) instead in /var/www/html/vendor/phpseclib/mcrypt_compat/lib/mcrypt.php on line 588

Deprecated functionality: Non-canonical cast (boolean) is deprecated, use the (bool) cast instead  in /var/www/html/vendor/shardj/zf1-future/library/Zend/Db/Profiler.php on line 138

#0 /var/www/html/vendor/composer/ClassLoader.php(576): mageCoreErrorHandler()
#1 /var/www/html/vendor/composer/ClassLoader.php(576): include()
#2 /var/www/html/vendor/composer/ClassLoader.php(427): {closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}()
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#4 /var/www/html/vendor/shardj/zf1-future/library/Zend/Db/Adapter/Abstract.php(394): class_exists()
#5 /var/www/html/vendor/shardj/zf1-future/library/Zend/Db/Adapter/Abstract.php(272): Zend_Db_Adapter_Abstract->setProfiler()
#6 /var/www/html/app/code/core/Mage/Core/Model/Resource.php(169): Zend_Db_Adapter_Abstract->__construct()
#7 /var/www/html/app/code/core/Mage/Core/Model/Resource.php(102): Mage_Core_Model_Resource->_newConnection()
#8 /var/www/html/app/code/core/Mage/Core/Model/Resource/Setup.php(132): Mage_Core_Model_Resource->getConnection()
#9 /var/www/html/app/code/core/Mage/Core/Model/Resource/Setup.php(230): Mage_Core_Model_Resource_Setup->__construct()
#10 /var/www/html/app/code/core/Mage/Core/Model/App.php(435): Mage_Core_Model_Resource_Setup::applyAllUpdates()
#11 /var/www/html/app/code/core/Mage/Core/Model/App.php(340): Mage_Core_Model_App->_initModules()
#12 /var/www/html/app/Mage.php(763): Mage_Core_Model_App->run()
#13 /var/www/html/index.php(51): Mage::run()
#14 {main}

Expected Behavior

PHP 8.5 compatibility, no errors

Steps To Reproduce

Just change the PHP version to 8.5 and load the Frontend/Backend.

Environment

- OpenMage: latest
- php: 8.5

Anything else?

No response

[sreichel]

Thinkt that should be fixed in zf1. Can you report there?

[addison74]

I reported to small issues in the ZF1-Future repository.

For the one in our repository

$this->_connection->setAttribute(PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, true);

becomes

$this->_connection->setAttribute(PDO\MYSQL::ATTR_USE_BUFFERED_QUERY, true);

[addison74]

More issues in /lib/Varien/Object.php lines: 245-246

$this->_data[$key] = $value;
if (isset($this->_syncFieldsMap[$key])) {

must be changed into

$this->_data[$key ?? ''] = $value;
if (isset($this->_syncFieldsMap[$key ?? ''])) {

in /lib/Varien/Db/Adapter/Pdo/Mysql.php line 3142

} elseif (array_key_exists($key, $conditionKeyMap)) {

must be changed into

} elseif (array_key_exists($key ?? '', $conditionKeyMap)) {

After correcting these errors I got this

Using null as an array offset is deprecated, use an empty string instead

#0 /var/www/html/app/Mage.php(554): Mage_Core_Model_Config->getModelInstance()
#1 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(653): Mage::getModel()
#2 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(1668): Mage_Eav_Model_Entity_Abstract->walkAttributes()
#3 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(970): Mage_Eav_Model_Entity_Abstract->_afterLoad()
#4 /var/www/html/app/code/core/Mage/Catalog/Model/Resource/Abstract.php(749): Mage_Eav_Model_Entity_Abstract->load()
#5 /var/www/html/app/code/core/Mage/Core/Model/Abstract.php(290): Mage_Catalog_Model_Resource_Abstract->load()
#6 /var/www/html/app/code/core/Mage/Catalog/Helper/Product.php(336): Mage_Core_Model_Abstract->load()
#7 /var/www/html/app/code/core/Mage/Catalog/Helper/Product/View.php(114): Mage_Catalog_Helper_Product->initProduct()
#8 /var/www/html/app/code/core/Mage/Catalog/controllers/ProductController.php(118): Mage_Catalog_Helper_Product_View->prepareAndRender()
#9 /var/www/html/app/code/core/Mage/Core/Controller/Varien/Action.php(434): Mage_Catalog_ProductController->viewAction()
#10 /var/www/html/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(261): Mage_Core_Controller_Varien_Action->dispatch()
#11 /var/www/html/app/code/core/Mage/Core/Controller/Varien/Front.php(179): Mage_Core_Controller_Varien_Router_Standard->match()
#12 /var/www/html/app/code/core/Mage/Core/Model/App.php(354): Mage_Core_Controller_Varien_Front->dispatch()
#13 /var/www/html/app/Mage.php(777): Mage_Core_Model_App->run()
#14 /var/www/html/index.php(51): Mage::run()
#15 {main}