Skip to content

Commit 321ef84

Browse files
committed
Improve passphrase UI windows.
Unstable release.
1 parent 6bb70ee commit 321ef84

2 files changed

Lines changed: 52 additions & 52 deletions

File tree

debian/changelog

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
openmediavault-luksencryption (1.0.1) UNRELEASED; urgency=low
1+
openmediavault-luksencryption (1.0.1) unstable; urgency=low
22

33
* Added key add/change/remove methods.
44
* Misc fixes.
5+
* Improve passphrase UI windows.
56

6-
-- OpenMediaVault Plugin Developers <plugins@omv-extras.org> Thu, 05 Nov 2015 16:12:05 +0000
7+
-- OpenMediaVault Plugin Developers <plugins@omv-extras.org> Fri, 06 Nov 2015 10:39:17 +0000
78

89
openmediavault-luksencryption (1.0.0) UNRELEASED; urgency=low
910

var/www/openmediavault/js/omv/module/admin/storage/luks/Containers.js

Lines changed: 49 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,6 @@ Ext.define("OMV.module.admin.storage.luks.container.AddPassphrase", {
208208
hideResetButton: true,
209209
width: 450,
210210

211-
getFormConfig: function() {
212-
return {
213-
layout: {
214-
type: "vbox",
215-
align: "stretch"
216-
}
217-
};
218-
},
219-
220211
getFormItems: function() {
221212
var me = this;
222213
return [{
@@ -230,19 +221,30 @@ Ext.define("OMV.module.admin.storage.luks.container.AddPassphrase", {
230221
xtype: "passwordfield",
231222
name: "oldpassphrase",
232223
fieldLabel: _("Current passphrase"),
233-
allowBlank: false
234-
},{
235-
xtype: "passwordfield",
236-
name: "newpassphrase",
237-
fieldLabel: _("New passphrase"),
238224
allowBlank: false,
239-
triggerAction: "all"
225+
plugins: [{
226+
ptype: "fieldinfo",
227+
text: _("Enter an existing, valid passphrase that unlocks the device.")
228+
}]
240229
},{
241-
xtype: "passwordfield",
242-
name: "newpassphraseconf",
243-
fieldLabel: _("Confirm passphrase"),
244-
allowBlank: false,
245-
submitValue: false
230+
xtype: "fieldset",
231+
title: _("New passphrase to add to the encrypted device"),
232+
defaults: {
233+
labelSeparator: ""
234+
},
235+
items: [{
236+
xtype: "passwordfield",
237+
name: "newpassphrase",
238+
fieldLabel: _("Passphrase"),
239+
allowBlank: false,
240+
triggerAction: "all"
241+
},{
242+
xtype: "passwordfield",
243+
name: "newpassphraseconf",
244+
fieldLabel: _("Confirm passphrase"),
245+
allowBlank: false,
246+
submitValue: false
247+
}]
246248
}];
247249
},
248250

@@ -292,15 +294,6 @@ Ext.define("OMV.module.admin.storage.luks.container.ChangePassphrase", {
292294
hideResetButton: true,
293295
width: 450,
294296

295-
getFormConfig: function() {
296-
return {
297-
layout: {
298-
type: "vbox",
299-
align: "stretch"
300-
}
301-
};
302-
},
303-
304297
getFormItems: function() {
305298
var me = this;
306299
return [{
@@ -314,19 +307,30 @@ Ext.define("OMV.module.admin.storage.luks.container.ChangePassphrase", {
314307
xtype: "passwordfield",
315308
name: "oldpassphrase",
316309
fieldLabel: _("Current passphrase"),
317-
allowBlank: false
318-
},{
319-
xtype: "passwordfield",
320-
name: "newpassphrase",
321-
fieldLabel: _("New passphrase"),
322310
allowBlank: false,
323-
triggerAction: "all"
311+
plugins: [{
312+
ptype: "fieldinfo",
313+
text: _("Enter an existing, valid passphrase which you want to change.")
314+
}]
324315
},{
325-
xtype: "passwordfield",
326-
name: "newpassphraseconf",
327-
fieldLabel: _("Confirm passphrase"),
328-
allowBlank: false,
329-
submitValue: false
316+
xtype: "fieldset",
317+
title: _("New passphrase to replace the existing one (above)"),
318+
defaults: {
319+
labelSeparator: ""
320+
},
321+
items: [{
322+
xtype: "passwordfield",
323+
name: "newpassphrase",
324+
fieldLabel: _("Passphrase"),
325+
allowBlank: false,
326+
triggerAction: "all"
327+
},{
328+
xtype: "passwordfield",
329+
name: "newpassphraseconf",
330+
fieldLabel: _("Confirm passphrase"),
331+
allowBlank: false,
332+
submitValue: false
333+
}]
330334
}];
331335
},
332336

@@ -377,15 +381,6 @@ Ext.define("OMV.module.admin.storage.luks.container.RemovePassphrase", {
377381
hideResetButton: true,
378382
width: 450,
379383

380-
getFormConfig: function() {
381-
return {
382-
layout: {
383-
type: "vbox",
384-
align: "stretch"
385-
}
386-
};
387-
},
388-
389384
getFormItems: function() {
390385
var me = this;
391386
return [{
@@ -399,7 +394,11 @@ Ext.define("OMV.module.admin.storage.luks.container.RemovePassphrase", {
399394
xtype: "passwordfield",
400395
name: "passphrase",
401396
fieldLabel: _("Passphrase"),
402-
allowBlank: false
397+
allowBlank: false,
398+
plugins: [{
399+
ptype: "fieldinfo",
400+
text: _("Enter an existing, valid passphrase which you want to remove from the encrypted device.")
401+
}]
403402
}];
404403
},
405404

0 commit comments

Comments
 (0)