Unable to set 'SCRUB_OLDER_THAN_DAYS' value in UI

[nkm8]

the code references a SCRUB_OLDER_THAN_DAYS value that is passed to the snapraid scrub command.

This value currently isn't available to set in the UI: https://github.com/OpenMediaVault-Plugin-Developers/openmediavault-snapraid/blob/master/srv/salt/omv/deploy/snapraid/files/etc-snapraid-diff_conf.j2

Theoretically, one could set it manually in the /etc/snapraid-diff.conf file, but after making any changes in the UI, the value would be overwritten.

I am not sure if this is related to #35 or #34

[ryecoaaron]

That environment variable was added 11 years ago by a previous diff script maintainer (I don't maintain it). If it isn't set, it is set to 0

openmediavault-snapraid/usr/sbin/omv-snapraid-diff

Line 312 in 4495eac

if [ -z ${SCRUB_OLDER_THAN_DAYS} ]; then

I don't know if the old maintainer of the diff script forgot to ask me to add it to the web interface or what. Is there a reason you need it if it has never worked? I would prefer not to add it now since I would like to move to the diff script maintained by @auanasgheps in the omv8 version of the plugin.

[nkm8]

Works for me! Ironically, since posting this, I already switched and was able to get the aio script working in OMV7, which supports setting this value. Specifically, this allows setting the --older-than parameter for snapraid scrub, which I assume is what most people would want to control.

This script only allows setting the run frequency, but for the aio script, the recommendation is daily.

[auanasgheps]

@ryecoaaron we can definitely start planning the integration of my script.
I'm about to finalize anoter major release that has lots of improvements, whic coud be used as foundation for the adaptation.

[ryecoaaron]

@auanasgheps sounds good to me. Definitely would use the new release.