Skip to content

Commit 1798dee

Browse files
authored
Merge pull request #62 from OpenMined/madhava/small-fix
fixing small issue
2 parents c0a98d6 + 40ac28e commit 1798dee

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

rust/bioscript-formats/src/genotype/delimited/scan.rs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,12 +190,17 @@ pub(crate) fn scan_delimited_variants(
190190

191191
for (idx, variant) in indexed {
192192
if results[idx].genotype.is_none() {
193-
results[idx] = VariantObservation {
194-
backend: backend.backend_name().to_owned(),
195-
evidence: vec![format!(
193+
let evidence = if variant.has_coordinates() {
194+
format!(
196195
"no matching rsid or locus found for {}",
197196
describe_query(variant)
198-
)],
197+
)
198+
} else {
199+
"no matching rsid found".to_owned()
200+
};
201+
results[idx] = VariantObservation {
202+
backend: backend.backend_name().to_owned(),
203+
evidence: vec![evidence],
199204
..VariantObservation::default()
200205
};
201206
}

rust/bioscript-runtime/tests/security.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -546,11 +546,9 @@ if __name__ == "__main__":
546546
let output = fs::read_to_string(dir.join("outputs/batch.txt")).unwrap();
547547
assert!(output.contains("CT"), "{output}");
548548
assert!(output.contains("AG"), "{output}");
549+
assert!(output.contains("None"), "{output}");
549550
assert!(output.contains("VariantObservation"), "{output}");
550-
assert!(
551-
output.contains("no matching rsid or locus found"),
552-
"{output}"
553-
);
551+
assert!(output.contains("no matching"), "{output}");
554552
let timings = runtime.timing_snapshot();
555553
assert!(
556554
timings

0 commit comments

Comments
 (0)