Merge pull request #90 from OpenMined/fix/container-health

fix: graceful db shutdown and correct Docker healthcheck URL

Author: shubham3121

Dockerfile

@@ -87,6 +87,6 @@ ENV PATH="/app/.venv/bin:$PATH" \
 EXPOSE 8080
 
 HEALTHCHECK --interval=30s --timeout=10s --start-period=10s --retries=3 \
-    CMD python -c "import os; import urllib.request; urllib.request.urlopen(f'http://localhost:{os.getenv(\"SYFT_PORT\", \"8080\")}/health')" || exit 1
+    CMD python -c "import os; import urllib.request; urllib.request.urlopen(f'http://localhost:{os.getenv(\"SYFT_PORT\", \"8080\")}/api/v1/health')" || exit 1
 
 ENTRYPOINT ["/bin/sh", "-c", "exec python -m uvicorn syft_space.main:app --host 0.0.0.0 --port ${SYFT_PORT:-8080}"]

backend/syft_space/components/shared/database.py

@@ -100,6 +100,11 @@ def set_sqlite_pragma(dbapi_conn, connection_record):
                 cursor.close()
                 # logger.debug("SQLite PRAGMA foreign_keys=ON set for new connection")
 
+    async def dispose(self) -> None:
+        """Dispose of the engine and close all pooled connections."""
+        await self.engine.dispose()
+        logger.info("Database engine disposed")
+
     @asynccontextmanager
     async def get_session(self) -> AsyncGenerator[SQLModelAsyncSession, None]:
         """Get an async session for the database"""

backend/syft_space/main.py

@@ -298,6 +298,9 @@ async def lifespan(app: FastAPI):
         except Exception as e:
             logger.error(f"Error shutting down {name}: {e}")
 
+    # 9. Dispose database engine (close all pooled connections)
+    await database.dispose()
+
 
 # Initialize FastAPI app
 app = FastAPI(

docker-compose.yml

@@ -55,7 +55,7 @@ services:
 
     # Health check using Python (no curl in distroless image)
     healthcheck:
-      test: ["CMD", "python", "-c", "import urllib.request; urllib.request.urlopen('http://localhost:8080/health')"]
+      test: ["CMD", "python", "-c", "import urllib.request; urllib.request.urlopen('http://localhost:8080/api/v1/health')"]
       interval: 30s
       timeout: 10s
       retries: 3